Skip to content

rubocop test does not report failures in jenkins #147

@scpeters

Description

@scpeters

Environment

  • OS Version: 24.04
  • Source or binary build? source build of gz-tools2 (2d2cf69)

Description

  • Expected behavior: if rubocop test fails, it should be reported by jenkins
  • Actual behavior: it currently fails on 24.04 but is not registered as a failure by Jenkins

Steps to reproduce

  1. Observe https://build.osrfoundation.org/view/gz-ionic/job/gz_tools-ci-gz-tools2-noble-amd64/73/ is passing
  2. Look for rubocop test result in console log and observe that it failed

Output

test 2
    Start 2: rubocop

2: Test command: /usr/bin/rubocop "-E" "-c" "/home/jenkins/workspace/gz_tools-ci-gz-tools2-noble-amd64/gz-tools/src/../tools/.rubocop.yml" "/home/jenkins/workspace/gz_tools-ci-gz-tools2-noble-amd64/gz-tools/src"
2: Working Directory: /home/jenkins/workspace/gz_tools-ci-gz-tools2-noble-amd64/build/src
2: Test timeout computed to be: 1500
2: Inspecting 1 file
2: C
2: 
2: Offenses:
2: 
2: /home/jenkins/workspace/gz_tools-ci-gz-tools2-noble-amd64/gz-tools/src/gz.in:59:20: C: [Correctable] Style/StringConcatenation: Prefer string interpolation to string concatenation.
2:   next if Dir.glob(conf_directory + '/*.yaml').empty?
2:                    ^^^^^^^^^^^^^^^^^^^^^^^^^^
2: /home/jenkins/workspace/gz_tools-ci-gz-tools2-noble-amd64/gz-tools/src/gz.in:64:12: C: [Correctable] Style/StringConcatenation: Prefer string interpolation to string concatenation.
2:   Dir.glob(conf_directory + '/*.yaml') do |conf_file|
2:            ^^^^^^^^^^^^^^^^^^^^^^^^^^
2: /home/jenkins/workspace/gz_tools-ci-gz-tools2-noble-amd64/gz-tools/src/gz.in:197:12: C: [Correctable] Style/StringConcatenation: Prefer string interpolation to string concatenation.
2:   usage += '  ' + cmd + ':' + padding + versions.first[1]['description'] + "\n"
2:            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2: 
2: 1 file inspected, 3 offenses detected, 3 offenses autocorrectable
2/2 Test #2: rubocop ..........................***Failed    1.05 sec

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    Status

    Inbox

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions