From 9d89ea0538cca73b7f8f659380eec698c751b2bb Mon Sep 17 00:00:00 2001 From: momo <2438833481@qq.com> Date: Tue, 8 Jul 2025 17:22:08 +0800 Subject: [PATCH 1/3] add global guard in SelectEntities eventFilter to avoid null pointer crash on render engine failure Signed-off-by: momo <2438833481@qq.com> --- src/gui/plugins/select_entities/SelectEntities.cc | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/gui/plugins/select_entities/SelectEntities.cc b/src/gui/plugins/select_entities/SelectEntities.cc index 2e6e872a21..2f61fdf8ba 100644 --- a/src/gui/plugins/select_entities/SelectEntities.cc +++ b/src/gui/plugins/select_entities/SelectEntities.cc @@ -478,6 +478,11 @@ void SelectEntities::LoadConfig(const tinyxml2::XMLElement *) ///////////////////////////////////////////////// bool SelectEntities::eventFilter(QObject *_obj, QEvent *_event) { + if (!this->dataPtr->scene) + { + if (_event->type() != gz::gui::events::Render::kType) + return QObject::eventFilter(_obj, _event); + } if (_event->type() == gz::gui::events::LeftClickOnScene::kType) { gz::gui::events::LeftClickOnScene *_e = From c9be6674401e3f288fa915175696d6908d3da5d5 Mon Sep 17 00:00:00 2001 From: momo <2438833481@qq.com> Date: Tue, 8 Jul 2025 17:34:27 +0800 Subject: [PATCH 2/3] add a new line after codecheck Signed-off-by: momo <2438833481@qq.com> --- src/gui/plugins/select_entities/SelectEntities.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gui/plugins/select_entities/SelectEntities.cc b/src/gui/plugins/select_entities/SelectEntities.cc index 2f61fdf8ba..2fbdbc4538 100644 --- a/src/gui/plugins/select_entities/SelectEntities.cc +++ b/src/gui/plugins/select_entities/SelectEntities.cc @@ -598,3 +598,4 @@ bool SelectEntities::eventFilter(QObject *_obj, QEvent *_event) // Register this plugin GZ_ADD_PLUGIN(gz::sim::gui::SelectEntities, gz::gui::Plugin) + From c497842aad01ac16db31427fd9a425d09c40fa70 Mon Sep 17 00:00:00 2001 From: momo <2438833481@qq.com> Date: Tue, 8 Jul 2025 19:09:06 +0800 Subject: [PATCH 3/3] delete blank line Signed-off-by: momo <2438833481@qq.com> --- src/gui/plugins/select_entities/SelectEntities.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gui/plugins/select_entities/SelectEntities.cc b/src/gui/plugins/select_entities/SelectEntities.cc index 2fbdbc4538..2f61fdf8ba 100644 --- a/src/gui/plugins/select_entities/SelectEntities.cc +++ b/src/gui/plugins/select_entities/SelectEntities.cc @@ -598,4 +598,3 @@ bool SelectEntities::eventFilter(QObject *_obj, QEvent *_event) // Register this plugin GZ_ADD_PLUGIN(gz::sim::gui::SelectEntities, gz::gui::Plugin) -