CONDITION_ANY_START ....

[berti34]

Hi Gareth,

will there be someday a hook starting condition for the FORGET start?
I'm often get a Repo-locked error at the automatic start of the forget procedure, even after the snapshot was successful...
Because other clients had started a backup in between.

I made a little bash script for checking the lock status with CONDITION_SNAPSHOT_START, CONDITION_PURGE_START and CONDITION_CHECK_START and when locked it uses the ON_ERROR_RETRY_EXPONENTIAL_BACKOFF, which worked well.
BTW: https://garethgeorge.github.io/backrest/docs/hooks is missing the description of it.

Greetings

[garethgeorge]

Hi -- this is interesting. I think this is a hook system omission today, feel free to file a feature request for this , hooks for CONDITION_FORGET_START, CONDITION_FORGET_SUCCESS, and CONDITION_FORGET_FAILED definitely make sense to me to include.

As a side note, I'm very interested in how you're checking the lock status / to hear more about how well that's working with you? I've toyed with a similar idea but never pursued it, if it works well though it could be worth backrest supporting directly.

[berti34]

Hi Gareth,

this is my restic-check-locked.sh for the *_START-hooks:

#!/bin/bash

# Restic-Repository-URL (Rest-Server)
export RESTIC_REST_PASSWORD=abc
export RESTIC_REST_USERNAME=xyz
export RESTIC_PASSWORD_FILE="/etc/restic/backup.pwd"
export RESTIC_REPOSITORY="rest:http://backup.fritz.box:8181/"

SCRIPT=$( realpath "$0" )
BASEDIR=${SCRIPT%/*}

SCRIPTNAME=${SCRIPT##*/}
function usage() { # {{{
    echo "Usage:" >&2
    echo "$SCRIPTNAME -d -v -h" >&2
    echo " -h     This help" >&2
    echo " -d     Bash debug" >&2
    echo " -v 1-9 Verbose output" >&2
    exit 1
} # }}}


# Parse command line arguments {{{
VERB=0
while [ $# -ge 1 ]; do
  case "$1" in
    -d|--d*) set -x ;;
    -h|--h*) usage ;;
    -v|--v*) if [[ "$2" =~ ^[0-9]+$ ]]; then
               VERB="$2" 
               shift
             else
               (( VERB++ )) 
             fi ;;
    --)  shift
         break ;;
    *)  echo "Invalid option $1" >&2
        usage ;;
  esac
  shift
done
# }}}

if [ ! -s "$RESTIC_PASSWORD_FILE" ]; then
    echo "Missing repository password file: $RESTIC_PASSWORD_FILE" >&2
    exit 1
fi

# Check on lock
LOCKS=$(restic --insecure-tls list locks 2>&1)

if [ -z "$LOCKS" ]; then
    [ $VERB -ge 1 ] && echo "Keep going! The repository is not in lock status."
    exit 0
else
    echo "The repository is in lock status!"
    echo "$LOCKS"

    restic --insecure-tls cat lock "$LOCKS"
    exit 1
fi

[berti34]

Hi again,

this would be nice and useful:
hooks for CONDITION_ANY_START, CONDITION_ANY_SUCCESS, CONDITION_ANY_WARNING and CONDITION_ANY_FAILED,
just like the CONDITION_ANY_ERROR

What do you think?