fix(quote): allow ETFs w/o dividendYield,netExpenseRatio (fixes #914)

Author: gadicc

src/modules/options.schema.json

@@ -1491,7 +1491,6 @@
         }
       },
       "required": [
-        "dividendYield",
         "esgPopulated",
         "exchange",
         "exchangeDataDelayedBy",
@@ -1503,7 +1502,6 @@
         "market",
         "marketState",
         "netAssets",
-        "netExpenseRatio",
         "priceHint",
         "quoteType",
         "region",

src/modules/quote.schema.json

@@ -1418,7 +1418,6 @@
         }
       },
       "required": [
-        "dividendYield",
         "esgPopulated",
         "exchange",
         "exchangeDataDelayedBy",
@@ -1430,7 +1429,6 @@
         "market",
         "marketState",
         "netAssets",
-        "netExpenseRatio",
         "priceHint",
         "quoteType",
         "region",

src/modules/quote.test.ts

@@ -34,6 +34,7 @@ describe("quote", () => {
       "LDO.MI", // additionalProperty: underlyingSymbol (#363)
       "ZRC-USD", // Low cap crypto (#403)
       "SOHO", // "openInterest" prop (#445)
+      "VWRL.L", // ETF with no dividendYield, expenseRatio (#914)
     ],
   });
 

src/modules/quote.ts

@@ -157,9 +157,9 @@ export interface QuoteCurrency extends QuoteBase {
 
 export interface QuoteEtf extends QuoteBase {
   quoteType: "ETF";
-  dividendYield: number; // 0.54
+  dividendYield?: number; // 0.54
   netAssets: number; // 328302690000
-  netExpenseRatio: number; // 0.2
+  netExpenseRatio?: number; // 0.2
 }
 
 export interface QuoteEquity extends QuoteBase {

tests/fixtures/http/quote-VWRL.L.json

@@ -0,0 +1,99 @@
+{
+  "request": {
+    "url": "https://query2.finance.yahoo.com/v7/finance/quote?symbols=VWRL.L&crumb=haT3oykhHqZ",
+    "method": "GET",
+    "headers": {
+      "cookie": "GUCS=AV78X-IQ; GUC=AQABCAFnsytn2UIgTASn&s=AQAAAEKG89vA&g=Z7HctQ; A3=d=AQABBKvcsWcCEIGLkyl67hr2YX7XekV46j4FEgABCAErs2fZZ_bPb2UB9qMAAAcIq9yxZ63aZoI&S=AQAAAtFJa---IoVh8DRgGhGzVr4; A1S=d=AQABBKvcsWcCEIGLkyl67hr2YX7XekV46j4FEgABCAErs2fZZ_bPb2UB9qMAAAcIq9yxZ63aZoI&S=AQAAAtFJa---IoVh8DRgGhGzVr4; EuConsent=CQM66kAQM66kAAOACBENBcFoAP_gAEPgACiQKptB9G7WTXFneXp2YPskOYUX0VBJ4MAwBgCBAcABzBIUIBwGVmAzJEyIICACGAIAIGBBIABtGAhAQEAAYIAFAABIAEgAIBAAIGAAACAAAABACAAAAAAAAAAQgEAXMBQgmAYEBFoIQUhAggAgAQAAAAAEAIgBCgQAEAAAQAAICAAIACgAAgAAAAAAAAAEAFAIEQAAIAECAotkdQAAAAAAAAAAAAQACAABAAAAAIKpgAkGpUQBFgSEhAIGEECAEQUBABQIAgAACBAAAATBAUIAwAVGAiAEAIAAAAAAAAACABAAABAAhAAEAAQIAAAAAIAAgAIBAAACAAAAAAAAAAAAAAAAAAAAAAAAAGIBAggAAABBAAQUAAAAAgAAAAAAAAAIgACAAAAAAAAAAAAAAIgAAAAAAAAAAAAAAAAAAIAAAAIAAAAgBEFgAAAAAAAAAAAAAACAABAAAAAIAAA; A1=d=AQABBKvcsWcCEIGLkyl67hr2YX7XekV46j4FEgABCAErs2fZZ_bPb2UB9qMAAAcIq9yxZ63aZoI&S=AQAAAtFJa---IoVh8DRgGhGzVr4",
+      "user-agent": "@gadicc/yahoo-finance2/0.0.1 (+https://github.com/gadicc/node-yahoo-finance2)"
+    }
+  },
+  "response": {
+    "ok": true,
+    "status": 200,
+    "statusText": "OK",
+    "headers": {
+      "age": "0",
+      "cache-control": "public, max-age=1, stale-while-revalidate=9",
+      "content-length": "1679",
+      "content-type": "application/json;charset=utf-8",
+      "date": "Fri, 23 May 2025 00:37:52 GMT",
+      "referrer-policy": "no-referrer-when-downgrade",
+      "server": "ATS",
+      "strict-transport-security": "max-age=31536000",
+      "vary": "Origin,Accept-Encoding",
+      "x-content-type-options": "nosniff",
+      "x-envoy-decorator-operation": "finance-quote-api--mtls-baseline-production-sg3.finance-k8s:4080/*",
+      "x-envoy-upstream-service-time": "3",
+      "x-frame-options": "SAMEORIGIN",
+      "x-xss-protection": "1; mode=block",
+      "y-rid": "1nqlnnlk2vgr0"
+    },
+    "bodyJson": {
+      "quoteResponse": {
+        "result": [
+          {
+            "language": "en-US",
+            "region": "US",
+            "quoteType": "ETF",
+            "typeDisp": "ETF",
+            "quoteSourceName": "Delayed Quote",
+            "triggerable": false,
+            "customPriceAlertConfidence": "LOW",
+            "currency": "GBP",
+            "regularMarketChangePercent": -1.0992047,
+            "regularMarketPrice": 106.62,
+            "exchange": "LSE",
+            "messageBoardId": "finmb_215299893",
+            "exchangeTimezoneName": "Europe/London",
+            "exchangeTimezoneShortName": "BST",
+            "gmtOffSetMilliseconds": 3600000,
+            "market": "gb_market",
+            "esgPopulated": false,
+            "regularMarketDayHigh": 0,
+            "regularMarketDayRange": "0.0 - 0.0",
+            "regularMarketDayLow": 0,
+            "regularMarketVolume": 166,
+            "regularMarketPreviousClose": 107.805,
+            "bid": 0,
+            "ask": 0,
+            "bidSize": 378,
+            "askSize": 5000,
+            "fullExchangeName": "LSE",
+            "regularMarketOpen": 0,
+            "averageDailyVolume3Month": 106823,
+            "averageDailyVolume10Day": 63811,
+            "fiftyTwoWeekLowChange": 106.62,
+            "fiftyTwoWeekRange": "0.0 - 115.64",
+            "fiftyTwoWeekHighChange": -9.019997,
+            "fiftyTwoWeekHighChangePercent": -0.078000665,
+            "fiftyTwoWeekLow": 0,
+            "fiftyTwoWeekHigh": 115.64,
+            "fiftyTwoWeekChangePercent": 5.1653504,
+            "netAssets": 37080572000,
+            "fiftyDayAverage": 103.2779,
+            "fiftyDayAverageChange": 3.342102,
+            "fiftyDayAverageChangePercent": 0.03236028,
+            "twoHundredDayAverage": 107.39438,
+            "twoHundredDayAverageChange": -0.7743759,
+            "twoHundredDayAverageChangePercent": -0.0072105816,
+            "sourceInterval": 15,
+            "exchangeDataDelayedBy": 15,
+            "tradeable": false,
+            "cryptoTradeable": false,
+            "hasPrePostMarketData": false,
+            "firstTradeDateMilliseconds": 1337670000000,
+            "priceHint": 2,
+            "regularMarketChange": -1.1849976,
+            "shortName": "VANGUARD FUNDS PLC VANGUARD FTS",
+            "longName": "Vanguard FTSE All-World UCITS ETF",
+            "corporateActions": [],
+            "regularMarketTime": 1747928119,
+            "marketState": "PREPRE",
+            "symbol": "VWRL.L"
+          }
+        ],
+        "error": null
+      }
+    }
+  }
+}