fix(modules): finish up { validateOptions: false } module opt

Relates to #892, still need to add some docs somewhere

Author: gadicc

src/lib/moduleCommon.ts

@@ -1,9 +1,14 @@
 // import type ModuleExec from "./moduleExec.js";
 
 export interface ModuleOptions {
+  /** If false, lib won't validaet and will leave that to Yahoo */
+  validateOptions?: boolean;
+  /** If false, will pass back unvalidated / untyped result from Yahoo  */
   validateResult?: boolean;
+  /** Filename to use for cached result */
   devel?: boolean | string;
-  fetchOptions?: object;
+  /** Any options to pass to fetch() just for this request. */
+  fetchOptions?: Parameters<typeof fetch>[1];
 }
 
 export interface ModuleOptionsWithValidateFalse extends ModuleOptions {

src/lib/moduleExec.test.ts

@@ -54,14 +54,12 @@ describe("moduleExec", () => {
       await expect(rwo({ invalid: true })).rejects.toThrow(InvalidOptionsError);
     });
 
-    /*
-    XXX TODO
-    * with new yf() option, and with moduleoptions
-    it("throws InvalidOptions on invalid options with validateOptions = false", async () => {
-      const rwo = (options: any) => yf.search("symbol", options);
-      await expect(rwo({ invalid: true })).rejects.toThrow(InvalidOptionsError);
+    it("does not throw InvalidOptions on invalid options with validateOptions = false", async () => {
+      // deno-lint-ignore no-explicit-any
+      const rwo = (options: any) =>
+        yf.search("symbol", options, { validateOptions: false });
+      await expect(rwo({ invalid: true })).resolves.toBeDefined();
     });
-    */
 
     it("accepts empty queryOptions", async () => {
       await expect(

src/lib/moduleExec.ts

@@ -20,6 +20,7 @@ import validateAndCoerceTypes, {
 } from "./validateAndCoerceTypes.ts";
 import csv2json from "./csv2json.ts";
 import type { JSONSchema } from "./validate/index.ts";
+import type { ModuleOptions } from "./moduleCommon.ts";
 
 // The consuming module itself will have a stricter return type.
 // deno-lint-ignore no-explicit-any
@@ -107,14 +108,7 @@ interface ModuleExecOptions {
     transformWith?: TransformFunc;
   };
 
-  moduleOptions?: {
-    /** Allow validation failures to pass if false; */
-    validateOptions?: boolean;
-    /** Allow validation failures to pass if false; */
-    validateResult?: boolean;
-    /** Any options to pass to fetch() just for this request. */
-    fetchOptions?: Parameters<typeof fetch>[1];
-  };
+  moduleOptions?: ModuleOptions;
 }
 
 // deno-lint-ignore no-explicit-any