Register strings as a reusable helper to prevent undefined

Author: MartinFournier

msgfmt:ui/lib/client.js

@@ -181,49 +181,50 @@ Template.mfTrans.helpers({
   }
 });
 
+Template.registerHelper('strings', function() {
+  var orig = mfPkg.native;
+  var lang = RouterLayer.getParam('lang');
+
+  // summarise matching keys (orig + trans) to a single record
+  var out = {}, strings = mfPkg.mfStrings.find({
+    $and: [{$or: [{lang: orig}, {lang: lang}]},
+      {removed: undefined}]
+  }).fetch();
+
+  _.each(strings, function(str) {
+    if (!out[str.key])
+      out[str.key] = { key: str.key };
+    if (str.lang == orig)
+      out[str.key].orig = str.text;
+    else
+      out[str.key].trans = str.text;
+    if (str.fuzzy)
+      out[str.key].fuzzy = true;
+  });
+
+  strings = _.values(out);
+  strings.sort(function(a, b) {
+    if (!a.trans && b.trans)
+      return -1;
+    else if (a.trans && !b.trans)
+      return 1;
+
+    if (!a.fuzzy && b.fuzzy)
+      return -1;
+    else if (b.fuzzy && !a.fuzzy)
+      return 1;
+
+    return a.text - b.text;
+  });
+
+  return strings;
+});
+
 Template.mfTransLang.helpers({
   origLang: mfPkg.native,
   destLang: function() { return RouterLayer.getParam('lang'); },
   allowed: function() {
     return !mfPkg.webUI.allowed.call(this) || mfPkg.webUI.denied.call(this);
-  },
-  strings: function() {
-    var orig = mfPkg.native;
-    var lang = RouterLayer.getParam('lang');
-
-    // summarise matching keys (orig + trans) to a single record
-    var out = {}, strings = mfPkg.mfStrings.find({
-      $and: [{$or: [{lang: orig}, {lang: lang}]},
-        {removed: undefined}]
-    }).fetch();
-
-    _.each(strings, function(str) {
-      if (!out[str.key])
-        out[str.key] = { key: str.key };
-      if (str.lang == orig)
-        out[str.key].orig = str.text;
-      else
-        out[str.key].trans = str.text;
-      if (str.fuzzy)
-        out[str.key].fuzzy = true;
-    });
-
-    strings = _.values(out);
-    strings.sort(function(a, b) {
-      if (!a.trans && b.trans)
-        return -1;
-      else if (a.trans && !b.trans)
-        return 1;
-
-      if (!a.fuzzy && b.fuzzy)
-        return -1;
-      else if (b.fuzzy && !a.fuzzy)
-        return 1;
-
-      return a.text - b.text;
-    });
-
-    return strings;
   }
 });
 
@@ -261,11 +262,14 @@ Template.mfTransLang.events({
 
 Template.mfTransLang.helpers({
   sortedStrings: function() {
+    var strings = Blaze._globalHelpers['strings'];
+    if (!strings) return;
+
     var sortField = Session.get('translationSortField');
     if (!sortField) {
       Session.set('translationSortField', 'orig');
     }
-    return this.strings.sort(function(a, b) {
+    return strings().sort(function(a, b) {
       return a[sortField] > b[sortField] ? 1 : (a[sortField] < b[sortField] ? -1 : 0);
     });
   },