Skip to content

Commit a1df723

Browse files
committed
refactor: rename *_is_hybrid -> *_is_hybrid_recurrent
The implementation of the hybrid cache intentionally does not specify the types of the child caches, so there was a naming mismatch with these predicate functions that used "hybrid" to imply "hybrid recurrent." Branch: HybridCache Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>
1 parent 7fb0ed3 commit a1df723

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

include/llama.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -573,7 +573,7 @@ extern "C" {
573573
LLAMA_API bool llama_model_is_recurrent(const struct llama_model * model);
574574

575575
// Returns true if the model is hybrid-recurrent (like Jamba, Bamba, etc.)
576-
LLAMA_API bool llama_model_is_hybrid(const struct llama_model * model);
576+
LLAMA_API bool llama_model_is_hybrid_recurrent(const struct llama_model * model);
577577

578578
// Returns 0 on success
579579
LLAMA_API uint32_t llama_model_quantize(

src/llama-arch.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1831,7 +1831,7 @@ bool llm_arch_is_recurrent(const llm_arch & arch) {
18311831
}
18321832
}
18331833

1834-
bool llm_arch_is_hybrid(const llm_arch & arch) {
1834+
bool llm_arch_is_hybrid_recurrent(const llm_arch & arch) {
18351835
// TODO: There are currently no hybrid models! Once there are, this will be
18361836
// the place to identify them
18371837
switch (arch) {

src/llama-arch.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -442,4 +442,4 @@ llm_arch llm_arch_from_string(const std::string & name);
442442
const llm_tensor_info & llm_tensor_info_for(llm_tensor tensor);
443443

444444
bool llm_arch_is_recurrent(const llm_arch& arch);
445-
bool llm_arch_is_hybrid(const llm_arch& arch);
445+
bool llm_arch_is_hybrid_recurrent(const llm_arch& arch);

src/llama-model.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14384,8 +14384,8 @@ bool llama_model_is_recurrent(const llama_model * model) {
1438414384
return llm_arch_is_recurrent(model->arch);
1438514385
}
1438614386

14387-
bool llama_model_is_hybrid(const llama_model * model) {
14388-
return llm_arch_is_hybrid(model->arch);
14387+
bool llama_model_is_hybrid_recurrent(const llama_model * model) {
14388+
return llm_arch_is_hybrid_recurrent(model->arch);
1438914389
}
1439014390

1439114391
const std::vector<std::pair<std::string, ggml_tensor *>> & llama_internal_get_tensor_map(const llama_model * model) {

0 commit comments

Comments
 (0)