Refactor event handling and improve logging

Introduce `LogEventArgs` for `LogCreated` and `LogCreating` events in `IAutomationClient.cs` and `AutomationClient.cs`. Update `using` directives to include `G4.Models.Events`. Modify `RegisterInvokerEvents` to accept `G4AutomationModel automation` parameter. Update event handler registration to use `LogEventArgs` with properties like `Automation`, `AutomationGroup`, `Invoker`, and `LogMessage`. Use named arguments in `NewDelegate` method. Add error handling and logging to ensure exceptions are properly logged.

Author: gravity-api

src/G4.Api/Abstractions/IAutomationClient.cs

@@ -1,5 +1,6 @@
 using G4.Api.Models;
 using G4.Models;
+using G4.Models.Events;
 using G4.Plugins;
 
 using Microsoft.Extensions.Logging;
@@ -58,12 +59,12 @@ public interface IAutomationClient
         /// <summary>
         /// Occurs after a log entry has been created.
         /// </summary>
-        event EventHandler<IDictionary<string, object>> LogCreated;
+        event EventHandler<LogEventArgs> LogCreated;
 
         /// <summary>
         /// Occurs before a log entry is created.
         /// </summary>
-        event EventHandler<IDictionary<string, object>> LogCreating;
+        event EventHandler<LogEventArgs> LogCreating;
 
         /// <summary>
         /// Occurs when an error occurs during action execution.

src/G4.Api/Clients/AutomationClient.cs

@@ -4,6 +4,7 @@
 using G4.Cache;
 using G4.Extensions;
 using G4.Models;
+using G4.Models.Events;
 using G4.Plugins;
 using G4.Plugins.Engine;
 
@@ -50,10 +51,10 @@ internal class AutomationClient(ILogger logger) : ClientBase, IAutomationClient
         public event EventHandler<JobEventArgs> JobStatusChanged;
 
         /// <inheritdoc />
-        public event EventHandler<IDictionary<string, object>> LogCreated;
+        public event EventHandler<LogEventArgs> LogCreated;
 
         /// <inheritdoc />
-        public event EventHandler<IDictionary<string, object>> LogCreating;
+        public event EventHandler<LogEventArgs> LogCreating;
 
         /// <inheritdoc />
         public event EventHandler<(RuleEventArgs EventArguments, Exception Exception)> OnRuleError;
@@ -229,7 +230,7 @@ private static ConcurrentBag<AutomationQueueModel> NewAutomationRequests(
                 // Set up new invoker events using the client and the newly created queue model
                 if (registerStatusEvents)
                 {
-                    RegisterInvokerEvents(client, invoker);
+                    RegisterInvokerEvents(client, automation, invoker);
                 }
 
                 // Invoke the AutomationRequestInitialized event on the client
@@ -244,7 +245,7 @@ private static ConcurrentBag<AutomationQueueModel> NewAutomationRequests(
         }
 
         // Registers event handlers for the invoker by wrapping the client's event handlers with exception handling and logging.
-        private static void RegisterInvokerEvents(AutomationClient client, AutomationInvoker invoker)
+        private static void RegisterInvokerEvents(AutomationClient client, G4AutomationModel automation, AutomationInvoker invoker)
         {
             // Creates a new delegate that wraps an event handler with exception handling and logging.
             static EventHandler<T> NewDelegate<T>(AutomationClient client, EventHandler<T> eventHandler)
@@ -255,7 +256,7 @@ static EventHandler<T> NewDelegate<T>(AutomationClient client, EventHandler<T> e
                     try
                     {
                         // Safely invoke the event handler if it's not null
-                        eventHandler?.Invoke(sender, args);
+                        eventHandler?.Invoke(sender, e: args);
                     }
                     catch (Exception e)
                     {
@@ -287,8 +288,51 @@ static EventHandler<T> NewDelegate<T>(AutomationClient client, EventHandler<T> e
             invoker.StageInvoking += NewDelegate(client, client.StageInvoking);
             invoker.StageStatusChanged += NewDelegate(client, client.StageStatusChanged);
 
-            logger.LogCreated += NewDelegate(client, client.LogCreated);
-            logger.LogCreating += NewDelegate(client, client.LogCreating);
+            logger.LogCreated += (sender, args) =>
+            {
+                try
+                {
+                    // Safely invoke the event handler if it's not null
+                    client.LogCreated?.Invoke(sender, e: new LogEventArgs
+                    {
+                        Automation = automation.Reference?.Id,
+                        AutomationGroup = automation.Reference?.GroupId,
+                        Invoker = invoker.Reference,
+                        LogMessage = args
+                    });
+                }
+                catch (Exception e)
+                {
+                    // Log the error if an exception occurs during event invocation
+                    client.Logger.LogError(
+                        exception: e,
+                        message: "Error in event handler. Sender: {Sender}, EventArgs: {EventArgs}",
+                        sender?.GetType().FullName, typeof(object).Name);
+                }
+            };
+
+            logger.LogCreating += (sender, args) =>
+            {
+                try
+                {
+                    // Safely invoke the event handler if it's not null
+                    client.LogCreating?.Invoke(sender, e: new LogEventArgs
+                    {
+                        Automation = automation.Reference?.Id,
+                        AutomationGroup = automation.GroupId,
+                        Invoker = invoker.Reference,
+                        LogMessage = args
+                    });
+                }
+                catch (Exception e)
+                {
+                    // Log the error if an exception occurs during event invocation
+                    client.Logger.LogError(
+                        exception: e,
+                        message: "Error in event handler. Sender: {Sender}, EventArgs: {EventArgs}",
+                        sender?.GetType().FullName, typeof(object).Name);
+                }
+            };
         }
         #endregion
     }