Merge pull request #8 from g0rdan/dont-show-private-repos

fix: check for http response status

Author: g0rdan

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Change Log
 
+## [0.1.3]
+
+- Fix issue when we try to show URL to a package that does not exist on pub.dev.
+
 ## [0.1.2]
 
 - Attempt to fix "colon" [issue](https://github.com/g0rdan/publink/issues/5)

README.md

@@ -8,6 +8,10 @@ This extension allows you to see a hover with package's info from [pub.dev](http
 
 ## Release Notes
 
+### 0.1.3
+
+- Fix issue when we try to show URL to a package that does not exist on pub.dev.
+
 ### 0.1.2
 
 - Attempt to fix "colon" [issue](https://github.com/g0rdan/publink/issues/5)

package-lock.json

@@ -3,7 +3,7 @@
   "publisher": "gordin",
   "displayName": "PubLink",
   "description": "PubLink allows you quickly open a flutter/dart package on pub.dev",
-  "version": "0.1.2",
+  "version": "0.1.3",
   "license": "MIT",
   "icon": "assets/icons/main_icon.png",
   "repository": {

package.json

@@ -55,15 +55,20 @@ export class PubLinkModule {
     var data = new PackageData();
     try {
       // Fetch the HTML content from the web
-      const response = await axios.get(url);
+      const response = await axios.get(url).catch((error) => {
+        // If a request is outside of the 200 range, we want to return null
+        if (error.response) {
+          return null;
+        }
+      });
       // We want to make sure the URL is valid. There could be situations where
       // we have a git or local dependency, we don't want to mislead users with
       // these URLs.
-      if (response.status !== 200) {
+      if (response === null) {
         return null;
       }
 
-      const html = response.data;
+      const html = response!.data;
 
       // Parse the HTML content using jsdom
       const dom = new JSDOM(html);