simple gradle init setup with kotlin dsl gives errors at initial .kts files.

[fenilli]

Description

After using gradle init as application, kotlin and kotlin dsl, it gives errors at settings.gradle.kts and build.gradle.kts.

[{
	"resource": "/home/fenilli/Projetos/kotlingram/app/build.gradle.kts",
	"owner": "_generated_diagnostic_collection_name_#1",
	"code": "UNRESOLVED_REFERENCE",
	"severity": 8,
	"message": "Unresolved reference: mainClass",
	"source": "kotlin",
	"startLineNumber": 41,
	"startColumn": 5,
	"endLineNumber": 41,
	"endColumn": 14
}]

[{
	"resource": "/home/fenilli/Projetos/kotlingram/settings.gradle.kts",
	"owner": "_generated_diagnostic_collection_name_#1",
	"code": "VAL_REASSIGNMENT",
	"severity": 8,
	"message": "Val cannot be reassigned",
	"source": "kotlin",
	"startLineNumber": 10,
	"startColumn": 1,
	"endLineNumber": 10,
	"endColumn": 17
},{
	"resource": "/home/fenilli/Projetos/kotlingram/settings.gradle.kts",
	"owner": "_generated_diagnostic_collection_name_#1",
	"code": "UNRESOLVED_REFERENCE",
	"severity": 8,
	"message": "Unresolved reference: include",
	"source": "kotlin",
	"startLineNumber": 11,
	"startColumn": 1,
	"endLineNumber": 11,
	"endColumn": 8
}]

Extension version

v0.2.26

Additional context

[themkat]

@fwcd Can we move this to kotlin-language-server? This is not VSCode specific.

Writing down some initial thoughts after investigating a bit. I could not find a solution that was satisfactory (yet), but it might help others (more familiar with Gradle Kotlin DSL) who want to investigate 🙂 (or help me if I suddenly need to take a break due to work or other things 😛 )

First of all, the Gradle libraries provide extension functions for almost everything, but not include (see org.gradle.kotlin.dsl.ProjectExtensions and the various Extensions files in the Gradle source code, which is why everything else seems to work). We probably have to tweak settings in the Compiler settings in the language server for the build scripts.

• rootProject.name: The class org.gradle.api.Project is resolved here. This class has a getName-method, but not a setName-method, so the compiler interprets name as a val (i.e, immutable). Unsure on how this can be fixed. Might have to read up on the intellij source code to see how they solve it... Seems weird 😨
• include: This method exists in the delegate-property (you can find this by using this.delegate in your file, but you can't use it directly as it is package private!). My first idea was to provide our own extensions here. Might work if we create it in the same package, but seems hacky!
• mainClass: The problem here is that the body/input-function of application gets a regular function scope, not a this-scope. You can see this by completing it.mainClass. This is weird as the Action functional interface, which is the input to application, has the annotation @HasImplicitReceiver which should give the function sent in a this-scope.

At the moment, I'm very unsure on how to solve all of these 🙁 Maybe some of these could be fixed if our compiler respected annotations a bit more? (it respects the templates annotations to my knowledge, but the rest??). Maybe there are more annotation magic I have not found yet..? Will probably look into that next when I find time.

EDIT: Seems like we have a known issue relating to the mainClass issue mentioned above: #216

Also tried to check if the current implementation reads the SamWithReceiversAnnotation values, and print them using a log statement. It does! Log statement of annotationsForSamWithReceivers for the given script templates being read in the compiler: Sam with receivers [[], [org.gradle.api.HasImplicitReceiver], [org.gradle.api.HasImplicitReceiver], [org.gradle.api.HasImplicitReceiver]]. This leads me to believe that we need some sort of plugin that the above issue mentions.

[themkat]

Found the reason for point nr 1 and 2. Should probably have checked that earlier. The reason is that delegate object in Settings scripts should be Settings, not Project (the last one is correct for build-scripts). That is the reason that rootProject only has getName due to it being from Project (in Settings, getRootProject returns a ProjectDescriptor which also has a setter!). Same with include which is a method in Settings). The reason is off course that the settings.gradle.kts file doesn't use the correct template (at least to my knowledge). It should use KotlinSettingsScript, but uses KotlinBuildScript. This is further proved by logging the script definitions they use (seems like I missed this in the log the first time around):

KtFile: /..../testproj/settings.gradle.kts -> ScriptDefinition: KotlinBuildScript
KtFile: /..../testproj/app/build.gradle.kts -> ScriptDefinition: KotlinBuildScript

Some of these things might have seemed more obvious to some of you who are more familiar with Kotlin Gradle DSL. I had not used it much beyond reading some code before investigating this issue 😛

Issue number 3 (the one with mainClass) should be fixed by the PR above 🙂

EDIT: Have a hacky solution for point 1 and 2 now. Will look into if there is a better solution. If I don't find anything better, I will make a PR for it either tonight or tomorrow.