Skip to content

Commit 7be5ca3

Browse files
authored
Merge pull request #414 from gayanper/1.8.0_upgrade
Upgrade to kotlin 1.8.0
2 parents 11999fe + 6066049 commit 7be5ca3

File tree

5 files changed

+13
-10
lines changed

5 files changed

+13
-10
lines changed

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
projectVersion=1.3.2
2-
kotlinVersion=1.6.10
2+
kotlinVersion=1.8.10
33
exposedVersion=0.37.3
44
lsp4jVersion=0.15.0
55
javaVersion=11

server/src/main/kotlin/org/javacs/kt/compiler/Compiler.kt

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
@file:OptIn(ExperimentalCompilerApi::class)
2+
@file:Suppress("DEPRECATION")
3+
14
package org.javacs.kt.compiler
25

36
import com.intellij.lang.Language
@@ -67,6 +70,8 @@ import org.jetbrains.kotlin.cli.jvm.compiler.CliBindingTrace
6770
import org.jetbrains.kotlin.cli.jvm.compiler.EnvironmentConfigFiles
6871
import org.jetbrains.kotlin.cli.jvm.compiler.KotlinCoreEnvironment
6972
import org.jetbrains.kotlin.cli.jvm.compiler.TopDownAnalyzerFacadeForJVM
73+
import org.jetbrains.kotlin.cli.jvm.config.configureJdkClasspathRoots
74+
import org.jetbrains.kotlin.compiler.plugin.ExperimentalCompilerApi
7075
import org.jetbrains.kotlin.config.*
7176
import org.jetbrains.kotlin.resolve.scopes.LexicalScope
7277
import org.jetbrains.kotlin.samWithReceiver.CliSamWithReceiverComponentContributor
@@ -111,6 +116,9 @@ private class CompilationEnvironment(
111116
add(ComponentRegistrar.PLUGIN_COMPONENT_REGISTRARS, ScriptingCompilerConfigurationComponentRegistrar())
112117
put(JVMConfigurationKeys.USE_PSI_CLASS_FILES_READING, true)
113118

119+
// configure jvm runtime classpaths
120+
configureJdkClasspathRoots()
121+
114122
addJvmClasspathRoots(classPath.map { it.toFile() })
115123
addJavaSourceRoots(javaSourcePath.map { it.toFile() })
116124

server/src/main/kotlin/org/javacs/kt/completion/RenderCompletionItem.kt

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,20 +9,13 @@ import org.jetbrains.kotlin.builtins.isFunctionType
99
import org.jetbrains.kotlin.renderer.ClassifierNamePolicy
1010
import org.jetbrains.kotlin.renderer.DescriptorRenderer
1111
import org.jetbrains.kotlin.renderer.ParameterNameRenderingPolicy
12-
import org.jetbrains.kotlin.types.ErrorUtils
13-
import org.jetbrains.kotlin.types.UnresolvedType
1412

1513
val DECL_RENDERER = DescriptorRenderer.withOptions {
1614
withDefinedIn = false
1715
modifiers = emptySet()
1816
classifierNamePolicy = ClassifierNamePolicy.SHORT
1917
parameterNameRenderingPolicy = ParameterNameRenderingPolicy.ONLY_NON_SYNTHESIZED
20-
typeNormalizer = {
21-
when (it) {
22-
is UnresolvedType -> ErrorUtils.createErrorTypeWithCustomDebugName(it.presentableName)
23-
else -> it
24-
}
25-
}
18+
typeNormalizer = { it -> it }
2619
}
2720

2821
private val GOOD_IDENTIFIER = Regex("[a-zA-Z]\\w*")

server/src/main/kotlin/org/javacs/kt/hover/Hovers.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import org.javacs.kt.completion.DECL_RENDERER
2020
import org.javacs.kt.position.position
2121
import org.javacs.kt.util.findParent
2222
import org.javacs.kt.signaturehelp.getDocString
23+
import org.jetbrains.kotlin.utils.IDEAPluginsCompatibilityAPI
2324

2425
fun hoverAt(file: CompiledFile, cursor: Int): Hover? {
2526
val (ref, target) = file.referenceAtPoint(cursor) ?: return typeHoverAt(file, cursor)
@@ -67,6 +68,7 @@ private fun renderJavaDoc(text: String): String {
6768
}.joinToString("\n")
6869
}
6970

71+
@OptIn(IDEAPluginsCompatibilityAPI::class)
7072
private fun renderTypeOf(element: KtExpression, bindingContext: BindingContext): String? {
7173
if (element is KtCallableDeclaration) {
7274
val descriptor = bindingContext[BindingContext.DECLARATION_TO_DESCRIPTOR, element]

server/src/test/kotlin/org/javacs/kt/OneFilePerformance.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ import org.jetbrains.kotlin.psi.KtPsiFactory
1919
import org.jetbrains.kotlin.resolve.BindingTraceContext
2020
import org.jetbrains.kotlin.resolve.LazyTopDownAnalyzer
2121
import org.jetbrains.kotlin.resolve.TopDownAnalysisMode
22-
import org.jetbrains.kotlin.resolve.calls.callUtil.getParentResolvedCall
2322
import org.jetbrains.kotlin.resolve.calls.smartcasts.DataFlowInfoFactory
23+
import org.jetbrains.kotlin.resolve.calls.util.getParentResolvedCall
2424
import org.junit.Test
2525
import org.openjdk.jmh.annotations.*
2626
import org.openjdk.jmh.runner.Runner

0 commit comments

Comments
 (0)