Skip to content

Commit 3aca373

Browse files
committed
refactorings to formatting
1 parent da6dc0f commit 3aca373

File tree

6 files changed

+36
-30
lines changed

6 files changed

+36
-30
lines changed

server/src/main/kotlin/org/javacs/kt/Configuration.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ data class InlayHintsConfiguration(
5757
var chainedHints: Boolean = false
5858
)
5959

60-
data class KtFmtConfiguration(
60+
data class KtfmtConfiguration(
6161
var style: String = "google",
6262
var indent: Int = 4,
6363
var maxWidth: Int = 100,
@@ -67,7 +67,7 @@ data class KtFmtConfiguration(
6767

6868
data class FormattingConfiguration(
6969
var formatter: String = "ktfmt",
70-
var ktFmt: KtFmtConfiguration = KtFmtConfiguration()
70+
var ktfmt: KtfmtConfiguration = KtfmtConfiguration()
7171
)
7272

7373
fun getStoragePath(params: InitializeParams): Path? {

server/src/main/kotlin/org/javacs/kt/KotlinWorkspaceService.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ class KotlinWorkspaceService(
110110
formatting.formatter = it
111111
}
112112
get("ktfmt")?.asJsonObject?.apply {
113-
val ktfmt = formatting.ktFmt
113+
val ktfmt = formatting.ktfmt
114114
get("style")?.asString?.let { ktfmt.style = it }
115115
get("indent")?.asInt?.let { ktfmt.indent = it }
116116
get("maxWidth")?.asInt?.let { ktfmt.maxWidth = it }
Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,8 @@
11
package org.javacs.kt.formatting
22

3-
import org.javacs.kt.Configuration
4-
import org.javacs.kt.FormattingConfiguration
53
import org.eclipse.lsp4j.FormattingOptions as LspFromattingOptions
64

7-
private const val DEFAULT_INDENT = 4
8-
9-
class FormattingService(private val config: FormattingConfiguration) {
10-
11-
private val formatter: Formatter get() = when (config.formatter) {
12-
"ktfmt" -> KtFmtFormatter(config.ktFmt)
13-
"none" -> NopFormatter
14-
else -> KtFmtFormatter(config.ktFmt)
15-
}
16-
17-
fun formatKotlinCode(
18-
code: String,
19-
options: LspFromattingOptions = LspFromattingOptions(DEFAULT_INDENT, true)
20-
): String = this.formatter.format(code, options)
21-
}
22-
23-
245
interface Formatter {
256
fun format(code: String, options: LspFromattingOptions): String
267
}
278

28-
object NopFormatter : Formatter {
29-
override fun format(code: String, options: LspFromattingOptions): String = code
30-
}
31-
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
package org.javacs.kt.formatting
2+
3+
import org.javacs.kt.Configuration
4+
import org.javacs.kt.FormattingConfiguration
5+
import org.eclipse.lsp4j.FormattingOptions as LspFromattingOptions
6+
7+
private const val DEFAULT_INDENT = 4
8+
9+
class FormattingService(private val config: FormattingConfiguration) {
10+
11+
private val formatter: Formatter get() = when (config.formatter) {
12+
"ktfmt" -> KtfmtFormatter(config.ktfmt)
13+
"none" -> NopFormatter
14+
else -> KtfmtFormatter(config.ktfmt)
15+
}
16+
17+
fun formatKotlinCode(
18+
code: String,
19+
options: LspFromattingOptions = LspFromattingOptions(DEFAULT_INDENT, true)
20+
): String = this.formatter.format(code, options)
21+
}

server/src/main/kotlin/org/javacs/kt/formatting/KtFmtFormatter.kt renamed to server/src/main/kotlin/org/javacs/kt/formatting/KtfmtFormatter.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
package org.javacs.kt.formatting
22

3-
import org.javacs.kt.KtFmtConfiguration
4-
import com.facebook.ktfmt.format.Formatter as KtFmt
3+
import org.javacs.kt.KtfmtConfiguration
4+
import com.facebook.ktfmt.format.Formatter as Ktfmt
55
import com.facebook.ktfmt.format.FormattingOptions as KtfmtOptions
66
import org.eclipse.lsp4j.FormattingOptions as LspFormattingOptions
77

8-
class KtFmtFormatter(private val config: KtFmtConfiguration) : Formatter {
8+
class KtfmtFormatter(private val config: KtfmtConfiguration) : Formatter {
99
override fun format(
1010
code: String,
1111
options: LspFormattingOptions,
@@ -16,7 +16,7 @@ class KtFmtFormatter(private val config: KtFmtConfiguration) : Formatter {
1616
"dropbox" -> KtfmtOptions.Style.DROPBOX
1717
else -> KtfmtOptions.Style.GOOGLE
1818
}
19-
return KtFmt.format(KtfmtOptions(
19+
return Ktfmt.format(KtfmtOptions(
2020
style = style,
2121
maxWidth = config.maxWidth,
2222
blockIndent = options.tabSize.takeUnless { it == 0 } ?: config.indent,
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
package org.javacs.kt.formatting
2+
3+
import org.eclipse.lsp4j.FormattingOptions as LspFormattingOptions
4+
5+
object NopFormatter : Formatter {
6+
override fun format(code: String, options: LspFormattingOptions): String = code
7+
}
8+

0 commit comments

Comments
 (0)