Skip to content

Commit 0fb98aa

Browse files
committed
Lint
1 parent 969616b commit 0fb98aa

File tree

4 files changed

+26
-8
lines changed

4 files changed

+26
-8
lines changed

server/src/main/kotlin/org/javacs/kt/Configuration.kt

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,15 @@
11
package org.javacs.kt
22

3-
import com.google.gson.*
3+
import com.google.gson.GsonBuilder
4+
import com.google.gson.JsonDeserializationContext
5+
import com.google.gson.JsonDeserializer
6+
import com.google.gson.JsonElement
7+
import com.google.gson.JsonParseException
48
import org.eclipse.lsp4j.InitializeParams
59
import org.jetbrains.exposed.sql.Database
610
import java.lang.reflect.Type
711
import java.nio.file.Files
12+
import java.nio.file.InvalidPathException
813
import java.nio.file.Path
914
import java.nio.file.Paths
1015

@@ -69,7 +74,7 @@ class GsonPathConverter : JsonDeserializer<Path?> {
6974
override fun deserialize(json: JsonElement, type: Type?, context: JsonDeserializationContext?): Path? {
7075
return try {
7176
Paths.get(json.asString)
72-
} catch (ex: Exception) {
77+
} catch (ex: InvalidPathException) {
7378
LOG.printStackTrace(ex)
7479
null
7580
}

server/src/main/kotlin/org/javacs/kt/index/SymbolIndex.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,9 @@ class PositionEntity(id: EntityID<Int>) : IntEntity(id) {
8080
/**
8181
* A global view of all available symbols across all packages.
8282
*/
83-
class SymbolIndex(private val db: Database = Database.connect("jdbc:h2:mem:symbolindex;DB_CLOSE_DELAY=-1", "org.h2.Driver")) {
83+
class SymbolIndex(
84+
private val db: Database = Database.connect("jdbc:h2:mem:symbolindex;DB_CLOSE_DELAY=-1", "org.h2.Driver")
85+
) {
8486
var progressFactory: Progress.Factory = Progress.Factory.None
8587

8688
init {

shared/src/main/kotlin/org/javacs/kt/classpath/CachedClassPathResolver.kt

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@ import org.jetbrains.exposed.dao.IntEntity
55
import org.jetbrains.exposed.dao.IntEntityClass
66
import org.jetbrains.exposed.dao.id.EntityID
77
import org.jetbrains.exposed.dao.id.IntIdTable
8-
import org.jetbrains.exposed.sql.*
8+
import org.jetbrains.exposed.sql.Database
9+
import org.jetbrains.exposed.sql.SchemaUtils
10+
import org.jetbrains.exposed.sql.deleteAll
911
import org.jetbrains.exposed.sql.transactions.transaction
1012
import java.nio.file.Path
1113
import java.nio.file.Paths
@@ -47,7 +49,10 @@ class BuildScriptClassPathCacheEntryEntity(id: EntityID<Int>) : IntEntity(id) {
4749
}
4850

4951
/** A classpath resolver that caches another resolver */
50-
internal class CachedClassPathResolver(private val wrapped: ClassPathResolver, private val db: Database) : ClassPathResolver {
52+
internal class CachedClassPathResolver(
53+
private val wrapped: ClassPathResolver,
54+
private val db: Database
55+
) : ClassPathResolver {
5156
override val resolverType: String get() = "Cached + ${wrapped.resolverType}"
5257

5358
private var cachedClassPathEntries: Set<ClassPathEntry>
@@ -96,7 +101,9 @@ internal class CachedClassPathResolver(private val wrapped: ClassPathResolver, p
96101

97102
init {
98103
transaction(db) {
99-
SchemaUtils.createMissingTablesAndColumns(ClassPathMetadataCache, ClassPathCacheEntry, BuildScriptClassPathCacheEntry)
104+
SchemaUtils.createMissingTablesAndColumns(
105+
ClassPathMetadataCache, ClassPathCacheEntry, BuildScriptClassPathCacheEntry
106+
)
100107
}
101108
}
102109

@@ -152,7 +159,9 @@ internal class CachedClassPathResolver(private val wrapped: ClassPathResolver, p
152159
private fun updateBuildScriptClasspathCache(newClasspath: Set<Path>) {
153160
transaction(db) {
154161
cachedBuildScriptClassPathEntries = newClasspath
155-
cachedClassPathMetadata = cachedClassPathMetadata?.copy(buildFileVersion = currentBuildFileVersion) ?: ClasspathMetadata()
162+
cachedClassPathMetadata = cachedClassPathMetadata?.copy(
163+
buildFileVersion = currentBuildFileVersion
164+
) ?: ClasspathMetadata()
156165
}
157166
}
158167

shared/src/main/kotlin/org/javacs/kt/classpath/ClassPathResolver.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,8 @@ internal class FirstNonEmptyClassPathResolver(val lhs: ClassPathResolver, val rh
7575
override val classpathOrEmpty get() = lhs.classpathOrEmpty.takeIf { it.isNotEmpty() } ?: rhs.classpathOrEmpty
7676
override val buildScriptClasspath get() = lhs.buildScriptClasspath.takeIf { it.isNotEmpty() } ?: rhs.buildScriptClasspath
7777
override val buildScriptClasspathOrEmpty get() = lhs.buildScriptClasspathOrEmpty.takeIf { it.isNotEmpty() } ?: rhs.buildScriptClasspathOrEmpty
78-
override val classpathWithSources get() = lhs.classpathWithSources.takeIf { it.isNotEmpty() } ?: rhs.classpathWithSources
78+
override val classpathWithSources get() = lhs.classpathWithSources.takeIf {
79+
it.isNotEmpty()
80+
} ?: rhs.classpathWithSources
7981
override val currentBuildFileVersion: Long get() = max(lhs.currentBuildFileVersion, rhs.currentBuildFileVersion)
8082
}

0 commit comments

Comments
 (0)