validate_ucis_xml()

[nsdjg]

As is, this routine returns None when it returns successful. It returns False when it fails.

Do you wish to maintain this or have it return True/False? I am asking because I want to use this routine with a test of fc4sc.

[mballance]

Hmm... Interesting point. From my perspective, the exception is the most important thing in terms of signaling pass/fail. Looks like that will be thrown with the current code. Adding in a single 'ret = True' after the call to assertValid() shouldn't be a problem.

pyucis/src/ucis/xml/__init__.py

Lines 45 to 69 in f73a275

	ret = False
	try:
	doc = etree.parse(fp)
	root = doc.getroot()
	# There is some inconsistency in whether
	# elements should be namespace-qualified or not.
	# The official schema indicates that they should be,
	# while the examples indicate they shouldn't be. The
	# (apparently) simplest way around this is to remove
	# namespace qualification entirely.
	for elem in root.getiterator():
	if not hasattr(elem.tag, 'find'): continue # (1)
	i = elem.tag.find('}')
	if i >= 0:
	elem.tag = elem.tag[i+1:]
	ret = ucis_schema.assertValid(doc)
	finally:
	if type(file_or_filename) == str:
	fp.close()
	return ret