Skip to content

Enhancement: CronController can avoid back-scheduling for Forbid #51

@irvinlim

Description

@irvinlim

Since we have updated to use the JobQueueController instead, the process of admitting a Job to be started is now asynchronous. The CronController will back-schedule multiple Jobs even though it should know at this point to just ignore the back-scheduling for ConcurrencyPolicyForbid, because the JobQueueController will just reject them as AdmissionError:

NAME                          AGE   PHASE            CREATED TASKS   RUN TIME   FINISH TIME
jobconfig-sample.1650055799   7s    Succeeded        1                          3s
jobconfig-sample.1650055814   7s    AdmissionError   0                          7s
jobconfig-sample.1650055829   7s    AdmissionError   0                          7s
jobconfig-sample.1650055844   7s    AdmissionError   0                          7s
jobconfig-sample.1650055859   7s    AdmissionError   0                          7s

In case users set a high back-scheduling limit, this may result in huge bursts of unnecessary Job creation.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/schedulingRelated to execution scheduling (e.g. cron, concurrency, etc)component/executionIssues or PRs related exclusively to the Execution component (Job, JobConfig)kind/enhancementCategorizes issues or PRs related to enhancements, rather than full features.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions