Skip to content

Commit 130e90b

Browse files
author
av
committed
Updated smppex, removed ugly consume_async_results usage
1 parent 02d5e54 commit 130e90b

File tree

3 files changed

+4
-12
lines changed

3 files changed

+4
-12
lines changed

lib/smppsend/esme_helpers.ex

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,10 @@ defmodule SMPPSend.ESMEHelpers do
1818
end
1919

2020
defp bind(esme, bind_pdu, esme_mod) do
21-
Logger.info "Binding"
22-
21+
Logger.info("Binding #{PP.format(bind_pdu)}")
2322
response = esme_mod.request(esme, bind_pdu)
2423
case response do
2524
{:ok, pdu} ->
26-
consume_async_results(esme, esme_mod)
2725
Logger.info("Bind response:#{PP.format(pdu)}")
2826
case Pdu.command_status(pdu) do
2927
0 ->
@@ -43,10 +41,9 @@ defmodule SMPPSend.ESMEHelpers do
4341
def send_messages(_esme, [], _esme_mod, message_ids), do: {:ok, Enum.reverse(message_ids)}
4442

4543
def send_messages(esme, [submit_sm | submit_sms], esme_mod, message_ids) do
46-
Logger.info("Sending submit_sm")
44+
Logger.info("Sending submit_sm#{PP.format(submit_sm)}")
4745
case esme_mod.request(esme, submit_sm) do
4846
{:ok, resp} ->
49-
consume_async_results(esme, esme_mod)
5047
Logger.info("Got response#{PP.format(resp)}")
5148
case Pdu.command_status(resp) do
5249
0 -> send_messages(esme, submit_sms, esme_mod, [Pdu.field(resp, :message_id) | message_ids])
@@ -97,11 +94,6 @@ defmodule SMPPSend.ESMEHelpers do
9794
end
9895
end
9996

100-
defp consume_async_results(esme, esme_mod) do
101-
pdus = esme_mod.pdus(esme)
102-
handle_async_results(esme, pdus)
103-
end
104-
10597
defp handle_async_results(esme, pdus, message_ids \\ [])
10698

10799
defp handle_async_results(_esme, [], message_ids), do: message_ids

mix.exs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ defmodule Smppsend.Mixfile do
44
def project do
55
[
66
app: :smppsend,
7-
version: "0.1.14",
7+
version: "0.1.15",
88
elixir: "~> 1.1",
99
build_embedded: Mix.env == :prod,
1010
start_permanent: Mix.env == :prod,

mix.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,5 @@
99
"mimerl": {:hex, :mimerl, "1.0.2", "993f9b0e084083405ed8252b99460c4f0563e41729ab42d9074fd5e52439be88", [:rebar3], [], "hexpm"},
1010
"poison": {:hex, :poison, "2.2.0", "4763b69a8a77bd77d26f477d196428b741261a761257ff1cf92753a0d4d24a63", [:mix], [], "hexpm"},
1111
"ranch": {:hex, :ranch, "1.4.0", "10272f95da79340fa7e8774ba7930b901713d272905d0012b06ca6d994f8826b", [:rebar3], [], "hexpm"},
12-
"smppex": {:hex, :smppex, "2.2.0", "cb9231463ce5a97ff45f63acbe07bb8d07d1e5d4415ba3325688a0f4827c3809", [:mix], [{:ranch, "~> 1.4", [hex: :ranch, repo: "hexpm", optional: false]}], "hexpm"},
12+
"smppex": {:hex, :smppex, "2.2.3", "c7fa7810273030a86dd92132a71f9dde4b6eca7c96ac7e4301bb5d08871ce74e", [:mix], [{:ranch, "~> 1.3", [hex: :ranch, repo: "hexpm", optional: false]}], "hexpm"},
1313
"ssl_verify_fun": {:hex, :ssl_verify_fun, "1.1.1", "28a4d65b7f59893bc2c7de786dec1e1555bd742d336043fe644ae956c3497fbe", [:make, :rebar], [], "hexpm"}}

0 commit comments

Comments
 (0)