Skip to content

Bug: README document contained a custom log example but imports were incorrect plus unused import #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Coderrob opened this issue Feb 12, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@Coderrob
Copy link

Describe the bug
Reading through the README documentation I was looking at custom logging examples. I noticed the import was from a 'base' logger but the imported types came from tslog. Looked like a copy paste problem so opened a PR to make corrections in case anyone copy pasted to start a custom logger.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://github.com/fullstack-build/tslog/blob/master/README.md?plain=1#L243
  2. See unused import and looks like from 'tslog'

Expected behavior
Updated documentation.

Screenshots
Image

@Coderrob Coderrob added the bug Something isn't working label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant