Skip to content

Commit 1561f4e

Browse files
committed
add title to image modal and fix spacing around items
1 parent bd542b9 commit 1561f4e

File tree

2 files changed

+18
-25
lines changed

2 files changed

+18
-25
lines changed

src/components/ImageModal.tsx

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2,35 +2,36 @@ import { faGithub } from '@fortawesome/free-brands-svg-icons';
22
import { faClose, faEye } from '@fortawesome/free-solid-svg-icons';
33
import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';
44

5-
type PropsType = {
6-
imgAlt: string;
7-
onClick: () => void;
8-
imgURL: string;
9-
liveURL: string;
10-
repoURL: string;
11-
};
12-
13-
const ImageModal = (props: PropsType) => {
14-
const { onClick, imgAlt, imgURL, liveURL, repoURL } = props;
5+
import { ProjectType } from '../data/Projects';
156

7+
const ImageModal = ({
8+
onClick,
9+
project,
10+
}: {
11+
onClick: () => void;
12+
project: ProjectType;
13+
}) => {
1614
return (
1715
<>
1816
<div className="fixed inset-0 h-screen w-screen bg-black/50 backdrop-blur-[2px]" />
19-
<div className="fixed left-1/2 top-1/2 z-10 w-2/5 -translate-x-1/2 -translate-y-1/2 rounded-lg bg-white p-6 dark:bg-dark-500">
17+
<div className="fixed left-1/2 top-1/2 z-10 w-[90%] -translate-x-1/2 -translate-y-1/2 rounded-lg bg-white px-2 py-6 dark:bg-dark-500 md:w-4/5 md:px-4 lg:w-2/5">
2018
<div className="relative grid grid-cols-1 gap-4">
2119
<FontAwesomeIcon
2220
icon={faClose}
23-
className="absolute -right-9 -top-9 h-6 w-6 cursor-pointer rounded-full bg-dark-900 p-1 text-white dark:bg-white dark:text-dark-900"
21+
className="absolute -right-6 -top-9 h-8 w-8 cursor-pointer rounded-full bg-dark-900 p-1 text-white dark:bg-white dark:text-dark-900 md:-right-8"
2422
onClick={onClick}
2523
/>
24+
<h2 className="border-b p-2 font-serif text-xl font-bold">
25+
{project.title}
26+
</h2>
2627
<img
27-
src={imgURL}
28-
alt={imgAlt}
28+
src={project.image}
29+
alt={project.title}
2930
className="h-full max-w-full rounded-lg object-cover"
3031
/>
3132
<div className="grid grid-cols-2 gap-5">
3233
<a
33-
href={liveURL}
34+
href={project.url}
3435
target="_blank"
3536
rel="noopener noreferrer"
3637
className="flex items-center justify-center gap-2 rounded-md bg-blue-600 py-2 text-sm font-medium text-white transition-colors duration-300 ease-in-out hover:bg-blue-400"
@@ -39,7 +40,7 @@ const ImageModal = (props: PropsType) => {
3940
<span>See Live</span>
4041
</a>
4142
<a
42-
href={repoURL}
43+
href={project.repo}
4344
target="_blank"
4445
rel="noopener noreferrer"
4546
className="flex items-center justify-center gap-2 rounded-md bg-dark-900 py-2 text-sm font-medium text-white transition-colors duration-300 ease-in-out hover:bg-dark-700"

src/components/ProjectCard.tsx

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -30,15 +30,7 @@ const ProjectCard = ({ project }: { project: ProjectType }) => {
3030
alt={project.title}
3131
className="h-full max-w-full object-cover"
3232
/>
33-
{openModal && (
34-
<ImageModal
35-
onClick={handelClose}
36-
imgAlt={project.title}
37-
imgURL={project.image}
38-
liveURL={project.url}
39-
repoURL={project.repo}
40-
/>
41-
)}
33+
{openModal && <ImageModal onClick={handelClose} project={project} />}
4234
</a>
4335
</>
4436

0 commit comments

Comments
 (0)