fix: resolve strict typing issues and parameter extraction bugs

- Fixed all TypeScript strict typing violations (no any, no unknown without guards)
- Enhanced parameter type definitions with proper union types
- Fixed UnifiedCommandGateway parameter override issue with --force flag
- Improved context-curator task_type detection with valid enum values
- Added force execution bypass in request-processor
- Fixed type-safe stderr write override in REPL
- Enhanced EnhancedMatchResult interface with proper parameter typing

All tools now pass validation with strict typing enabled and work correctly
with both CLI and interactive modes.

Author: Oladotun Olatunji

src/cli/index.ts

@@ -212,12 +212,33 @@ async function processOneShot(args: string[]): Promise<void> {
 
     let result;
 
-    if (processingResult.success && (!processingResult.metadata?.requiresConfirmation || forceExecution)) {
-      // High confidence or force flag - execute directly
-      logger.info({ tool: processingResult.selectedTool }, 'Executing tool with force flag or high confidence');
+    // When using --force, bypass UnifiedCommandGateway and use process-request directly for proper parameter extraction
+    if (forceExecution) {
+      // Force flag - use process-request tool directly for better parameter extraction
+      logger.info('Using process-request tool directly with --force flag');
+      const context: ToolExecutionContext = {
+        sessionId,
+        transportType: 'cli',
+        metadata: {
+          startTime: Date.now(),
+          cliVersion: '1.0.0',
+          cliConfig: cliConfig,
+          forceExecution: true
+        }
+      };
+      
+      result = await executeTool(
+        'process-request',
+        { request },
+        openRouterConfig,
+        context
+      );
+    } else if (processingResult.success && !processingResult.metadata?.requiresConfirmation) {
+      // High confidence - execute directly using UnifiedCommandGateway
+      logger.info({ tool: processingResult.selectedTool }, 'Executing tool with high confidence');
       const executionResult = await unifiedGateway.executeUnifiedCommand(request, unifiedContext);
       result = executionResult.result;
-    } else if (processingResult.success && processingResult.metadata?.requiresConfirmation && !forceExecution) {
+    } else if (processingResult.success && processingResult.metadata?.requiresConfirmation) {
       // Requires confirmation and no force flag - display processing result for user review
       result = {
         content: [{

src/cli/interactive/repl.ts

@@ -8,6 +8,7 @@ import chalk from 'chalk';
 import { OpenRouterConfig } from '../../types/workflow.js';
 import { executeTool } from '../../services/routing/toolRegistry.js';
 import { ToolExecutionContext } from '../../services/routing/toolRegistry.js';
+import { CallToolResult } from '@modelcontextprotocol/sdk/types.js';
 import { getBanner, getSessionStartMessage, getPrompt } from './ui/banner.js';
 import { progress } from './ui/progress.js';
 import { ResponseFormatter } from './ui/formatter.js';
@@ -73,16 +74,21 @@ export class VibeInteractiveREPL {
     // Override stderr.write to filter out JSON log entries while preserving normal output
     // This ensures clean interactive experience while maintaining full file logging
     const originalStderrWrite = process.stderr.write.bind(process.stderr);
-    process.stderr.write = function(chunk: any, ...args: any[]): boolean {
+    // Type-safe stderr write override
+    type WriteCallback = (error?: Error | null) => void;
+    type WriteArgs = [encoding?: BufferEncoding, callback?: WriteCallback] | [callback?: WriteCallback];
+    
+    process.stderr.write = function(chunk: string | Buffer | Uint8Array, ...args: WriteArgs): boolean {
       const str = chunk?.toString() || '';
       // Filter out JSON log entries (they start with {" and contain "level":)
       if (str.startsWith('{"level":') && str.includes('"pid":') && str.includes('"hostname":')) {
         // Silently drop JSON log entries
         return true;
       }
       // Allow all other output (prompts, responses, etc.)
-      return originalStderrWrite(chunk, ...args);
-    } as any;
+      // Cast to the original function's parameters safely
+      return originalStderrWrite.apply(process.stderr, [chunk, ...args] as Parameters<typeof originalStderrWrite>);
+    } as typeof process.stderr.write;
     // Note: File logging continues at info level to capture all activity in vibe-session.log
 
     // Initialize configuration manager
@@ -1081,8 +1087,9 @@ export class VibeInteractiveREPL {
       logger.info('Waiting for confirmation via existing handler');
 
       // CRITICAL: Resume the stream to ensure readline continues listening
-      if ((this.rl as any).input && typeof (this.rl as any).input.resume === 'function') {
-        (this.rl as any).input.resume();
+      const rlWithInput = this.rl as readline.Interface & { input?: NodeJS.ReadableStream };
+      if (rlWithInput.input && typeof rlWithInput.input.resume === 'function') {
+        rlWithInput.input.resume();
       }
 
       // Show prompt to keep readline active
@@ -1111,8 +1118,9 @@ export class VibeInteractiveREPL {
     // Ensure readline is active and listening
     if (this.rl && this.isRunning) {
       // Resume the input stream if it was paused
-      if ((this.rl as any).input && typeof (this.rl as any).input.resume === 'function') {
-        (this.rl as any).input.resume();
+      const rlWithInput = this.rl as readline.Interface & { input?: NodeJS.ReadableStream };
+      if (rlWithInput.input && typeof rlWithInput.input.resume === 'function') {
+        rlWithInput.input.resume();
       }
 
       // Clear the line and show a fresh prompt
@@ -1157,8 +1165,9 @@ export class VibeInteractiveREPL {
       }
 
       // Also check for jobStatus field if present
-      if ((result as any).jobStatus) {
-        responseText += `\nJob Status: ${(result as any).jobStatus.status}`;
+      const resultWithJobStatus = result as CallToolResult & { jobStatus?: { status: string } };
+      if (resultWithJobStatus.jobStatus) {
+        responseText += `\nJob Status: ${resultWithJobStatus.jobStatus.status}`;
       }
 
       return responseText.trim() || null;

src/services/hybrid-matcher/index.ts

@@ -1,5 +1,5 @@
 // Reconnecting pattern matching for improved NLP accuracy
-import { matchRequest, extractParameters } from "../matching-service/index.js";
+import { matchRequest } from "../matching-service/index.js";
 import { MatchResult } from "../../types/tools.js";
 import { processWithSequentialThinking } from "../../tools/sequential-thinking.js";
 import { OpenRouterConfig } from "../../types/workflow.js";
@@ -14,7 +14,7 @@ const __filename = fileURLToPath(import.meta.url);
 const __dirname = path.dirname(__filename);
 
 // Confidence thresholds
-const HIGH_CONFIDENCE = 0.8;
+// const HIGH_CONFIDENCE = 0.8; // Currently unused but may be needed for future confidence checks
 // const MEDIUM_CONFIDENCE = 0.6; // Removed unused variable
 // const LOW_CONFIDENCE = 0.4; // Removed unused variable
 
@@ -25,7 +25,7 @@ let toolDescriptionsCache: Record<string, string> | null = null;
  * Hybrid matching result with additional metadata
  */
 export interface EnhancedMatchResult extends MatchResult {
-  parameters: Record<string, string>;
+  parameters: Record<string, unknown>;
   matchMethod: "rule" | "intent" | "semantic" | "sequential"; // Added "semantic"
   requiresConfirmation: boolean;
 }
@@ -44,9 +44,14 @@ function loadToolDescriptions(): Record<string, string> {
     const configContent = readFileSync(configPath, 'utf-8');
     const config = JSON.parse(configContent);
 
+    interface ToolConfig {
+      description?: string;
+      [key: string]: unknown;
+    }
+    
     const descriptions: Record<string, string> = {};
     for (const [name, tool] of Object.entries(config.tools)) {
-      const toolData = tool as any;
+      const toolData = tool as ToolConfig;
       descriptions[name] = toolData.description || '';
     }
 
@@ -267,7 +272,8 @@ function combineResults(
   }
 
   // Extract parameters based on the tool
-  let parameters: Record<string, any> = {};
+  // Using 'unknown' for parameters as they vary by tool and will be validated by each tool's schema
+  let parameters: Record<string, unknown> = {};
 
   // For research-manager: requires 'query'
   if (bestTool === 'research-manager') {
@@ -343,7 +349,7 @@ function combineResults(
     parameters = { 
       productDescription,
       userStories: '', // Optional
-      ruleCategories: [] // Optional array
+      ruleCategories: [] as string[] // Optional array
     };
   }
   // For context curator: requires 'prompt' or 'task_type'
@@ -357,9 +363,21 @@ function combineResults(
       prompt = request;
     }
 
+    // Detect task type based on keywords in the request
+    let task_type: string = 'auto_detect'; // Default to auto_detect
+    if (request.match(/\b(bug|fix|error|issue|problem)\b/i)) {
+      task_type = 'bug_fix';
+    } else if (request.match(/\b(refactor|clean|improve|restructure)\b/i)) {
+      task_type = 'refactoring';
+    } else if (request.match(/\b(performance|optimize|speed|faster)\b/i)) {
+      task_type = 'performance_optimization';
+    } else if (request.match(/\b(feature|add|implement|create|new)\b/i)) {
+      task_type = 'feature_addition';
+    }
+    
     parameters = { 
       prompt,
-      task_type: 'general' // Default task type
+      task_type
     };
   }
   // For fullstack starter kit generator: requires 'use_case'
@@ -378,7 +396,7 @@ function combineResults(
   // For map-codebase: optional 'directory' parameter
   else if (bestTool === 'map-codebase') {
     // Check if a specific directory is mentioned
-    const dirMatch = request.match(/(?:for|in|of|at)\s+([\/\w\-\.]+)/i);
+    const dirMatch = request.match(/(?:for|in|of|at)\s+([\w\-./]+)/i);
     if (dirMatch) {
       parameters = { directory: dirMatch[1] };
     } else {
@@ -405,7 +423,7 @@ function combineResults(
     if (workflowMatch) {
       parameters = { 
         workflowName: workflowMatch[1],
-        workflowInput: {} // Empty object as default
+        workflowInput: {} as Record<string, unknown> // Empty object as default
       };
     } else {
       // If no specific workflow mentioned, look for "run workflow" pattern
@@ -415,13 +433,13 @@ function combineResults(
         const nameMatch = request.match(/\b([a-zA-Z0-9-_]+)\b/);
         parameters = {
           workflowName: nameMatch ? nameMatch[1] : 'default',
-          workflowInput: {}
+          workflowInput: {} as Record<string, unknown>
         };
       } else {
         // Fallback - use the full request
         parameters = {
           workflowName: 'default',
-          workflowInput: { request }
+          workflowInput: { request } as Record<string, unknown>
         };
       }
     }

src/services/request-processor/index.ts

@@ -46,8 +46,9 @@ export const processUserRequest: ToolExecutor = async (
     // Step 1: Use the hybrid matcher to determine the appropriate tool
     matchResult = await hybridMatch(request, config);
 
-    // Step 2: Check if confirmation is needed
-    if (matchResult.requiresConfirmation) {
+    // Step 2: Check if confirmation is needed (unless force flag is set)
+    const forceExecution = (context?.metadata as { forceExecution?: boolean })?.forceExecution === true;
+    if (matchResult.requiresConfirmation && !forceExecution) {
       logger.info(`Tool execution requires confirmation: ${matchResult.toolName}`);
       const explanation = getMatchExplanation(matchResult);
       return {