Merge pull request #20 from Veskor/tests/roles

tests for roles

Author: mekanix

freenit/api/role.py

@@ -74,18 +74,21 @@ def post(self, args, role_id):
         """Assign user to role"""
         Role = current_app.user_datastore.role_model
         User = current_app.user_datastore.user_model
-        UserRoles = current_app.user_datastore.UserRoles
+        UserRoles = current_app.user_datastore.UserRole
         try:
             role = Role.get(id=role_id)
         except Role.DoesNotExist:
             abort(404, message='No such role')
+
+        for user in role.users:
+            if user.user.id == args['id']:
+                abort(409, message='User already assigned to role')
+
         try:
             user = User.get(id=args['id'])
         except User.DoesNotExist:
             abort(404, message='No such user')
-        for user in role.users:
-            if user.user.id == args['id']:
-                abort(409, message='User already assigned to role')
+
         user_role = UserRoles(user=user, role=role)
         user_role.save()
         return user

tests/base.py

@@ -59,7 +59,7 @@ def patch(self, endpoint, data, csrf=None, **kwargs):
     def delete(self, endpoint, csrf=None, **kwargs):
         url = url_for(endpoint, **kwargs)
         self.set_csrf(csrf)
-        return self.client.patch(url, headers=self.headers)
+        return self.client.delete(url, headers=self.headers)
 
     def login(self, endpoint, user, password):
         data = {

tests/test_role.py

@@ -0,0 +1,88 @@
+from .base import Base
+
+
+class TestRole(Base):
+    def test_get_all(self, user_factory):
+        user = user_factory()
+        user.save()
+        response = self.login('auth.login', user, 'Sekrit')
+        assert response.status_code == 200
+        response = self.get('roles.list')
+        assert response.status_code == 200
+
+    def test_post(self, user_factory, role_factory):
+        user = user_factory()
+        role = role_factory()
+        role.save()
+        user.save()
+        response = self.login('auth.login', user, 'Sekrit')
+        assert response.status_code == 200
+
+        data = {
+            'description': 'Admin role.',
+            'name': 'Admin',
+        }
+
+        response = self.post('roles.list', data, 'access')
+        assert response.status_code == 200
+        json_data = response.get_json()
+        assert data['name'] == json_data['name']
+        newrole = role.get(id=json_data['id'])
+        assert newrole.description == data['description']
+
+    def test_get(self, user_factory, role_factory):
+        user = user_factory()
+        role = role_factory()
+        user.save()
+        role.save()
+        response = self.login('auth.login', user, 'Sekrit')
+        assert response.status_code == 200
+        response = self.get('roles.detail', role_id=role.id)
+        assert response.status_code == 200
+
+    def test_patch(self, user_factory, role_factory):
+        user = user_factory()
+        role = role_factory()
+        user.save()
+        role.save()
+        response = self.login('auth.login', user, 'Sekrit')
+        assert response.status_code == 200
+        data = {
+            'description': 'Admin role',
+        }
+        response = self.patch('roles.detail', data, 'access', role_id=role.id)
+        assert response.status_code == 200
+        role = role.get(id=role.id)
+        assert role.description == data['description']
+
+    def test_delete(self, user_factory, role_factory):
+        user = user_factory()
+        user.save()
+        response = self.login('auth.login', user, 'Sekrit')
+        assert response.status_code == 200
+        newrole = role_factory()
+        newrole.save()
+        response = self.delete('roles.detail', 'access', role_id=newrole.id)
+        assert response.status_code == 200
+
+    def test_assign_deassign_role(self, user_factory, role_factory):
+        user = user_factory()
+        role = role_factory()
+        user.save()
+        role.save()
+        response = self.login('auth.login', user, 'Sekrit')
+        assert response.status_code == 200
+        user = user_factory()
+        user.save()
+        data = {
+            "id": user.id
+        }
+        response = self.post('roles.user_assign',
+                             data, 'access',
+                             role_id=role.id)
+        assert response.status_code == 200
+        response = self.delete('roles.user_deassign',
+                               'access',
+                               user_id=user.id,
+                               role_id=role.id)
+        assert response.status_code == 200