-
Notifications
You must be signed in to change notification settings - Fork 6
Open
Labels
Description
As explained here
webcat/extension/src/webcat/response.ts
Lines 252 to 255 in d1475b3
// TODO (perfomance): significant amount of time is spent calling this function | |
// at every loadef ile, without added benefit. It should be enough to call it if | |
// details.type == "main_frame", but then the icon change does not work... | |
setOKIcon(details.tabId); |
It would be enough the set the OK icon when the main_frame
as loaded, and leave it to change only in case of fault. Instead, we are currently setting again the OK icon at every successful resource load: a significant overhead, even though is non-blocking. Calling setOKIcon()
only when details.type === "main_frame"
is the reasonable solution, however when implemented the function gets called, but the icon gos from activated back to deactivated, instead of activated and green.