Skip to content

Call setOKIcon only when loading main_frame #38

@lsd-cat

Description

@lsd-cat

As explained here

// TODO (perfomance): significant amount of time is spent calling this function
// at every loadef ile, without added benefit. It should be enough to call it if
// details.type == "main_frame", but then the icon change does not work...
setOKIcon(details.tabId);

It would be enough the set the OK icon when the main_frame as loaded, and leave it to change only in case of fault. Instead, we are currently setting again the OK icon at every successful resource load: a significant overhead, even though is non-blocking. Calling setOKIcon() only when details.type === "main_frame" is the reasonable solution, however when implemented the function gets called, but the icon gos from activated back to deactivated, instead of activated and green.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions