poudriere-logclean(8) option -y

[grahamperrin]

With option -y, confirmation was sought. Is this a bug?

root@mowa219-gjp4-zbook-freebsd:~ # poudriere logclean 1 -j main -y
[00:00:00] Grabging logclean lock... done
[00:00:00] Looking for builds older than 1 days in /usr/local/poudriere/data/logs/bulk (filtered)... done
[00:00:01] Acquiring latest-per-pkg lock... done
[00:00:01] Acquiring build logs lock... main-default done
[00:00:01] Calculating size for found files... done
[00:00:02] These builds older than 1 days in /usr/local/poudriere/data/logs/bulk (filtered) will be deleted:
main-default/2024-08-28_20h30m33s
…
main-default/2024-11-05_00h34m42s
[00:00:02] Removing these 121 builds older than 1 days in /usr/local/poudriere/data/logs/bulk (filtered) will free: 308.54 MiB
[00:00:02] Proceed? [y/N] y
[00:00:21] Removing files... done
[00:00:22] Looking for detached latest-per-pkg logfiles in /usr/local/poudriere/data/logs/bulk (no filter)... done
[00:00:22] Calculating size for found files... done
[00:00:22] These detached latest-per-pkg logfiles in /usr/local/poudriere/data/logs/bulk (no filter) will be deleted:
latest-per-pkg/tiff/4.7.0/main-default.log
…
main-default/latest-per-pkg/rust-cbindgen-0.26.0_9.log
[00:00:22] Removing these 1580 detached latest-per-pkg logfiles in /usr/local/poudriere/data/logs/bulk (no filter) will free: 50.77 MiB
[00:00:22] Proceed? [y/N] y
[00:00:30] Removing files... done
[00:00:30] Removing broken legacy latest-per-pkg symlinks (no filter)... done
[00:00:30] Removing empty latest-per-pkg directories (no filter)... done
[00:00:30] Fixing latest symlinks...main-default... done
[00:00:30] Fixing latest-done symlinks...main-default... done
[00:00:30] Updating latest-per-pkg links... main-default... done
[00:00:30] Removing empty build log directories... done
[00:00:30] Rebuilding HTML JSON files...
[00:00:30] Rebuilding HTML JSON for top-level... done
root@mowa219-gjp4-zbook-freebsd:~ # 

poudriere logclean 1 -j main -y.txt

https://man.freebsd.org/cgi/man.cgi?query=poudriere-logclean&sektion=8&manpath=freebsd-ports

[bdrewery]

The problem is the syntax for getopts does not support logclean 1 -j main -y. The 1 short-circuits everything after.

Issue #1212 covers this and fixes the argument validation to throw an error in this case.