fix: conditional string equivalence (#139)

* fix: conditional string equivalence

* fix: typoes

Author: ojeytonwilliams

python/py_helpers.py

@@ -130,7 +130,16 @@ def is_equivalent(self, target_str):
         # equivalent to any string.
         if self.tree == None:
             return False
-        return ast.unparse(self.tree) == ast.unparse(ast.parse(target_str))
+        code_str = ast.unparse(self.tree)
+
+        # Why parse and unparse again? Because of an edge case when comparing
+        # the `target_str` "'True'" with the test in "if 'True':". These should
+        # be equivalent, but the condition unparses to "'True'", while the
+        # `target_str` becomes '"""True"""' when parsed and unparsed again.
+
+        # By parsing and unparsing `code_str` we get '"""True"""' and the
+        # comparison returns True as expected.
+        return ast.unparse(ast.parse(code_str)) == ast.unparse(ast.parse(target_str))
 
     # Finds the class definition with the given name
 

python/py_helpers.test.py

@@ -329,6 +329,17 @@ def test_whitespace_equivalence(self):
             Node(str_with_whitespace).is_equivalent(str_with_different_whitespace)
         )
 
+    def test_string_equivalence(self):
+        self.assertTrue(Node("'True'").is_equivalent('"""True"""'))
+
+    def test_string_cond_equivalence(self):
+        self.assertTrue(
+            Node("if 'True':\n  pass")
+            .find_ifs()[0]
+            .find_conditions()[0]
+            .is_equivalent("'True'")
+        )
+
 
 class TestConditionalHelpers(unittest.TestCase):
     def test_find_if_statements(self):