Skip to content

add regex whitelist to no-arbitrary-values #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ginasummation
Copy link

@ginasummation ginasummation commented Apr 14, 2025

Pull Request Name

Add a whitelist for no-arbitrary-values rule

Description

I'm using the no-arbitrary-values rule to enforce team consistency with a design system. Our design system is not opinionated on a subset of tailwind classes though (mostly height and width related) so I would like to whitelist those sort of classes to allow for arbitrary values. See similar asks from these two issues

#286
#247

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

I added a unit test with various whitelist options to make sure the change works. I also made sure the regex would allow users to specify the content within the arbitrary values. I,e whitelisting 'text-[12px]' but disallowing 'text-[#ffffff]'

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@asamasoma
Copy link

👍 to this please!

@tavivibrazowski
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants