Skip to content

"no implicit conversion of URI::HTTPS into String" exception after upgrading to 1.12.0 #280

@lauratpa

Description

@lauratpa

After upgrading to 1.12.0 our code started to fail with:

TypeError: Failed to open TCP connection to https://fonts.googleapis.com/css?family=Open+Sans:400,700:80 (no implicit conversion of URI::HTTPS into String)
File /usr/local/lib/ruby/2.7.0/net/http.rb:960 in initialize
File /usr/local/lib/ruby/2.7.0/net/http.rb:960 in open
File /usr/local/lib/ruby/2.7.0/net/http.rb:960 in block in connect
File /usr/local/bundle/gems/timeout-0.3.1/lib/timeout.rb:189 in block in timeout
File /usr/local/bundle/gems/timeout-0.3.1/lib/timeout.rb:196 in timeout
File /usr/local/lib/ruby/2.7.0/net/http.rb:958 in connect
File /usr/local/lib/ruby/2.7.0/net/http.rb:943 in do_start
File /usr/local/lib/ruby/2.7.0/net/http.rb:932 in start
File /usr/local/lib/ruby/2.7.0/net/http.rb:476 in get_response
File /usr/local/lib/ruby/2.7.0/net/http.rb:458 in get
File /usr/local/bundle/gems/premailer-rails-1.12.0/lib/premailer/rails/css_loaders/network_loader.rb:9 in load
File /usr/local/bundle/gems/premailer-rails-1.12.0/lib/premailer/rails/css_helper.rb:47 in block in load_css

We are using ruby 2.7, so it seems that this change https://github.com/fphilipe/premailer-rails/pull/261/files
now triggers the exception, since Net::HTTP for ruby 2.7 does not support headers.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions