Skip to content

bug(forge bind): does not set serde as dependency when using serde derives #10359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 tasks done
Brando753 opened this issue Apr 24, 2025 · 0 comments
Open
2 tasks done
Labels
Cmd-forge-bind Command: forge bind T-bug Type: bug T-to-investigate Type: to investigate T-to-reproduce Type: requires reproduction

Comments

@Brando753
Copy link

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

Commit SHA: e988893

What version of Foundryup are you on?

foundryup: 1.0.1

What command(s) is the bug in?

forge bind --alloy-version 0.13.0

Operating System

Linux

Describe the bug

I wanted to have serializable rust bindings, so I ran the latest nightly version but noticed that the bindings generated wouldn't compile without manually adding serde as a dependency to the Cargo.toml file of the generated crate. The issue #10317, along with the associated PR #10332 added serializable/deserializable derive traits to all types; however, it does not add the dependency to the Cargo file if the bindings are being built with serde derives. The cargo file should have something like this added automatically:

serde = { version = "1.0.219", features = ["derive"] }

Otherwise, you have to modify the generated crate manually after every run to get it to build.

@Brando753 Brando753 added T-bug Type: bug T-needs-triage Type: this issue needs to be labelled labels Apr 24, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Foundry Apr 24, 2025
@zerosnacks zerosnacks changed the title Forge Bind does not set Serde as dependency when using serde derives bug(forge bind): does not set serde as dependency when using serde derives May 1, 2025
@zerosnacks zerosnacks added Cmd-forge-bind Command: forge bind T-to-reproduce Type: requires reproduction T-to-investigate Type: to investigate and removed T-needs-triage Type: this issue needs to be labelled labels May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cmd-forge-bind Command: forge bind T-bug Type: bug T-to-investigate Type: to investigate T-to-reproduce Type: requires reproduction
Projects
Status: Backlog
Development

No branches or pull requests

2 participants