Skip to content

Commit 87460f0

Browse files
committed
feat(10027-cheatcode-mutability-tags): getNonce_1 is external view
1 parent 6093a2c commit 87460f0

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

crates/cheatcodes/assets/cheatcodes.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

crates/cheatcodes/spec/src/vm.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -372,7 +372,7 @@ interface Vm {
372372

373373
/// Get the nonce of a `Wallet`.
374374
#[cheatcode(group = Evm, safety = Safe)]
375-
function getNonce(Wallet calldata wallet) external returns (uint64 nonce);
375+
function getNonce(Wallet calldata wallet) external view returns (uint64 nonce);
376376

377377
/// Loads a storage slot from an address.
378378
#[cheatcode(group = Evm, safety = Safe)]

docs/dev/cheatcode-mutability-review.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ Mark `view`:
4646
- [x] `getMappingKeyAndParentOf`: `getMappingKeyAndParentOf(address,bytes32)` _suggested: `view`_
4747
- [x] `getMappingLength`: `getMappingLength(address,bytes32)` _suggested: `view`_
4848
- [x] `getMappingSlotAt`: `getMappingSlotAt(address,bytes32,uint256)` _suggested: `view`_
49-
- [ ] `getNonce_1`: `getNonce(address,uint256,uint256,uint256)`
49+
- [x] `getNonce_1`: `getNonce(address,uint256,uint256,uint256)` _suggested: `view`_
5050
- [x] `getRecordedLogs`: `getRecordedLogs()` _suggested: `view`_
5151
- [x] `getWallets`: `getWallets()` _suggested: `view`_
5252
- [x] `noAccessList`: `noAccessList()` _suggested: `view`_

0 commit comments

Comments
 (0)