Skip to content

Commit 0b2923d

Browse files
authored
Merge pull request #16 from fossapps/naming
chore(naming): update naming
2 parents 2d153ef + 706d02f commit 0b2923d

File tree

4 files changed

+15
-16
lines changed

4 files changed

+15
-16
lines changed

Sdk.Test/FeatureClientTest.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
using System;
22
using System.Collections.Generic;
33
using Fossapps.FeatureManager;
4-
using FossApps.FeatureManager.Models;
4+
using Fossapps.FeatureManager.Models;
55
using Moq;
66
using NUnit.Framework;
77

@@ -50,13 +50,13 @@ public void Setup()
5050
var mockWorker = new Mock<IFeatureWorker>();
5151
mockWorker.Setup(x => x.GetRunningFeatures()).Returns(runningFeatures);
5252
var mockUserData = new Mock<IUserDataRepo>();
53-
mockUserData.Setup(x => x.GetExperimentsForcedA()).Returns(new List<string>
53+
mockUserData.Setup(x => x.GetForcedFeaturesA()).Returns(new List<string>
5454
{
5555
"ALL_A-1",
5656
"ALL_A-2",
5757
"ALL_A-3",
5858
});
59-
mockUserData.Setup(x => x.GetExperimentsForcedB()).Returns(new List<string>
59+
mockUserData.Setup(x => x.GetForcedFeaturesB()).Returns(new List<string>
6060
{
6161
"ALL_B-1",
6262
"ALL_B-2",
@@ -141,7 +141,7 @@ public void TestFeatureWithAllBAlwaysReturnsB()
141141
}
142142

143143
[Test]
144-
public void TestFeatureWithOverrideExperimentsToA()
144+
public void TestFeatureWithOverrideFeaturesToA()
145145
{
146146
var dictionary = new Dictionary<char, int> {['A'] = 0, ['B'] = 0, ['X'] = 0, ['Z'] = 0};
147147
var client = new FeatureClient(_featureWorker, _userDataRepo);
@@ -167,7 +167,7 @@ public void TestFeatureWithOverrideExperimentsToA()
167167
}
168168

169169
[Test]
170-
public void TestFeatureWithOverrideExperimentsToB()
170+
public void TestFeatureWithOverrideFeaturesToB()
171171
{
172172
var dictionary = new Dictionary<char, int> {['A'] = 0, ['B'] = 0, ['X'] = 0, ['Z'] = 0};
173173
var client = new FeatureClient(_featureWorker, _userDataRepo);

Sdk/FeatureContainer.cs

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@
44
using System.Security.Cryptography;
55
using System.Text;
66
using System.Threading.Tasks;
7-
using FossApps.FeatureManager;
8-
using FossApps.FeatureManager.Models;
7+
using Fossapps.FeatureManager.Models;
98

109
namespace Fossapps.FeatureManager
1110
{
@@ -18,13 +17,13 @@ public interface IFeatureWorker
1817
public class FeatureWorker : IFeatureWorker
1918
{
2019
private readonly TimeSpan _syncInterval;
21-
private readonly FossApps.FeatureManager.FeatureManager _manager;
20+
private readonly FeatureManager _manager;
2221
private IEnumerable<RunningFeature> _features;
2322

2423
public FeatureWorker(string endpoint, TimeSpan syncInterval)
2524
{
2625
_syncInterval = syncInterval;
27-
_manager = new FossApps.FeatureManager.FeatureManager(new Uri(endpoint));
26+
_manager = new FeatureManager(new Uri(endpoint));
2827
}
2928

3029
public IEnumerable<RunningFeature> GetRunningFeatures()
@@ -77,11 +76,11 @@ private RunningFeature GetFeatureById(string featId)
7776
}
7877
public char GetVariant(string featId)
7978
{
80-
if (_userDataRepo.GetExperimentsForcedB().Any(x => x == featId))
79+
if (_userDataRepo.GetForcedFeaturesB().Any(x => x == featId))
8180
{
8281
return 'B';
8382
}
84-
if (_userDataRepo.GetExperimentsForcedA().Any(x => x == featId))
83+
if (_userDataRepo.GetForcedFeaturesA().Any(x => x == featId))
8584
{
8685
return 'A';
8786
}

Sdk/UserDataRepo.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@ public interface IUserDataRepo
88
{
99
public string GetUserId();
1010

11-
public IEnumerable<string> GetExperimentsForcedA()
11+
public IEnumerable<string> GetForcedFeaturesA()
1212
{
1313
return new List<string>();
1414
}
1515

16-
public IEnumerable<string> GetExperimentsForcedB()
16+
public IEnumerable<string> GetForcedFeaturesB()
1717
{
1818
return new List<string>();
1919
}
@@ -28,7 +28,7 @@ protected UserDataRepoBase(IHttpContextAccessor contextAccessor)
2828
_contextAccessor = contextAccessor;
2929
}
3030

31-
public IEnumerable<string> GetExperimentsForcedA()
31+
public IEnumerable<string> GetForcedFeaturesA()
3232
{
3333
if (!_contextAccessor.HttpContext.Request.Headers.TryGetValue("X-Forced-Features-A", out var features))
3434
{
@@ -38,7 +38,7 @@ public IEnumerable<string> GetExperimentsForcedA()
3838
return features.ToString().Split(",").ToList();
3939
}
4040

41-
public IEnumerable<string> GetExperimentsForcedB()
41+
public IEnumerable<string> GetForcedFeaturesB()
4242
{
4343
if (!_contextAccessor.HttpContext.Request.Headers.TryGetValue("X-Forced-Features-B", out var features))
4444
{

Sdk/generate_sdk.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
#!/usr/bin/env bash
22
mkdir -p Generated
3-
docker run --net=host --rm -v $(pwd)/Generated:/app/sdk node bash -c "apt update && apt install libunwind-dev -y && npm i -g autorest@3.0.6187 && autorest --input-file=http://localhost:5000/swagger/v1/swagger.json --csharp --namespace=FossApps.FeatureManager --override-client-name=FeatureManager --output-folder=/app/sdk --clear-output-folder"
3+
docker run --net=host --rm -v $(pwd)/Generated:/app/sdk node bash -c "apt update && apt install libunwind-dev -y && npm i -g autorest@3.0.6187 && autorest --input-file=http://localhost:5000/swagger/v1/swagger.json --csharp --namespace=Fossapps.FeatureManager --override-client-name=FeatureManager --output-folder=/app/sdk --clear-output-folder"

0 commit comments

Comments
 (0)