Skip to content

Commit 45e6ba2

Browse files
committed
update
1 parent d0e93c4 commit 45e6ba2

File tree

2 files changed

+10
-35
lines changed

2 files changed

+10
-35
lines changed

lambda-api/src/main/java/com/formkiq/stacks/api/handler/ConfigurationRequestHandler.java

Lines changed: 7 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@
3434
import static com.formkiq.stacks.dynamodb.ConfigService.MAX_WEBHOOKS;
3535
import static com.formkiq.stacks.dynamodb.ConfigService.NOTIFICATION_EMAIL;
3636

37-
import java.io.IOException;
38-
import java.io.StringReader;
3937
import java.security.KeyFactory;
4038
import java.security.NoSuchAlgorithmException;
4139
import java.security.PrivateKey;
@@ -47,7 +45,6 @@
4745
import java.util.HashMap;
4846
import java.util.Map;
4947
import java.util.Optional;
50-
import java.util.Properties;
5148

5249
import com.amazonaws.services.lambda.runtime.LambdaLogger;
5350
import com.formkiq.aws.dynamodb.DynamicObject;
@@ -211,9 +208,9 @@ public ApiRequestHandlerResponse patch(final LambdaLogger logger,
211208
if (body.containsKey("docusign")) {
212209

213210
Map<String, String> google = (Map<String, String>) body.get("docusign");
214-
String docusignUserId = google.getOrDefault("userId", "");
215-
String docusignIntegrationKey = google.getOrDefault("integrationKey", "");
216-
String docusignRsaPrivateKey = google.getOrDefault("rsaPrivateKey", "");
211+
String docusignUserId = google.getOrDefault("userId", "").trim();
212+
String docusignIntegrationKey = google.getOrDefault("integrationKey", "").trim();
213+
String docusignRsaPrivateKey = google.getOrDefault("rsaPrivateKey", "").trim();
217214

218215
map.put(KEY_DOCUSIGN_USER_ID, docusignUserId);
219216
map.put(KEY_DOCUSIGN_INTEGRATION_KEY, docusignIntegrationKey);
@@ -304,9 +301,10 @@ private void validateDocusign(final Map<String, Object> map,
304301
private boolean isValidRsaPrivateKey(final String privateKeyPem) {
305302
try {
306303
// Remove the PEM header and footer
307-
String privateKeyPemStripped = decodeUnicode(privateKeyPem)
308-
.replace("-----BEGIN RSA PRIVATE KEY-----", "")
309-
.replace("-----END RSA PRIVATE KEY-----", "").replace("\\n", "").replaceAll("\\s+", "");
304+
String privateKeyPemStripped =
305+
privateKeyPem.replace("\\u003d", "=").replace("-----BEGIN RSA PRIVATE KEY-----", "")
306+
.replace("-----END RSA PRIVATE KEY-----", "").replace("\\n", "")
307+
.replaceAll("\\s+", "").trim();
310308

311309
byte[] privateKeyBytes = Base64.getDecoder().decode(privateKeyPemStripped);
312310

@@ -320,26 +318,4 @@ private boolean isValidRsaPrivateKey(final String privateKeyPem) {
320318
return false;
321319
}
322320
}
323-
324-
/**
325-
* Decode Unicode sequences.
326-
*
327-
* @param input {@link String}
328-
* @return String
329-
*/
330-
private String decodeUnicode(final String input) {
331-
332-
String result = input;
333-
if (input != null) {
334-
Properties properties = new Properties();
335-
try {
336-
properties.load(new StringReader("key=" + input));
337-
result = properties.getProperty("key");
338-
} catch (IOException e) {
339-
// ignore
340-
}
341-
}
342-
343-
return result;
344-
}
345321
}

lambda-api/src/test/java/com/formkiq/stacks/api/handler/ConfigurationRequestTest.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ public class ConfigurationRequestTest extends AbstractApiClientRequestTest {
8181
9i7pWanM1abM4es/tdATp56uTWntoa2ZQTHieFtSkYlufDbgLaCIb4HCStimbzye
8282
xm4Xo6+jDbifGOqFT4Ofeyc=
8383
-----END RSA PRIVATE KEY-----
84-
""";
84+
\s""";
8585

8686
/**
8787
* Before Each.
@@ -362,9 +362,8 @@ public void testHandlePutConfiguration06() throws ApiException {
362362
assertEquals("123", configuration.getDocusign().getUserId());
363363
assertEquals("""
364364
-----BEGIN RSA PRIVATE KEY-----
365-
MIIEvQIB*******FT4Ofeyc=
366-
-----END RSA PRIVATE KEY-----
367-
""", configuration.getDocusign().getRsaPrivateKey());
365+
MIIEvQIB*******qFT4Ofeyc=
366+
-----END RSA PRIVATE KEY-----""", configuration.getDocusign().getRsaPrivateKey());
368367
}
369368

370369
/**

0 commit comments

Comments
 (0)