StandardApexLibrary files include invalid Apex

[aheber]

Summary

I'm trying to work with the Apex files added to my project by the Apex Language Server and associated VSCode extension. Some of these files include patterns that are not valid Apex.

Specifically I'm finding that nested classes have constructor names that include the outer class as a namespace for the constructor.

For example: in .sfdx/tools/252/StandardApexLibrary/Database/DMLOptions.cls I see lines such as

global DMLOptions.AssignmentRuleHeader() { }

which, to be considered valid Apex, should be

global AssignmentRuleHeader() { }

Additional information

It appears the Jorje parser is able to process this format but if I build a class and try and deploy it to Salesforce it is rejected with Invalid constructor name: OUTER_CLASS.INNER_CLASS.

Salesforce Extension Version in VS Code: 62.14.1

Salesforce CLI Version: @salesforce/cli/2.76.7 darwin-arm64 node-v22.13.1

OS and version: MacOS 15.3

VS Code version: 1.96.2

Most recent version of the extensions where this was working: never

[svc-idee-bot]

Thank you for filing this issue. We appreciate your feedback and will review the issue as soon as possible. Remember, however, that GitHub isn't a mechanism for receiving support under any agreement or SLA. If you require immediate assistance, contact Salesforce Customer Support.

[svc-idee-bot]

Hello @aheber 👋 It looks like you didn't provide all the required basic info in your issue.

If you haven't already, please provide the following info:
Salesforce Extension Version in VS Code:
Salesforce CLI Version:
OS and version:
VS Code version:
Most recent version of the extensions where this was working:

Here's an example of a set of required info that will pass the validation:
Salesforce Extension Version in VS Code: 60.13.0
Salesforce CLI Version: @salesforce/cli/2.42.6 darwin-arm64 node-v18.18.2
OS and version: MacOS Sonoma 14.5
VS Code version: 1.89.1
Most recent version of the extensions where this was working: 60.11.0

A few more things to check:

• Make sure you've provided detailed steps to reproduce your issue, as well as all error messages that you see.
  • A repository that clearly demonstrates the bug is ideal.
  • Error messages can be found in the Problems Tab, Output Tab, and from running Developer: Toggle Developer Tools in the command palette.
• Make sure you've installed the latest version of the Salesforce Extension Pack for VSCode. (docs)
• Search GitHub for existing related issues.

Thank you!

[peternhale]

Hi @aheber , I hope all is well. Can you provide a reproducer for this?

[aheber]

@peternhale, doing great over here!

I'm not sure the best way to provide a reproducer. If you look in any Salesforce project where VSCode has been opened it should have populated the .sfdx/tools/252/StandardApexLibrary/Database/DMLOptions.cls file. I believe this is done by the Apex Lang Server but it could be something else. I believe you have to have the Apex extension enabled for this to occur.

The contents of that file on my machine are

global class DMLOptions {
	global Boolean AllowFieldTruncation;
	global Database.DMLOptions.AssignmentRuleHeader AssignmentRuleHeader;
	global Database.DMLOptions.DuplicateRuleHeader DuplicateRuleHeader;
	global Database.DMLOptions.EmailHeader EmailHeader;
	global String LocaleOptions;
	global Boolean LocalizeErrors;
	global Boolean OptAllOrNone;
	global DMLOptions() { }
	global Object clone() { }
global class AssignmentRuleHeader {
	global String AssignmentRuleId;
	global Boolean UseDefaultRule;
	global DMLOptions.AssignmentRuleHeader() { }
	global Object clone() { }

}
global class DuplicateRuleHeader {
	global Boolean AllowSave;
	global Boolean RunAsCurrentUser;
	global DMLOptions.DuplicateRuleHeader() { }
	global Object clone() { }

}
global class EmailHeader {
	global Boolean TriggerAutoResponseEmail;
	global Boolean TriggerOtherEmail;
	global Boolean TriggerUserEmail;
	global DMLOptions.EmailHeader() { }
	global Object clone() { }

}

}

These lines demonstrate the problem:

	global DMLOptions.AssignmentRuleHeader() { }
	global DMLOptions.DuplicateRuleHeader() { }
	global DMLOptions.EmailHeader() { }

Having DMLOptions. is a prefix.

Many months ago when you were looking at tree-sitter-sfapex you found there were files in this directory where that parser would throw an error, we dug into it and found these types of constructors. I'm only now opening the issue as I ran into the problem again.

[aheber]

I'm trying to go through my notes and maybe I'm imagining that we found this issue together. I might have found it independently after trying to reproduce some of your results. Either way, I have it narrowed down now.

I'm not sure what process generates these files, in my mind I think I assumed they were pre-built and delivered as part of the extension or language server then simply "printed" out to the file system.

[peternhale]

@aheber the classes in that area of the workspace are incomplete and are indeed placed there by the language server. The purpose of these are to provide hover support and a place to land when doing goto definition.

I can raise an internal issue on these syntax issues within these files.

[git2gus]

This issue has been linked to a new work item: W-17829702