[picker.grep]: Snacks.picker.grep uses a lot of memory in a large code repository.

[ycycyyc]

After running Snacks.picker.grep({search="a"}) in a large repo, memory increase.
And then close the grep picker, memory has not decreased.

Is this expected behavior? Will it affect performance?
And in the following configuration，memory has not decreased after running the grep command several times.

picker = {
    debug = {
        leaks = true
}}

And I got this message:

` 1 ` active pickers.

[folke]

I just pushed some updates to clear items when a picker hasn't yet been garbage collected, so on second run, those items should not longer use any memory.

I've also added more info to leak debugging.

When testing, the snacks picker used about half the memory as Telescope for the same query.

Fzf-Lua will of course use less memory in Neovim since the actual grepping is done through fzf.

In large repos, you can also configure limit=10000 for example, for grep and files.
For live searches, a limit doesn't really matter and you can still filter down the list.

[folke]

Added this, but from my testing at least this was not an issue.
When a task is aborted, all its resources, including queue gets garbage collected.

I did make some other changes that might impact this, but hard to tell.

[ycycyyc]

thanks, here is my steps to reproduce if you are intertered.

1. git clone https://github.com/golang/go

2. cd go

3. nvim -u repo.lua

4. run lua Snacks.picker.grep({search="a", limit=10}) Run again and again.

5. and you will get:
   

6. run lua Snacks.picker.grep({search="go is an open source programming", limit=10}) , this task will not leak memory

repo.lua:

vim.env.LAZY_STDPATH = ".repro"
load(vim.fn.system("curl -s https://raw.githubusercontent.com/folke/lazy.nvim/main/bootstrap.lua"))()

require("lazy.minit").repro({
        spec = {
                {
                        "folke/snacks.nvim",
                        opts = {
                                picker= {
                                        debug = {
                                                leaks = true,
                                        },
                                },
                        },
                },
        },
})

vim.keymap.set("n", "<leader>f", function()
        vim.ui.input({ prompt = "test" }, function(input)
                if input == nil then
                        vim.print("cancel")
                else
                        vim.print("input:" .. input)
                end
        end)
end)

neovim version info

NVIM v0.10.4-dev-6+g6a6c6b2658                                                                                                                                                                                                                           
Build type: Release                                                                                                                                                                                                                                      
LuaJIT 2.1.1713484068  

[ycycyyc]

Add some log info in proc.lua, and I found task which leaks memory does not print this.
Does this mean the async task or coroutine is not finished?

[folke]

This should be fixed now.
There was an issue in my Async class where aborting a coroutine from inside the actual coroutine,
wasn't handled properly and that coroutine would not be closed.

Was only an issue with that limit=.

[ycycyyc]

Thanks! It works well now.