[Picker] no lsp_definitions

[anotherfrontendguy]

Hey ✌️

thanks for the Picker, I love it and appreciate the effort that went into it!

It works great out of the box for me, however there's one thing I can't figure out.

Before enabling the Snacks Picker via LazyExtras I was able to use gd to goto definition in my PHP projects (using phpactor as LSP provider).

After enabling the Picker and pressing gd I get this:

Which is weird because when I call :lua vim.lsp.buf.definition() manually I takes me directly to the correct definition. Any idea what's going on here?

I hope this is the right place to ask, thanks again for all your work.

[folke]

I don't use php. Can you tell me the steps on which extras to enable (if any), lsp servers to install through mason.
And one or two files to trigger lsp definition?

[anotherfrontendguy]

Oh yes sure, I should have provided files in the first place - sorry.

Just to make sure I used a fresh install of LazyVim and did these steps:

• enable editor.snacks_picker via LazyExtras (I did not enable any other extras)
• install phpactor as LSP server (via Mason)

Here are two files for testing:

// file one.php
<?php

namespace App;

class One
{
    public function __construct()
    {
        echo 'one';
    }
}

// file two.php
<?php

namespace App;

class Two
{
    public function __construct()
    {
        new One;    // <-- pressing gd with your cursor on One should jump into file one.php
        echo 'two';
    }
}

In order for phpactor to detect a valid root dir I created the following structure for my test:

test/
├─ one.php
├─ two.php

Sitenote: I also needed to run git init inside the test folder to make phpactor detect a valid root directory. (I'm sure there are better ways to do this but this was the quickest I knew how).

[folke]

Awesome, thanks.
Apparently lsp results can be a single result instead of a list.

Fixed!

[anotherfrontendguy]

Thank you so much, you're awesome!