Should the directory previewer use the full path instead of the item.file? (Problem with setting cwd)

[Gaweringo]

In the previewer for directories, the ls / vim.fs.dir is called over the item.file, which means, that the value in item.file needs to be relative to the cwd of nvim or an absolute path:

snacks.nvim/lua/snacks/picker/preview.lua

Line 15 in bc0630e

for file, t in vim.fs.dir(ctx.item.file) do

Meaning, that setting item.cwd to a value is not taken into account at this point.
Just before this loop, the full path for the item is stored in a path variable:

snacks.nvim/lua/snacks/picker/preview.lua

Line 11 in bc0630e

local path = Snacks.picker.util.path(ctx.item)

I think it would make sense, for the loop to use that variable instead. Does someone know a reason why it would be a bad idea to use path instead of ctx.item.file here?

Why this came up as a problem for me was, because I am trying to create a picker, which searches through directories and opens them in Oil.nvim. And as with the other file based pickers (files and grep) I added a section, which sets the cwd of the picker to the current oil directory if available. Meaning that I can navigate to a directory in Oil and then my file, grep and directory searches should start from that directory. With the files and grep pickers setting cwd worked, but with my directory picker the preview only works when the cwd is the same as the nvim cwd.

Maybe I just made a mistake somewhere else in my picker creation, so here's the script for it:

    { "<leader>sD", function()
        -- https://github.com/folke/snacks.nvim/issues/1036#issuecomment-2734330151
        -- Present the directories to the user for selection
        local _, oil_dir = pcall(require('oil').get_current_dir)
        Snacks.picker.pick({
          title = "Directories",
          format = "file",
          cwd = oil_dir,
          finder = function(opts, ctx)
            local args = { "--type", "directory", "--color", "never" }
            if opts.hidden then
              table.insert(args, "--hidden")
            end
            if opts.ignored then
              table.insert(args, "--no-ignore")
            end
            local cwd = vim.fs.normalize(opts.cwd or vim.uv.cwd() or ".")
            local proc_opts = {
              cmd = "fd",
              args = args,
              ---@param item snacks.picker.finder.Item
              transform = function(item)
                item.cwd = cwd
                item.file = item.text
                item.dir = true
              end,
            }
            return require("snacks.picker.source.proc").proc({ opts, proc_opts }, ctx)
          end,
          confirm = function(picker, item)
            picker:close()
            require('oil').open(item.file)
          end,
        })

[drowning-cat]

Nice catch. I am pretty sure that is a bug.