Do not emit error for dashboard terminal section commands with non-0 exit codes

[almostSouji]

I'd like cmd to ignore if the exit code is non-0 but cannot find a solution (i am potentially just blind and don't find some option)
background: if a repository does not have issues enabled, gh will respond with exit code 1 and print the following when opening the dashboard:

The element still correctly displays the text, which is expected and wanted:

I'd just like to prevent the "error" from popping up every time.

dashboard section in question:

{
  title = 'Open Issues',
  cmd = 'gh issue list -L 5',
  enabled = in_git,
  section = 'terminal',
  key = 'i',
  action = function()
    vim.fn.jobstart('gh issue list --web', { detach = true })
  end,
  icon = ' ',
  padding = 1,
},

[drowning-cat]

vim.api.nvim_create_autocmd('User', {
  pattern = 'LazyDone',
  group = vim.api.nvim_create_augroup('filter_notify', { clear = true }),
  callback = function()
    local notiy = vim.notify
    vim.notify = function(msg, lvl, opts) ---@diagnostic disable-line: duplicate-set-field
      if msg:match 'Terminal %*%*cmd%*%* .* failed with code' then
      else
        notiy(msg, lvl, opts)
      end
    end
  end,
})

[almostSouji]

oh, smart, wrapping the notify with a noop if it matches the specific text emitted by the plugin! works like a charm, thanks!
granted it does seem a bit hacky, is my use case so rare/unreasonable to not warrant a native solution (prob. wrapping the execution in a pcall or sth?)

[drowning-cat]

I think your use case is quite niche. A more general solution would require passing an on_error function. You should also consider displaying success/error section, and so on. Btw, snacks explicitly sends this error using Snacks.notify.error.

Warning

It should work, but I haven't tested it.

At the moment, this problem can be solved in two ways:

1. Disable the section based on a condition:

{ section = 'header' },
{
  section = 'terminal',
  --[[...]]
  enabled = function()
    return false
  end,
}

{ section = 'header' },
function()
  if true then
    return
  else
    return {
      { section = 'terminal', --[[...]] }
    }
  end
end,

2. Create your own section:

opts = {},
config = function(_, opts)
  require('snacks').setup(opts)
  Snacks.dashboard.<name> = function(opts)
    return function(self)
      -- 
    end
  end
end,

[almostSouji]

oh, i forgot to mention i have considered enabled, but that might be more of an issue with my general understanding of lua/nvim:
i have tried wrapping the same gh call i do in pcall, that does however not cover exit 1 as error and thus will return true from pcall.
is there any way i can catch the exit code when executing vim.system or similar?

[drowning-cat]

enabled = function()
  -- NOTE: Does not cover the case where no executable is present.
  -- WARN: Introduces a significant delay.
  local sys_obj = vim.system({ 'gh', 'issue', 'list', '-L', '1' }):wait()
  return sys_obj.code == 0
end,