picker.buffers: mapping edit split and vsplit don't work

[doums]

Hi,
When using Snacks.picker.buffers the mappings to edit in split or vsplit are not working for some reason.

        ["<c-s>"] = "edit_split",
        ["<c-v>"] = "edit_vsplit",

Even when configured explicitly, e.g.

      Snacks.picker.buffers({
        win = {
          input = {
            keys = {
              ['<c-s>'] = { 'edit_split', mode = { 'n', 'i' } },
              ['<c-v>'] = { 'edit_vsplit', mode = { 'n', 'i' } },
            },
          },
          list = { keys = { ['dd'] = 'bufdelete' } },
        },
      })

Any idea how to get this working?

[drowning-cat]

They work fine. FYI, <c-s> and <c-v> should be mapped by default.

Try using a minimal reproducible example. Check whether it works or not. If it doesn't, try using it in different terminals, with or without tmux (if you're using it). Just in case, update Neovim as well.

-- nvim -u repro.lua repro.lua

vim.env.LAZY_STDPATH = ".repro"
load(vim.fn.system("curl -s https://raw.githubusercontent.com/folke/lazy.nvim/main/bootstrap.lua"))()

require("lazy.minit").repro({
  spec = {
    {
      "folke/snacks.nvim",
      keys = {
        { "<F1>", function() Snacks.picker.buffers() end },
      },
      opts = {
        picker = {},
      },
    },
  },
})

[doums]

Using the shared template it is working as expected.
But for some reason <C-s> and <C-v> are not working with my config, and only for the buffers picker. It works without issue with other pickers. Which is weird. I'm trying to isolate the culprit in my config right now.

[doums]

I found it.
This is due to some weird conflict with nvim-tree.lua.
As soon as I open a file from the tree view of nvim-tree this will prevent <C-s> and <C-v> working properly in the buffers picker 🙃 and only the buffer picker. Using <C-s/v> is still working fine in other pickers.
I double-checked and after opening files from nvim-tree, using :sb x or :vert sb x commands work just fine.
Based on this I think the bug is located in snacks side.

[drowning-cat]

Create a minimal reproducible example with the template (provide steps to repeat). I will try to confirm the issue on my end.

[dpetka2001]

I tried both Snacks.explorer and neo-tree and this works as expected. If it's a conflict with nvim-tree, I'm not quite sure how you think the bug is on Snacks side.

I opened a file from the tree view of both Snacks.explorer and neo-tree and then pressed <C-v> to open some buffer vertically. I believe those are the steps you described.

[doums]

@drowning-cat @dpetka2001 actually it is not related to nvim-tree as I initially thought.
In my config I have this option set switchbuf = "usetab". And this is causing the issue with the buffers picker:

vim.env.LAZY_STDPATH = ".repro"
load(vim.fn.system("curl -s https://raw.githubusercontent.com/folke/lazy.nvim/main/bootstrap.lua"))()

vim.o.switchbuf = "usetab"

require("lazy.minit").repro({
  spec = {
    {
      "folke/snacks.nvim",
      keys = {
        {
          "<C-b>",
          function()
            Snacks.picker.buffers()
          end,
        },
        {
          "<C-s>",
          function()
            Snacks.picker.files()
          end,
        },
      },
      opts = {
        picker = {},
      },
    },
  },
})

[dpetka2001]

That's because the preview window in the buffers picker contains the actual buffer. This is by design from the maintainer. So, this option that controls to which window to jump where the buffer is opened

jump to the first open window in the current tab page that contains the specified buffer (if there is one).

then the mapping won't do anything because the buffer is already opened in the preview window of the buffers picker.

[doums]

Arf, thing is switchbuf useopen or usetab is really handy when working with quickfix/loclist.
I don't want to disable it because of snacks buffers picker.

[doums]

But closing the preview and using the mapping works. Something I can hack around (custom mapping function or layout).

[dpetka2001]

You can open the buffers picker without the preview window with

opts = {
	sources = {
		buffers = {
			layout = {
				preview = false,
			},
		},
	},
}

[doums]

Nope, I prefer using a dedicated layout without preview. Actually I don't need preview for buffers listing and switching.