join with where bug?

[SergeyBakev]

Hello, i create query.
auto cols = _storage.select( &GroupSong::Nm, inner_join<Song>(on(is_equal(&Song::Name, &GroupSong::Name))), where(is_equal(&GroupSong::groupName, groupId)) && greater_than(sub(&GroupSong::NA, &GroupSong::Used), 0));
it genereated next string :

SELECT "GroupSong"."name" 
FROM 'GroupSong' 
INNER JOIN  'songs' 
ON ("songs"."name" = "GroupSong"."name")  
WHERE (("GroupSong"."groupId" = ?)) AND (("GroupSong"."count" - "GroupSong"."used") > ?)

but it can not be executed. Where contains extra "(". What am I doing wrong?

[fnc12]

Hello. Did you try executing the same query in any SQLite client?

[SergeyBakev]

What is mean "any SQLite client". I execute it without "(" and all was successful.

[fnc12]

Looks like serialization bug. I'll check it and fix it today. Thanks

[fnc12]

It is not a bug. You wrote the query incorrectly. You wrote WHERE (...) AND A > B but it doesn't work like that. You must write WHERE (... AND A > B) instead. You wrote:

auto cols = _storage.select(
        &GroupSong::Nm,
        inner_join<Song>(on(is_equal(&Song::Name, &GroupSong::Name))),
        where(is_equal(&GroupSong::groupName, groupId)) && greater_than(sub(&GroupSong::NA, &GroupSong::Used), 0));

but the correct version is

auto cols = _storage.select(
        &GroupSong::Nm,
        inner_join<Song>(on(is_equal(&Song::Name, &GroupSong::Name))),
        where(is_equal(&GroupSong::groupName, groupId) && greater_than(sub(&GroupSong::NA, &GroupSong::Used), 0)));

[SergeyBakev]

Sorry, I didn't see the error. Thanks