Can't disable unused_eager_loading_enable in test

[sfcgeorge]

As other issues note Bullet seems to have eager load false positives in test mode.

So the obvious workaround is to disable the unused eager loading check in test mode like so:

# config/environments/test.rb
  # ...
  config.after_initialize do
    Bullet.enable = true
    Bullet.bullet_logger = true
    Bullet.raise = true
    Bullet.n_plus_one_query_enable = true
    Bullet.unused_eager_loading_enable = false
    Bullet.counter_cache_enable = false
  end
end

This doesn't work! I still get errors. I have cleared tmp/cache and restarted Spring. The only thing that does work is completely disabling bullet in tests:

# config/environments/test.rb
  # ...
  config.after_initialize do
    Bullet.enable = false
    # ...
  end
end

All I can think is that Bullet.n_plus_one_query_enable must be a singleton method and as feature specs run in a separate thread maybe the bullet config is different in the feature server thread?

[victorhazbun]

I can confirm, this is happening to me as well.

[geshwho]

This may not be the exact same scenario you are experiencing, but we were having a similar problem in test and realized that toggling Bullet.enable also resets Bullet.unused_eager_loading_enable.

Here it is reproduced in a rails console:

9> Bullet.unused_eager_loading_enable?
=> true
10> Bullet.unused_eager_loading_enable = false
=> false
11> Bullet.unused_eager_loading_enable?
=> false
12> Bullet.enable = false
=> false
13> Bullet.enable = true
=> true
14> Bullet.enable?
=> true
15> Bullet.unused_eager_loading_enable?
=> true

Setting Bullet.enable to false and back to true always results in Bullet.unused_eager_loading_enable? == true. We work around this by remembering the previous value and restoring it after a toggle.

[bukaninandrei]

Thanks @geshwho! Remembering unused_eager_loading_enables state helps me.

[NeelamAggarwal]

It is happening to me as well.

[18] pry(main)> Bullet.unused_eager_loading_enable?
true
[19] pry(main)> Bullet.unused_eager_loading_enable = false
false
[20] pry(main)> Bullet.enable?
true
[21] pry(main)> Bullet.enable = false
false
[22] pry(main)> Bullet.enable?
false
[23] pry(main)> Bullet.enable = true
true
[24] pry(main)> Bullet.unused_eager_loading_enable?
true
[25] pry(main)>

[varchar]

Just chiming in that this bug still exists in 2024.

[koya1616]

#703 is fixed by #738

[github-actions]

This issue is stale because it has been open for 30 days with no activity.