From 4f19d3c864041eeb07c13a667483db39487a8e3f Mon Sep 17 00:00:00 2001 From: Sam Ruby Date: Thu, 20 Feb 2025 19:18:37 -0500 Subject: [PATCH] require libyaml-dev for Ruby >= 3.4.1 --- lib/generators/dockerfile_generator.rb | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/lib/generators/dockerfile_generator.rb b/lib/generators/dockerfile_generator.rb index 367e7d9..fd11152 100644 --- a/lib/generators/dockerfile_generator.rb +++ b/lib/generators/dockerfile_generator.rb @@ -410,10 +410,12 @@ def generate_app missing = Set.new(base_packages + build_packages) - Set.new(dockerfile.scan(/[-\w]+/)) - # https://github.com/docker-library/ruby/pull/497 - # https://github.com/rails/rails/pull/54237 - missing.delete("libyaml-dev") - missing.delete("yaml-dev") + if Gem::Version.new(RUBY_VERSION) <= Gem::Version.new("3.4.1") + # https://github.com/docker-library/ruby/pull/497 + # https://github.com/rails/rails/pull/54237 + missing.delete("libyaml-dev") + missing.delete("yaml-dev") + end unless missing.empty? message = "The following packages are missing from the Dockerfile: #{missing.to_a.join(", ")}"