Hide map attribution (#73)

* Add isAttributionTextVisible to hide map attribution

* Add isAttributionTextVisible for iOS

* Add dependency_overrides

* implement changing attribution text

---------

Co-authored-by: Julian Bissekkou <julian.bissekkou@tapped.dev>

Author: JeanTapped

arcgis_map_sdk/lib/src/arcgis_location_display.dart

@@ -32,6 +32,7 @@ class ArcgisLocationDisplay {
 
   ArcgisLocationDisplay({int? mapId}) : _mapId = mapId;
 
+  // ignore: use_setters_to_change_properties
   void attachToMap(int mapId) => _mapId = mapId;
 
   void deattachFromMap() => _mapId = null;

arcgis_map_sdk/lib/src/arcgis_map_controller.dart

@@ -320,4 +320,9 @@ class ArcgisMapController {
       },
     );
   }
+
+  Future<void> updateIsAttributionTextVisible(bool isAttributionTextVisible) {
+    return ArcgisMapPlatform.instance
+        .updateIsAttributionTextVisible(mapId, isAttributionTextVisible);
+  }
 }

arcgis_map_sdk/lib/src/arcgis_map_sdk.dart

@@ -40,6 +40,7 @@ class ArcgisMap extends StatefulWidget {
     this.yMax = 66,
     this.onMapCreated,
     this.vectorTileLayerUrls,
+    this.isAttributionTextVisible,
     super.key,
   }) : assert(
           basemap != null ||
@@ -70,6 +71,7 @@ class ArcgisMap extends StatefulWidget {
   final double xMax;
   final double yMin;
   final double yMax;
+  final bool? isAttributionTextVisible;
 
   /// Adds vector tile layers to the map. You can add more than one.
   /// When the [vectorTileLayerUrls] is not empty, the [basemap] field
@@ -110,6 +112,7 @@ class _ArcgisMapState extends State<ArcgisMap> {
     yMin: widget.yMin,
     yMax: widget.yMax,
     vectorTilesUrls: widget.vectorTileLayerUrls,
+    isAttributionTextVisible: widget.isAttributionTextVisible,
   );
 
   Future<void> onPlatformViewCreated(int id) async {
@@ -138,6 +141,12 @@ class _ArcgisMapState extends State<ArcgisMap> {
     if ((widget.basemap != null) && oldWidget.basemap != widget.basemap) {
       controller.toggleBaseMap(baseMap: widget.basemap!);
     }
+    if (widget.isAttributionTextVisible != null &&
+        widget.isAttributionTextVisible != oldWidget.isAttributionTextVisible) {
+      controller.updateIsAttributionTextVisible(
+        widget.isAttributionTextVisible!,
+      );
+    }
     _arcgisMapOptions = ArcgisMapOptions(
       apiKey: widget.apiKey,
       licenseKey: widget.licenseKey,
@@ -161,6 +170,7 @@ class _ArcgisMapState extends State<ArcgisMap> {
       yMax: widget.yMax,
       vectorTilesUrls: widget.vectorTileLayerUrls,
       defaultUiList: widget.defaultUiList,
+      isAttributionTextVisible: widget.isAttributionTextVisible,
     );
   }
 

arcgis_map_sdk_android/android/src/main/kotlin/dev/fluttercommunity/arcgis_map_sdk_android/ArcgisMapView.kt

@@ -79,8 +79,9 @@ internal class ArcgisMapView(
 
         mapView = view.findViewById(R.id.mapView)
 
-        map.apply {
+        mapOptions.isAttributionTextVisible?.let { mapView.isAttributionTextVisible = it }
 
+        map.apply {
             basemap = if (mapOptions.basemap != null) {
                 Basemap(mapOptions.basemap)
             } else {
@@ -182,11 +183,27 @@ internal class ArcgisMapView(
                     result
                 )
 
+                "update_is_attribution_text_visible" -> onUpdateIsAttributionTextVisible(
+                    call,
+                    result
+                )
+
                 else -> result.notImplemented()
             }
         }
     }
 
+    private fun onUpdateIsAttributionTextVisible(call: MethodCall, result: MethodChannel.Result) {
+        val isVisible = call.arguments as? Boolean
+        if (isVisible == null) {
+            result.error("invalid_argument", "isAttributionTextVisible must be a boolean", null)
+            return
+        }
+
+        mapView.isAttributionTextVisible = isVisible
+        result.success(true)
+    }
+
     private fun onStartLocationDisplayDataSource(result: MethodChannel.Result) {
         result.finishWithFuture { mapView.locationDisplay.locationDataSource.startAsync() }
     }

arcgis_map_sdk_android/android/src/main/kotlin/dev/fluttercommunity/arcgis_map_sdk_android/model/ArcgisMapOptions.kt

@@ -20,4 +20,5 @@ data class ArcgisMapOptions(
     val xMax: Double,
     val yMin: Double,
     val yMax: Double,
+    val isAttributionTextVisible: Boolean?,
 )

arcgis_map_sdk_ios/ios/Classes/ArcgisMapView.swift

@@ -75,6 +75,10 @@ class ArcgisMapView: NSObject, FlutterPlatformView {
         mapView = AGSMapView.init(frame: frame)
 
         super.init()
+        
+        if let isAttributionTextVisible = mapOptions.isAttributionTextVisible {
+            mapView.isAttributionTextVisible = isAttributionTextVisible
+        }
 
         if mapOptions.basemap != nil {
             map.basemap = AGSBasemap(style: parseBaseMapStyle(mapOptions.basemap!))
@@ -153,6 +157,7 @@ class ArcgisMapView: NSObject, FlutterPlatformView {
             case "location_display_set_use_course_symbol_on_move" : onSetLocationDisplayUseCourseSymbolOnMove(call, result)
             case "location_display_update_display_source_position_manually" : onUpdateLocationDisplaySourcePositionManually(call, result)
             case "location_display_set_data_source_type" : onSetLocationDisplayDataSourceType(call, result)
+            case "update_is_attribution_text_visible": onUpdateIsAttributionTextVisible(call, result)
             default:
                 result(FlutterError(code: "Unimplemented", message: "No method matching the name \(call.method)", details: nil))
             }
@@ -501,6 +506,16 @@ class ArcgisMapView: NSObject, FlutterPlatformView {
             result(FlutterError(code: "invalid_data", message: "Unknown data source type \(String(describing: type))", details: nil))
         }
     }
+    
+    private func onUpdateIsAttributionTextVisible(_ call: FlutterMethodCall, _ result: @escaping FlutterResult) {
+        guard let isVisible = call.arguments as? Bool else {
+            result(FlutterError(code: "missing_data", message: "Invalid arguments", details: nil))
+            return
+        }
+        
+        mapView.isAttributionTextVisible = isVisible
+        result(true)
+    }
 
     private func operationWithSymbol(_ call: FlutterMethodCall, _ result: @escaping FlutterResult, handler: (AGSSymbol) -> Void) {
         do {

arcgis_map_sdk_ios/ios/Classes/Models/ArcgisMapOptions.swift

@@ -23,4 +23,5 @@ struct ArcgisMapOptions: Codable {
     let xMax: Int
     let yMin: Int
     let yMax: Int
+    let isAttributionTextVisible: Bool?
 }

arcgis_map_sdk_method_channel/lib/src/method_channel_arcgis_map_plugin.dart

@@ -304,4 +304,15 @@ class MethodChannelArcgisMapPlugin extends ArcgisMapPlatform {
       type,
     );
   }
+
+  @override
+  Future<void> updateIsAttributionTextVisible(
+    int mapId,
+    bool isAttributionTextVisible,
+  ) {
+    return _methodChannelBuilder(mapId).invokeMethod(
+      "update_is_attribution_text_visible",
+      isAttributionTextVisible,
+    );
+  }
 }

arcgis_map_sdk_method_channel/lib/src/model_extension.dart

@@ -47,6 +47,7 @@ extension ArcgisMapOptionsJsonExtension on ArcgisMapOptions {
       'xMax': xMax,
       'yMin': yMin,
       'yMax': yMax,
+      'isAttributionTextVisible': isAttributionTextVisible,
     };
   }
 }

arcgis_map_sdk_platform_interface/lib/src/arcgis_map_sdk_platform_interface.dart

@@ -277,4 +277,13 @@ class ArcgisMapPlatform extends PlatformInterface {
       'setLocationDisplay() has not been implemented.',
     );
   }
+
+  Future<void> updateIsAttributionTextVisible(
+    int mapId,
+    bool isAttributionTextVisible,
+  ) {
+    throw UnimplementedError(
+      'updateIsAttributionTextVisible() has not been implemented.',
+    );
+  }
 }