Remove unsupported DevTools path URL code (#8287)

This was for older SDK versions

Author: helin24

flutter-idea/src/io/flutter/devtools/DevToolsUrl.java

@@ -30,7 +30,6 @@ public class DevToolsUrl {
   private final FlutterSdkVersion flutterSdkVersion;
   private final FlutterSdkUtil sdkUtil;
 
-  private final boolean canUseDevToolsPathUrl;
   private final boolean canUseMultiEmbed;
 
   public final DevToolsIdeFeature ideFeature;
@@ -163,15 +162,12 @@ private DevToolsUrl(Builder builder) {
     this.sdkUtil = builder.flutterSdkUtil;
 
     if (builder.workspaceCache != null && builder.workspaceCache.isBazel()) {
-      this.canUseDevToolsPathUrl = true;
       this.canUseMultiEmbed = true;
     }
     else if (flutterSdkVersion != null) {
-      this.canUseDevToolsPathUrl = flutterSdkVersion.canUseDevToolsPathUrls();
       this.canUseMultiEmbed = flutterSdkVersion.canUseDevToolsMultiEmbed();
     }
     else {
-      this.canUseDevToolsPathUrl = false;
       this.canUseMultiEmbed = false;
     }
   }
@@ -183,9 +179,6 @@ public String getUrlString() {
 
     String ideValue = sdkUtil.getFlutterHostEnvValue();
     params.add("ide=" + (ideValue == null ? "IntelliJPluginUnknown" : ideValue));
-    if (page != null && !this.canUseDevToolsPathUrl) {
-      params.add("page=" + page);
-    }
     if (colorHexCode != null) {
       params.add("backgroundColor=" + colorHexCode);
     }
@@ -218,12 +211,7 @@ public String getUrlString() {
     if (widgetId != null) {
       params.add("inspectorRef=" + widgetId);
     }
-    if (this.canUseDevToolsPathUrl) {
-      return "http://" + devToolsHost + ":" + devToolsPort + "/" + (page != null ? page : "") + "?" + String.join("&", params);
-    }
-    else {
-      return "http://" + devToolsHost + ":" + devToolsPort + "/#/?" + String.join("&", params);
-    }
+    return "http://" + devToolsHost + ":" + devToolsPort + "/" + (page != null ? page : "") + "?" + String.join("&", params);
   }
 
   public void maybeUpdateColor() {

flutter-idea/src/io/flutter/sdk/FlutterSdkVersion.java

@@ -42,9 +42,6 @@ public final class FlutterSdkVersion implements Comparable<FlutterSdkVersion> {
   @NotNull
   public static final FlutterSdkVersion MIN_SDK_WITHOUT_SUNSET_WARNING = new FlutterSdkVersion("3.16");
 
-  @NotNull
-  private static final FlutterSdkVersion MIN_SUPPORTS_DEVTOOLS_PATH_URLS = new FlutterSdkVersion("3.3.0");
-
   @NotNull
   private static final FlutterSdkVersion MIN_SUPPORTS_TOOL_EVENT_STREAM = new FlutterSdkVersion("3.7.1");
 
@@ -132,10 +129,6 @@ private boolean supportsVersion(@NotNull FlutterSdkVersion otherVersion) {
     return this.compareTo(otherVersion) >= 0;
   }
 
-  public boolean canUseDevToolsPathUrls() {
-    return supportsVersion(MIN_SUPPORTS_DEVTOOLS_PATH_URLS);
-  }
-
   public boolean canUseToolEventStream() {
     return supportsVersion(MIN_SUPPORTS_TOOL_EVENT_STREAM);
   }

flutter-idea/testSrc/unit/io/flutter/devtools/DevToolsUrlTest.java

@@ -96,24 +96,9 @@ public void testGetUrlStringWithoutColor() {
         .getUrlString()
     );
 
-    FlutterSdkVersion oldVersion = new FlutterSdkVersion("3.0.0");
+    // No Flutter SDK version set
     assertEquals(
-      "http://127.0.0.1:9100/#/?ide=Android-Studio&page=timeline&uri=http%3A%2F%2F127.0.0.1%3A50224%2FWTFTYus3IPU%3D%2F",
-      new DevToolsUrl.Builder()
-        .setDevToolsHost(devtoolsHost)
-        .setDevToolsPort(devtoolsPort)
-        .setVmServiceUri(serviceProtocolUri)
-        .setPage(page)
-        .setFlutterSdkVersion(oldVersion)
-        .setWorkspaceCache(notBazelWorkspaceCache)
-        .setFlutterSdkUtil(mockSdkUtil)
-        .setDevToolsUtils(noColorUtils)
-        .build()
-        .getUrlString()
-    );
-
-    assertEquals(
-      "http://127.0.0.1:9100/#/?ide=Android-Studio&page=timeline&uri=http%3A%2F%2F127.0.0.1%3A50224%2FWTFTYus3IPU%3D%2F",
+      "http://127.0.0.1:9100/timeline?ide=Android-Studio&uri=http%3A%2F%2F127.0.0.1%3A50224%2FWTFTYus3IPU%3D%2F",
       new DevToolsUrl.Builder()
         .setDevToolsHost(devtoolsHost)
         .setDevToolsPort(devtoolsPort)