- (#7588)

Author: polina-c

packages/devtools_app/lib/src/screens/memory/shared/heap/class_filter.dart

@@ -220,7 +220,7 @@ class ClassFilter {
 
     // Return previous data if filter is identical.
     final task = newFilter.task(previous: oldFilter);
-    if (task == FilteringTask.doNothing) return original;
+    if (task == FilteringTask.doNothing) return oldFiltered!;
 
     final Iterable<T> dataToFilter;
     if (task == FilteringTask.refilter) {

packages/devtools_app/test/memory/shared/heap/class_filter_test.dart

@@ -28,22 +28,39 @@ void main() {
     expect(filter.filters, {'f1', 'f2', 'f3'});
   });
 
-  test('$ClassFilter.filter filters.', () {
-    final filter = ClassFilter(
+  test('$ClassFilter.filter is noop when not selected filter changes.', () {
+    final filter1 = ClassFilter(
       filterType: ClassFilterType.except,
       except: 'class1, library2, library3/class3',
       only: '',
     );
 
-    final result = ClassFilter.filter(
+    final result1 = ClassFilter.filter(
       oldFilter: null,
-      newFilter: filter,
+      newFilter: filter1,
       oldFiltered: null,
       original: _data,
       extractClass: (c) => c,
       rootPackage: null,
     );
 
-    expect(result, [_class4]);
+    expect(result1, [_class4]);
+
+    final filter2 = ClassFilter(
+      filterType: ClassFilterType.except,
+      except: filter1.except,
+      only: 'something',
+    );
+
+    final result2 = ClassFilter.filter(
+      oldFilter: filter1,
+      newFilter: filter2,
+      oldFiltered: result1,
+      original: _data,
+      extractClass: (c) => c,
+      rootPackage: null,
+    );
+
+    expect(result2, result1);
   });
 }