Skip to content

Commit baeb606

Browse files
authored
Don't report error to user if script parsing fails (#9104)
1 parent a45587c commit baeb606

File tree

2 files changed

+0
-20
lines changed

2 files changed

+0
-20
lines changed

packages/devtools_app/lib/src/screens/debugger/codeview_controller.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,6 @@ class CodeViewController extends DisposableController
268268
reportError(
269269
'Failed to parse ${scriptRef.uri}.',
270270
stack: StackTrace.current,
271-
notifyUser: true,
272271
);
273272
return false;
274273
}

packages/devtools_app/test/screens/debugger/debugger_scripts_test.dart

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -217,25 +217,6 @@ void main() {
217217
]);
218218
},
219219
);
220-
221-
testWidgetsWithWindowSize('an error message is shown', smallWindowSize, (
222-
WidgetTester tester,
223-
) async {
224-
await pumpDebuggerScreen(tester, mockDebuggerController);
225-
// Dismiss any previous notifications:
226-
notificationService.dismiss(
227-
'Failed to parse package:gallery/src/unknown.dart.',
228-
);
229-
await tester.pumpAndSettle();
230-
231-
await showScript(mockEmptyScriptRef);
232-
await tester.pumpAndSettle();
233-
234-
expect(
235-
notificationService.activeMessages.first.text,
236-
equals('Failed to parse package:gallery/src/unknown.dart.'),
237-
);
238-
});
239220
});
240221
}
241222

0 commit comments

Comments
 (0)