[deep link] display "missing scheme" and "missing domain" for null values. (#7559)

* add null scheme and domains

* Update NEXT_RELEASE_NOTES.md

* resolve comments

* Update deep_links_model.dart

* Update deep_links_screen_test.dart

* lint

Author: hannah-hyj

packages/devtools_app/lib/src/screens/deep_link_validation/deep_links_controller.dart

@@ -8,15 +8,15 @@ import 'package:devtools_app_shared/utils.dart';
 import 'package:devtools_shared/devtools_deeplink.dart';
 import 'package:flutter/material.dart';
 
+import '../../../devtools_app.dart';
 import '../../shared/analytics/analytics.dart' as ga;
 import '../../shared/analytics/constants.dart' as gac;
-import '../../shared/globals.dart';
 import '../../shared/server/server.dart' as server;
 import 'deep_link_list_view.dart';
 import 'deep_links_model.dart';
 import 'deep_links_services.dart';
 
-typedef _DomainAndPath = ({String domain, String path});
+typedef _DomainAndPath = ({String? domain, String path});
 
 const domainAssetLinksJsonFileErrors = {
   DomainError.existence,
@@ -160,6 +160,7 @@ class DeepLinksController extends DisposableController {
       linkDatasByPath[linkData.path] = LinkData(
         domain: linkData.domain,
         path: linkData.path,
+        scheme: linkData.scheme.union(previousRecord?.scheme ?? {}),
         os: [
           if (previousRecord?.os.contains(PlatformOS.android) ??
               false || linkData.os.contains(PlatformOS.android))
@@ -170,7 +171,7 @@ class DeepLinksController extends DisposableController {
         ],
         associatedDomains: [
           ...previousRecord?.associatedDomains ?? [],
-          linkData.domain,
+          if (linkData.domain != null) linkData.domain!,
         ],
         pathErrors: linkData.pathErrors,
       );
@@ -182,12 +183,15 @@ class DeepLinksController extends DisposableController {
   @visibleForTesting
   List<LinkData> linkDatasByDomain(List<LinkData> linkdatas) {
     final linkDatasByDomain = <String, LinkData>{};
-
     for (var linkData in linkdatas) {
+      if (linkData.domain.isNullOrEmpty) {
+        continue;
+      }
       final previousRecord = linkDatasByDomain[linkData.domain];
-      linkDatasByDomain[linkData.domain] = LinkData(
+      linkDatasByDomain[linkData.domain!] = LinkData(
         domain: linkData.domain,
         path: linkData.path,
+        scheme: linkData.scheme.union(previousRecord?.scheme ?? {}),
         os: linkData.os,
         associatedPath: [
           ...previousRecord?.associatedPath ?? [],
@@ -267,6 +271,7 @@ class DeepLinksController extends DisposableController {
     final domainPathToLinkData = <_DomainAndPath, LinkData>{};
     for (final appLink in appLinks) {
       final domainAndPath = (domain: appLink.host, path: appLink.path);
+      final scheme = appLink.scheme;
 
       if (domainPathToLinkData[domainAndPath] == null) {
         domainPathToLinkData[domainAndPath] = LinkData(
@@ -275,12 +280,12 @@ class DeepLinksController extends DisposableController {
           pathErrors:
               _getPathErrorsFromIntentFilterChecks(appLink.intentFilterChecks),
           os: [PlatformOS.android],
-          scheme: [appLink.scheme],
+          scheme: {if (scheme != null) scheme},
         );
       } else {
         final linkData = domainPathToLinkData[domainAndPath]!;
-        if (!linkData.scheme.contains(appLink.scheme)) {
-          linkData.scheme.add(appLink.scheme);
+        if (scheme != null) {
+          linkData.scheme.add(scheme);
         }
         final pathErrors = {
           ...linkData.pathErrors,
@@ -341,20 +346,27 @@ class DeepLinksController extends DisposableController {
 
   Future<void> _generateAssetLinks() async {
     generatedAssetLinksForSelectedLink.value = null;
-    generatedAssetLinksForSelectedLink.value =
-        await deepLinksServices.generateAssetLinks(
-      domain: selectedLink.value!.domain,
-      applicationId: applicationId,
-      localFingerprint: localFingerprint.value,
-    );
+    final domain = selectedLink.value!.domain;
+    if (domain != null) {
+      generatedAssetLinksForSelectedLink.value =
+          await deepLinksServices.generateAssetLinks(
+        domain: domain,
+        applicationId: applicationId,
+        localFingerprint: localFingerprint.value,
+      );
+    }
   }
 
   Future<List<LinkData>> _validateAndroidDomain(
     List<LinkData> linkdatas,
   ) async {
     final domains = linkdatas
-        .where((linkdata) => linkdata.os.contains(PlatformOS.android))
-        .map((linkdata) => linkdata.domain)
+        .where(
+          (linkdata) =>
+              linkdata.os.contains(PlatformOS.android) &&
+              linkdata.domain != null,
+        )
+        .map((linkdata) => linkdata.domain!)
         .toSet()
         .toList();
 

packages/devtools_app/lib/src/screens/deep_link_validation/deep_links_model.dart

@@ -18,6 +18,8 @@ const kDeeplinkTableCellDefaultWidth = 200.0;
 const kToolTipWidth = 344.0;
 const metaDataDeepLinkingFlagTag =
     '<meta-data android:name="flutter_deeplinking_enabled" android:value="true" />';
+const missingDomain = 'missing domain';
+const missingScheme = 'missing scheme';
 
 enum PlatformOS {
   android('Android'),
@@ -193,17 +195,17 @@ class LinkData with SearchableDataMixin {
     required this.domain,
     required this.path,
     required this.os,
-    this.scheme = const <String>['http://', 'https://'],
+    this.scheme = const <String>{},
     this.domainErrors = const <DomainError>[],
     this.pathErrors = const <PathError>{},
     this.associatedPath = const <String>[],
     this.associatedDomains = const <String>[],
   });
 
   final String path;
-  final String domain;
+  final String? domain;
   final List<PlatformOS> os;
-  final List<String> scheme;
+  final Set<String> scheme;
   final List<DomainError> domainErrors;
   Set<PathError> pathErrors;
 
@@ -212,7 +214,7 @@ class LinkData with SearchableDataMixin {
 
   @override
   bool matchesSearchToken(RegExp regExpSearch) {
-    return domain.caseInsensitiveContains(regExpSearch) ||
+    return (domain?.caseInsensitiveContains(regExpSearch) ?? false) ||
         path.caseInsensitiveContains(regExpSearch);
   }
 
@@ -328,7 +330,7 @@ class DomainColumn extends ColumnData<LinkData>
   }
 
   @override
-  String getValue(LinkData dataObject) => dataObject.domain;
+  String getValue(LinkData dataObject) => dataObject.domain ?? 'missing domain';
 
   @override
   Widget build(
@@ -338,12 +340,14 @@ class DomainColumn extends ColumnData<LinkData>
     bool isRowHovered = false,
     VoidCallback? onPressed,
   }) {
-    return _ErrorAwareText(
-      isError: dataObject.domainErrors.isNotEmpty,
-      controller: controller,
-      text: dataObject.domain,
-      link: dataObject,
-    );
+    return dataObject.domain == null
+        ? Text('missing domain', style: Theme.of(context).errorTextStyle)
+        : _ErrorAwareText(
+            isError: dataObject.domainErrors.isNotEmpty,
+            controller: controller,
+            text: dataObject.domain!,
+            link: dataObject,
+          );
   }
 
   @override
@@ -474,7 +478,9 @@ class SchemeColumn extends ColumnData<LinkData>
     bool isRowHovered = false,
     VoidCallback? onPressed,
   }) {
-    return Text(getValue(dataObject));
+    return dataObject.scheme.isEmpty
+        ? Text(missingScheme, style: Theme.of(context).errorTextStyle)
+        : Text(getValue(dataObject));
   }
 
   @override
@@ -723,11 +729,11 @@ int _compareLinkData(
       }
       return 0;
     case SortingOption.aToZ:
-      if (compareDomain) return a.domain.compareTo(b.domain);
+      if (compareDomain) return (a.domain ?? '').compareTo(b.domain ?? '');
 
       return a.path.compareTo(b.path);
     case SortingOption.zToA:
-      if (compareDomain) return b.domain.compareTo(a.domain);
+      if (compareDomain) return (b.domain ?? '').compareTo(a.domain ?? '');
 
       return b.path.compareTo(a.path);
   }

packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md

@@ -48,6 +48,7 @@ TODO: Remove this section if there are not any general updates.
 ## Deep links tool updates
 
 * Improve layout for narrow screens. - [#7524](https://github.com/flutter/devtools/pull/7524)
+* Add error handling for missing schemes and domains - [#7559](https://github.com/flutter/devtools/pull/7559)
 
 ## VS Code Sidebar updates
 

packages/devtools_app/test/deep_link_vlidation/deep_links_screen_test.dart

@@ -538,6 +538,48 @@ void main() {
       },
     );
 
+    testWidgetsWithWindowSize(
+      'show scheme or missing scheme',
+      windowSize,
+      (WidgetTester tester) async {
+        final deepLinksController = DeepLinksTestController();
+
+        deepLinksController.selectedProject.value =
+            FlutterProject(path: '/abc', androidVariants: ['debug', 'release']);
+
+        final linkDatas = [
+          LinkData(
+            domain: 'www.domain1.com',
+            path: '/',
+            os: [PlatformOS.android],
+          ),
+          LinkData(
+            domain: 'www.domain2.com',
+            path: '/',
+            os: [PlatformOS.ios],
+            scheme: {'http'},
+          ),
+        ];
+
+        deepLinksController.validatedLinkDatas = ValidatedLinkDatas(
+          all: linkDatas,
+          byDomain: deepLinksController.linkDatasByDomain(linkDatas),
+          byPath: deepLinksController.linkDatasByPath(linkDatas),
+        );
+
+        await pumpDeepLinkScreen(
+          tester,
+          controller: deepLinksController,
+        );
+
+        expect(find.text('www.domain1.com'), findsOneWidget);
+        expect(find.text('www.domain2.com'), findsOneWidget);
+
+        expect(find.text('missing scheme'), findsOneWidget);
+        expect(find.text('http'), findsOneWidget);
+      },
+    );
+
     testWidgetsWithWindowSize(
       'path view',
       windowSize,

packages/devtools_shared/lib/src/deeplink/app_link_settings.dart

@@ -60,8 +60,8 @@ class AndroidDeeplink {
 
   factory AndroidDeeplink._fromJsonObject(Map<String, dynamic> json) {
     return AndroidDeeplink._(
-      json[_kSchemeKey] as String,
-      json[_kHostKey] as String,
+      json[_kSchemeKey] as String?,
+      json[_kHostKey] as String?,
       json[_kPathKey] as String,
       IntentFilterChecks._fromJsonObject(
         json[_kIntentFilterChecksKey] as Map<String, dynamic>,
@@ -75,10 +75,10 @@ class AndroidDeeplink {
   static const _kIntentFilterChecksKey = 'intentFilterCheck';
 
   /// The scheme section of the deeplink.
-  final String scheme;
+  final String? scheme;
 
   /// The host section of the deeplink.
-  final String host;
+  final String? host;
 
   /// The path pattern section of the deeplink.
   final String path;