Skip to content

Commit 3d89cb3

Browse files
authored
- (#7627)
1 parent 30356f4 commit 3d89cb3

File tree

6 files changed

+43
-37
lines changed

6 files changed

+43
-37
lines changed

packages/devtools_app/lib/devtools_app.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ export 'src/shared/environment_parameters/environment_parameters_external.dart';
8181
export 'src/shared/error_badge_manager.dart';
8282
export 'src/shared/globals.dart';
8383
export 'src/shared/http/http_request_data.dart';
84+
export 'src/shared/memory/gc_stats.dart';
8485
export 'src/shared/notifications.dart';
8586
export 'src/shared/offline_data.dart';
8687
export 'src/shared/preferences/preferences.dart';

packages/devtools_app/lib/src/screens/memory/panes/profile/model.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import 'package:vm_service/vm_service.dart';
66

77
import '../../../../shared/memory/class_name.dart';
8+
import '../../../../shared/memory/gc_stats.dart';
89
import '../../../../shared/table/table_data.dart';
910
import '../../../vm_developer/vm_service_private_extensions.dart';
1011
import '../../shared/heap/class_filter.dart';

packages/devtools_app/lib/src/screens/memory/panes/profile/profile_view.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,13 @@ import '../../../../shared/analytics/analytics.dart' as ga;
1010
import '../../../../shared/analytics/constants.dart' as gac;
1111
import '../../../../shared/common_widgets.dart';
1212
import '../../../../shared/globals.dart';
13+
import '../../../../shared/memory/gc_stats.dart';
1314
import '../../../../shared/primitives/byte_utils.dart';
1415
import '../../../../shared/primitives/simple_items.dart';
1516
import '../../../../shared/primitives/utils.dart';
1617
import '../../../../shared/table/table.dart';
1718
import '../../../../shared/table/table_controller.dart';
1819
import '../../../../shared/table/table_data.dart';
19-
import '../../../vm_developer/vm_service_private_extensions.dart';
2020
import '../../shared/heap/class_filter.dart';
2121
import '../../shared/primitives/simple_elements.dart';
2222
import '../../shared/widgets/class_filter.dart';

packages/devtools_app/lib/src/screens/vm_developer/vm_service_private_extensions.dart

Lines changed: 1 addition & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import 'package:flutter/widgets.dart';
88
import 'package:vm_service/vm_service.dart';
99

1010
import '../../shared/globals.dart';
11+
import '../../shared/memory/gc_stats.dart';
1112
import '../../shared/primitives/utils.dart';
1213
import '../memory/panes/profile/profile_view.dart';
1314

@@ -107,41 +108,6 @@ extension ClassHeapStatsPrivateViewExtension on ClassHeapStats {
107108
: const HeapStats.empty();
108109
}
109110

110-
class GCStats {
111-
GCStats({
112-
required this.heap,
113-
required this.usage,
114-
required this.capacity,
115-
required this.collections,
116-
required this.averageCollectionTime,
117-
});
118-
119-
factory GCStats.parse({
120-
required String heap,
121-
required Map<String, dynamic> json,
122-
}) {
123-
final collections = json[collectionsKey] as int;
124-
return GCStats(
125-
heap: heap,
126-
usage: json[usedKey],
127-
capacity: json[capacityKey],
128-
collections: collections,
129-
averageCollectionTime: (json[timeKey] as num) * 1000 / collections,
130-
);
131-
}
132-
133-
static const usedKey = 'used';
134-
static const capacityKey = 'capacity';
135-
static const collectionsKey = 'collections';
136-
static const timeKey = 'time';
137-
138-
final String heap;
139-
final int usage;
140-
final int capacity;
141-
final int collections;
142-
final double averageCollectionTime;
143-
}
144-
145111
extension AllocationProfilePrivateViewExtension on AllocationProfile {
146112
static const heapsKey = '_heaps';
147113
static const newSpaceKey = 'new';
Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
// Copyright 2024 The Chromium Authors. All rights reserved.
2+
// Use of this source code is governed by a BSD-style license that can be
3+
// found in the LICENSE file.
4+
5+
class GCStats {
6+
GCStats({
7+
required this.heap,
8+
required this.usage,
9+
required this.capacity,
10+
required this.collections,
11+
required this.averageCollectionTime,
12+
});
13+
14+
factory GCStats.parse({
15+
required String heap,
16+
required Map<String, dynamic> json,
17+
}) {
18+
final collections = json[collectionsKey] as int;
19+
return GCStats(
20+
heap: heap,
21+
usage: json[usedKey],
22+
capacity: json[capacityKey],
23+
collections: collections,
24+
averageCollectionTime: (json[timeKey] as num) * 1000 / collections,
25+
);
26+
}
27+
28+
static const usedKey = 'used';
29+
static const capacityKey = 'capacity';
30+
static const collectionsKey = 'collections';
31+
static const timeKey = 'time';
32+
33+
final String heap;
34+
final int usage;
35+
final int capacity;
36+
final int collections;
37+
final double averageCollectionTime;
38+
}

packages/devtools_app/test/memory/profile/allocation_profile_table_view_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
import 'package:devtools_app/src/screens/memory/framework/memory_tabs.dart';
66
import 'package:devtools_app/src/screens/memory/panes/profile/model.dart';
77
import 'package:devtools_app/src/screens/memory/panes/profile/profile_pane_controller.dart';
8-
import 'package:devtools_app/src/screens/vm_developer/vm_service_private_extensions.dart';
98
import 'package:devtools_app/src/shared/globals.dart';
9+
import 'package:devtools_app/src/shared/memory/gc_stats.dart';
1010
import 'package:devtools_app/src/shared/primitives/byte_utils.dart';
1111
import 'package:devtools_app/src/shared/primitives/utils.dart';
1212
import 'package:devtools_app/src/shared/table/table.dart';

0 commit comments

Comments
 (0)