Code quality (#326)

* Implemented lints
Working on Various issues with code quality  #323

* Fixed up example

* Further lint fixes
Working on #323

* Began nullability rework
Working on #323

* Made sockets strongly typed

* Cleaned up utils
Working 0n #323

* Continued nullability rework + updated constant
Working on Various issues with code quality  #323

* Fixed late issue in dialog

* Fixed request sender

* Fixed bug in authentication

* Slimmed down constructor of RTCSession
Working on Various issues with code quality  #323

* Fixed a test

* Reworked constructor of UA
Working on Various issues with code quality  #323

* Reworked transport class
Fixed a potential infite loop
Made field final
Working on Various issues with code quality  #323

* Reworked options

* Reworked messsage class
Workingon Various issues with code quality  #323

* Cleaned up math class
Working on Various issues with code quality  #323

* Reworked subscriber class
Working in Various issues with code quality  #323

* Removed unwanted late

* Fixed a possible concurrent modification exception
Working on Various issues with code quality  #323

* Removed unused file. WebRtc version bump.

Co-authored-by: Perondas <114622@fhwn.ac.at>
Co-authored-by: Perondas <Pperondas@gmail.com>

Author: 3 people

example/lib/src/about.dart

@@ -14,7 +14,7 @@ class AboutWidget extends StatelessWidget {
               child: Column(
                 children: <Widget>[
                   Text(
-                      '\Github:\nhttps://github.com/cloudwebrtc/dart-sip-ua.git')
+                      'GitHub:\nhttps://github.com/cloudwebrtc/dart-sip-ua.git')
                 ],
               ),
             ),

example/lib/src/callscreen.dart

@@ -36,11 +36,11 @@ class _MyCallScreenWidget extends State<CallScreenWidget>
   CallStateEnum _state = CallStateEnum.NONE;
   SIPUAHelper? get helper => widget._helper;
 
-  bool get voiceonly =>
+  bool get voiceOnly =>
       (_localStream == null || _localStream!.getVideoTracks().isEmpty) &&
       (_remoteStream == null || _remoteStream!.getVideoTracks().isEmpty);
 
-  String? get remote_identity => call!.remote_identity;
+  String? get remoteIdentity => call!.remote_identity;
 
   String get direction => call!.direction;
 
@@ -65,7 +65,7 @@ class _MyCallScreenWidget extends State<CallScreenWidget>
     _timer = Timer.periodic(Duration(seconds: 1), (Timer timer) {
       Duration duration = Duration(seconds: timer.tick);
       if (mounted) {
-        this.setState(() {
+        setState(() {
           _timeLabel = [duration.inMinutes, duration.inSeconds]
               .map((seg) => seg.remainder(60).toString().padLeft(2, '0'))
               .join(':');
@@ -102,21 +102,21 @@ class _MyCallScreenWidget extends State<CallScreenWidget>
         callState.state == CallStateEnum.UNHOLD) {
       _hold = callState.state == CallStateEnum.HOLD;
       _holdOriginator = callState.originator;
-      this.setState(() {});
+      setState(() {});
       return;
     }
 
     if (callState.state == CallStateEnum.MUTED) {
       if (callState.audio!) _audioMuted = true;
       if (callState.video!) _videoMuted = true;
-      this.setState(() {});
+      setState(() {});
       return;
     }
 
     if (callState.state == CallStateEnum.UNMUTED) {
       if (callState.audio!) _audioMuted = false;
       if (callState.video!) _videoMuted = false;
-      this.setState(() {});
+      setState(() {});
       return;
     }
 
@@ -154,7 +154,7 @@ class _MyCallScreenWidget extends State<CallScreenWidget>
   void registrationStateChanged(RegistrationState state) {}
 
   void _cleanUp() {
-    if(_localStream == null) return;
+    if (_localStream == null) return;
     _localStream?.getTracks().forEach((track) {
       track.stop();
     });
@@ -188,7 +188,7 @@ class _MyCallScreenWidget extends State<CallScreenWidget>
       _remoteStream = stream;
     }
 
-    this.setState(() {
+    setState(() {
       _resizeLocalVideo();
     });
   }
@@ -211,26 +211,26 @@ class _MyCallScreenWidget extends State<CallScreenWidget>
   }
 
   void _handleAccept() async {
-    bool remote_has_video = call!.remote_has_video;
+    bool remoteHasVideo = call!.remote_has_video;
     final mediaConstraints = <String, dynamic>{
       'audio': true,
-      'video': remote_has_video
+      'video': remoteHasVideo
     };
     MediaStream mediaStream;
 
-    if (kIsWeb && remote_has_video) {
+    if (kIsWeb && remoteHasVideo) {
       mediaStream =
           await navigator.mediaDevices.getDisplayMedia(mediaConstraints);
       mediaConstraints['video'] = false;
       MediaStream userStream =
           await navigator.mediaDevices.getUserMedia(mediaConstraints);
       mediaStream.addTrack(userStream.getAudioTracks()[0], addToNative: true);
     } else {
-      mediaConstraints['video'] = remote_has_video;
+      mediaConstraints['video'] = remoteHasVideo;
       mediaStream = await navigator.mediaDevices.getUserMedia(mediaConstraints);
     }
 
-    call!.answer(helper!.buildCallOptions(!remote_has_video),
+    call!.answer(helper!.buildCallOptions(!remoteHasVideo),
         mediaStream: mediaStream);
   }
 
@@ -264,9 +264,9 @@ class _MyCallScreenWidget extends State<CallScreenWidget>
     }
   }
 
-  late String _tansfer_target;
+  late String _transferTarget;
   void _handleTransfer() {
-    showDialog<Null>(
+    showDialog<void>(
       context: context,
       barrierDismissible: false,
       builder: (BuildContext context) {
@@ -275,7 +275,7 @@ class _MyCallScreenWidget extends State<CallScreenWidget>
           content: TextField(
             onChanged: (String text) {
               setState(() {
-                _tansfer_target = text;
+                _transferTarget = text;
               });
             },
             decoration: InputDecoration(
@@ -287,7 +287,7 @@ class _MyCallScreenWidget extends State<CallScreenWidget>
             TextButton(
               child: Text('Ok'),
               onPressed: () {
-                call!.refer(_tansfer_target);
+                call!.refer(_transferTarget);
                 Navigator.of(context).pop();
               },
             ),
@@ -309,7 +309,7 @@ class _MyCallScreenWidget extends State<CallScreenWidget>
   }
 
   void _handleKeyPad() {
-    this.setState(() {
+    setState(() {
       _showNumPad = !_showNumPad;
     });
   }
@@ -324,7 +324,7 @@ class _MyCallScreenWidget extends State<CallScreenWidget>
   }
 
   List<Widget> _buildNumPad() {
-    var lables = [
+    var labels = [
       [
         {'1': ''},
         {'2': 'abc'},
@@ -347,15 +347,15 @@ class _MyCallScreenWidget extends State<CallScreenWidget>
       ],
     ];
 
-    return lables
+    return labels
         .map((row) => Padding(
             padding: const EdgeInsets.all(3),
             child: Row(
                 mainAxisAlignment: MainAxisAlignment.spaceEvenly,
                 children: row
                     .map((label) => ActionButton(
-                          title: '${label.keys.first}',
-                          subTitle: '${label.values.first}',
+                          title: label.keys.first,
+                          subTitle: label.values.first,
                           onPressed: () => _handleDtmf(label.keys.first),
                           number: true,
                         ))
@@ -406,7 +406,7 @@ class _MyCallScreenWidget extends State<CallScreenWidget>
             onPressed: () => _muteAudio(),
           ));
 
-          if (voiceonly) {
+          if (voiceOnly) {
             advanceActions.add(ActionButton(
               title: "keypad",
               icon: Icons.dialpad,
@@ -420,7 +420,7 @@ class _MyCallScreenWidget extends State<CallScreenWidget>
             ));
           }
 
-          if (voiceonly) {
+          if (voiceOnly) {
             advanceActions.add(ActionButton(
               title: _speakerOn ? 'speaker off' : 'speaker on',
               icon: _speakerOn ? Icons.volume_off : Icons.volume_up,
@@ -501,13 +501,13 @@ class _MyCallScreenWidget extends State<CallScreenWidget>
   Widget _buildContent() {
     var stackWidgets = <Widget>[];
 
-    if (!voiceonly && _remoteStream != null) {
+    if (!voiceOnly && _remoteStream != null) {
       stackWidgets.add(Center(
         child: RTCVideoView(_remoteRenderer!),
       ));
     }
 
-    if (!voiceonly && _localStream != null) {
+    if (!voiceOnly && _localStream != null) {
       stackWidgets.add(Container(
         child: AnimatedContainer(
           child: RTCVideoView(_localRenderer!),
@@ -523,7 +523,7 @@ class _MyCallScreenWidget extends State<CallScreenWidget>
 
     stackWidgets.addAll([
       Positioned(
-        top: voiceonly ? 48 : 6,
+        top: voiceOnly ? 48 : 6,
         left: 0,
         right: 0,
         child: Center(
@@ -535,17 +535,17 @@ class _MyCallScreenWidget extends State<CallScreenWidget>
                 child: Padding(
                     padding: const EdgeInsets.all(6),
                     child: Text(
-                      (voiceonly ? 'VOICE CALL' : 'VIDEO CALL') +
+                      (voiceOnly ? 'VOICE CALL' : 'VIDEO CALL') +
                           (_hold
-                              ? ' PAUSED BY ${this._holdOriginator!.toUpperCase()}'
+                              ? ' PAUSED BY ${_holdOriginator!.toUpperCase()}'
                               : ''),
                       style: TextStyle(fontSize: 24, color: Colors.black54),
                     ))),
             Center(
                 child: Padding(
                     padding: const EdgeInsets.all(6),
                     child: Text(
-                      '$remote_identity',
+                      '$remoteIdentity',
                       style: TextStyle(fontSize: 18, color: Colors.black54),
                     ))),
             Center(
@@ -585,6 +585,6 @@ class _MyCallScreenWidget extends State<CallScreenWidget>
 
   @override
   void onNewNotify(Notify ntf) {
-    // TODO: implement onNewNotify
+    // NO OP
   }
 }

example/lib/src/dialpad.dart

@@ -1,13 +1,9 @@
-import 'dart:io';
-
 import 'package:flutter/foundation.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_webrtc/flutter_webrtc.dart';
 import 'package:permission_handler/permission_handler.dart';
 import 'package:shared_preferences/shared_preferences.dart';
 import 'package:sip_ua/sip_ua.dart';
-import 'package:flutter/foundation.dart';
-
 
 import 'widgets/action_button.dart';
 
@@ -49,9 +45,10 @@ class _MyDialPadWidget extends State<DialPadWidget>
   }
 
   Future<Widget?> _handleCall(BuildContext context,
-      [bool voiceonly = false]) async {
+      [bool voiceOnly = false]) async {
     var dest = _textController?.text;
-    if(defaultTargetPlatform == TargetPlatform.android || defaultTargetPlatform == TargetPlatform.iOS) {
+    if (defaultTargetPlatform == TargetPlatform.android ||
+        defaultTargetPlatform == TargetPlatform.iOS) {
       await Permission.microphone.request();
       await Permission.camera.request();
     }
@@ -81,19 +78,19 @@ class _MyDialPadWidget extends State<DialPadWidget>
 
     MediaStream mediaStream;
 
-    if (kIsWeb && !voiceonly) {
+    if (kIsWeb && !voiceOnly) {
       mediaStream =
           await navigator.mediaDevices.getDisplayMedia(mediaConstraints);
       mediaConstraints['video'] = false;
       MediaStream userStream =
           await navigator.mediaDevices.getUserMedia(mediaConstraints);
       mediaStream.addTrack(userStream.getAudioTracks()[0], addToNative: true);
     } else {
-      mediaConstraints['video'] = !voiceonly;
+      mediaConstraints['video'] = !voiceOnly;
       mediaStream = await navigator.mediaDevices.getUserMedia(mediaConstraints);
     }
 
-    helper!.call(dest, voiceonly: voiceonly, mediaStream: mediaStream);
+    helper!.call(dest, voiceonly: voiceOnly, mediaStream: mediaStream);
     _preferences.setString('dest', dest);
     return null;
   }
@@ -115,7 +112,7 @@ class _MyDialPadWidget extends State<DialPadWidget>
   }
 
   List<Widget> _buildNumPad() {
-    var lables = [
+    var labels = [
       [
         {'1': ''},
         {'2': 'abc'},
@@ -138,7 +135,7 @@ class _MyDialPadWidget extends State<DialPadWidget>
       ],
     ];
 
-    return lables
+    return labels
         .map((row) => Padding(
             padding: const EdgeInsets.all(12),
             child: Row(
@@ -322,6 +319,5 @@ class _MyDialPadWidget extends State<DialPadWidget>
   }
 
   @override
-  void onNewNotify(Notify ntf) {
-  }
+  void onNewNotify(Notify ntf) {}
 }

example/lib/src/register.dart

@@ -11,12 +11,13 @@ class RegisterWidget extends StatefulWidget {
 
 class _MyRegisterWidget extends State<RegisterWidget>
     implements SipUaHelperListener {
-  TextEditingController _passwordController = TextEditingController();
-  TextEditingController _wsUriController = TextEditingController();
-  TextEditingController _sipUriController = TextEditingController();
-  TextEditingController _displayNameController = TextEditingController();
-  TextEditingController _authorizationUserController = TextEditingController();
-  Map<String, String> _wsExtraHeaders = {
+  final TextEditingController _passwordController = TextEditingController();
+  final TextEditingController _wsUriController = TextEditingController();
+  final TextEditingController _sipUriController = TextEditingController();
+  final TextEditingController _displayNameController = TextEditingController();
+  final TextEditingController _authorizationUserController =
+      TextEditingController();
+  final Map<String, String> _wsExtraHeaders = {
     // 'Origin': ' https://tryit.jssip.net',
     // 'Host': 'tryit.jssip.net:10443'
   };
@@ -42,7 +43,7 @@ class _MyRegisterWidget extends State<RegisterWidget>
 
   void _loadSettings() async {
     _preferences = await SharedPreferences.getInstance();
-    this.setState(() {
+    setState(() {
       _wsUriController.text =
           _preferences.getString('ws_uri') ?? 'wss://tryit.jssip.net:10443';
       _sipUriController.text =
@@ -65,13 +66,13 @@ class _MyRegisterWidget extends State<RegisterWidget>
 
   @override
   void registrationStateChanged(RegistrationState state) {
-    this.setState(() {
+    setState(() {
       _registerState = state;
     });
   }
 
   void _alert(BuildContext context, String alertFieldName) {
-    showDialog<Null>(
+    showDialog<void>(
       context: context,
       barrierDismissible: false,
       builder: (BuildContext context) {
@@ -296,6 +297,6 @@ class _MyRegisterWidget extends State<RegisterWidget>
 
   @override
   void onNewNotify(Notify ntf) {
-    // TODO: implement onNewNotify
+    // NO OP
   }
 }