Skip to content

Commit 014d866

Browse files
VictorUvarovmikaelwills
authored andcommitted
use rethrow when possible
1 parent be291a3 commit 014d866

7 files changed

+8
-9
lines changed

analysis_options.yaml

-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ analyzer:
5353
avoid_types_as_parameter_names: ignore
5454
empty_catches: ignore
5555
unawaited_futures: ignore
56-
use_rethrow_when_possible: ignore
5756
unused_import: ignore
5857
must_be_immutable: ignore
5958
todo: ignore

lib/src/config.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -286,6 +286,6 @@ void load(Settings src, Settings? dst) {
286286
});
287287
} catch (e) {
288288
logger.e('Failed to load config: ${e.toString()}');
289-
throw e;
289+
rethrow;
290290
}
291291
}

lib/src/rtc_session.dart

+2-2
Original file line numberDiff line numberDiff line change
@@ -2354,7 +2354,7 @@ class RTCSession extends EventManager implements Owner {
23542354
'User Denied Media Access');
23552355
logger.e('emit "getusermediafailed" [error:${error.toString()}]');
23562356
emit(EventGetUserMediaFailed(exception: error));
2357-
throw error;
2357+
rethrow;
23582358
}
23592359
}
23602360

@@ -2406,7 +2406,7 @@ class RTCSession extends EventManager implements Owner {
24062406
return;
24072407
}
24082408
logger.e('Failed to _sendInitialRequest: ${error.toString()}');
2409-
throw error;
2409+
rethrow;
24102410
}
24112411
}
24122412

lib/src/transports/tcp_socket.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ class SIPUATcpSocket extends SIPUASocketInterface {
140140
return true;
141141
} catch (error) {
142142
logger.e('send() | error sending message: $error');
143-
throw error;
143+
rethrow;
144144
}
145145
}
146146

lib/src/transports/web_socket.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ class SIPUAWebSocket extends SIPUASocketInterface {
142142
return true;
143143
} catch (error) {
144144
logger.e('send() | error sending message: $error');
145-
throw error;
145+
rethrow;
146146
}
147147
}
148148

lib/src/transports/websocket_dart_impl.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ class SIPUAWebSocketImpl {
118118
return webSocket;
119119
} catch (e) {
120120
logger.e('error $e');
121-
throw e;
121+
rethrow;
122122
}
123123
}
124124
}

lib/src/ua.dart

+2-2
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ class UA extends EventManager {
9595
} catch (e) {
9696
_status = C.STATUS_NOT_READY;
9797
_error = C.CONFIGURATION_ERROR;
98-
throw e;
98+
rethrow;
9999
}
100100

101101
// Initialize registrator.
@@ -821,7 +821,7 @@ class UA extends EventManager {
821821
try {
822822
config.load(configuration, _configuration);
823823
} catch (e) {
824-
throw e;
824+
rethrow;
825825
}
826826

827827
// Post Configuration Process.

0 commit comments

Comments
 (0)