Skip to content

Commit 6deddd2

Browse files
authored
feat: upgrade esbuld version, drop node 14 in pipelines, use nodejs18… (#552)
* feat: upgrade esbuld version, drop node 14 in pipelines, use nodejs18.x as default runtime * fix: update esbuild-node-externals to version 1.14.0 * fix: esbuild-node-externals breaking change usage * test: fix test failing in node 20 and higher
1 parent 7dc3b64 commit 6deddd2

20 files changed

+301
-242
lines changed

.github/workflows/pull.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
runs-on: ubuntu-latest
1111
strategy:
1212
matrix:
13-
node-version: [14, 16, 18]
13+
node-version: [18, 20, 22]
1414
steps:
1515
- uses: actions/checkout@v3
1616
- name: Use Node.js ${{ matrix.node-version }}

.github/workflows/release.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
runs-on: ubuntu-latest
1111
strategy:
1212
matrix:
13-
node-version: [14, 16, 18]
13+
node-version: [18, 20, 22]
1414
steps:
1515
- uses: actions/checkout@v3
1616
- name: Use Node.js ${{ matrix.node-version }}
@@ -28,7 +28,7 @@ jobs:
2828
- uses: actions/checkout@v3
2929
- uses: actions/setup-node@v3
3030
with:
31-
node-version: 16
31+
node-version: 18
3232
- run: npm ci
3333
- run: npx semantic-release
3434
env:

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ The following `esbuild` options are automatically set.
103103
| `entryPoints` | N/A | Cannot be overridden |
104104
| `outDir` | N/A | Cannot be overridden |
105105
| `platform` | `'node'` | Set `format` to `esm` to enable ESM support |
106-
| `target` | `'node16'` | We dynamically set this. See [Supported Runtimes](#supported-runtimes) |
106+
| `target` | `'node18'` | We dynamically set this. See [Supported Runtimes](#supported-runtimes) |
107107
| `watch` | N/A | Cannot be overridden |
108108

109109
#### Packager Options

e2e/__snapshots__/complete.test.ts.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ exports[`complete 5`] = `
311311
"Arn",
312312
],
313313
},
314-
"Runtime": "nodejs12.x",
314+
"Runtime": "nodejs18.x",
315315
"Timeout": 6,
316316
},
317317
"Type": "AWS::Lambda::Function",

e2e/__snapshots__/individually.test.ts.snap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ exports[`individually 6`] = `
227227
"Arn",
228228
],
229229
},
230-
"Runtime": "nodejs12.x",
230+
"Runtime": "nodejs18.x",
231231
"Timeout": 6,
232232
},
233233
"Type": "AWS::Lambda::Function",
@@ -295,7 +295,7 @@ exports[`individually 6`] = `
295295
"Arn",
296296
],
297297
},
298-
"Runtime": "nodejs12.x",
298+
"Runtime": "nodejs18.x",
299299
"Timeout": 6,
300300
},
301301
"Type": "AWS::Lambda::Function",

e2e/__snapshots__/minimal.test.ts.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14227,7 +14227,7 @@ exports[`minimal 5`] = `
1422714227
"Arn",
1422814228
],
1422914229
},
14230-
"Runtime": "nodejs12.x",
14230+
"Runtime": "nodejs18.x",
1423114231
"Timeout": 6,
1423214232
},
1423314233
"Type": "AWS::Lambda::Function",

examples/complete/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
},
1010
"devDependencies": {
1111
"@types/node": "^18.7.21",
12-
"esbuild": "^0.20.0",
12+
"esbuild": "^0.23.0",
1313
"serverless": "^3.22.0",
1414
"serverless-esbuild": "file:../..",
1515
"serverless-offline": "^10.2.1",

examples/complete/serverless.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ custom:
1616

1717
provider:
1818
name: aws
19-
runtime: nodejs12.x
19+
runtime: nodejs18.x
2020

2121
functions:
2222
validateIsin:

examples/config/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"devDependencies": {
1010
"@types/lodash": "4.14.185",
1111
"@types/node": "^18.7.21",
12-
"esbuild": "^0.20.0",
12+
"esbuild": "^0.23.0",
1313
"serverless": "^3.22.0",
1414
"serverless-esbuild": "file:../..",
1515
"serverless-offline": "^10.2.1"

examples/config/serverless.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ package:
99

1010
provider:
1111
name: aws
12-
runtime: nodejs12.x
12+
runtime: nodejs18.x
1313

1414
custom:
1515
esbuild:

0 commit comments

Comments
 (0)