Skip to content

Commit 9b27303

Browse files
matthiaskrgrmatthiaskrgr
committed
submodules: update clippy from 3710ec5 to ad3269c
Changes: ```` Rustfmt all the things Clippy dogfood Update for compiletest changes Use symbols instead of strings Rustup to rustc 1.36.0-nightly (1764b29 2019-05-12) Add regression test for identity_conversion FP UI test cleanup: Extract many_single_char_names tests Add tests for empty_loop lint Add in_macro again Rename in_macro to in_macro_or_desugar ````
1 parent 09e8d28 commit 9b27303

File tree

110 files changed

+1616
-966
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

110 files changed

+1616
-966
lines changed

‎clippy_lints/src/approx_const.rs

Lines changed: 27 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,13 @@
11
use crate::utils::span_lint;
2+
use crate::utils::sym;
3+
use lazy_static::lazy_static;
24
use rustc::hir::*;
35
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
46
use rustc::{declare_lint_pass, declare_tool_lint};
57
use std::f64::consts as f64;
6-
use syntax::ast::{FloatTy, Lit, LitKind};
8+
use syntax::ast::{FloatTy, LitKind};
79
use syntax::symbol;
10+
use syntax::symbol::Symbol;
811

912
declare_clippy_lint! {
1013
/// **What it does:** Checks for floating point literals that approximate
@@ -30,38 +33,40 @@ declare_clippy_lint! {
3033
"the approximate of a known float constant (in `std::fXX::consts`)"
3134
}
3235

36+
lazy_static! {
3337
// Tuples are of the form (constant, name, min_digits)
34-
const KNOWN_CONSTS: &[(f64, &str, usize)] = &[
35-
(f64::E, "E", 4),
36-
(f64::FRAC_1_PI, "FRAC_1_PI", 4),
37-
(f64::FRAC_1_SQRT_2, "FRAC_1_SQRT_2", 5),
38-
(f64::FRAC_2_PI, "FRAC_2_PI", 5),
39-
(f64::FRAC_2_SQRT_PI, "FRAC_2_SQRT_PI", 5),
40-
(f64::FRAC_PI_2, "FRAC_PI_2", 5),
41-
(f64::FRAC_PI_3, "FRAC_PI_3", 5),
42-
(f64::FRAC_PI_4, "FRAC_PI_4", 5),
43-
(f64::FRAC_PI_6, "FRAC_PI_6", 5),
44-
(f64::FRAC_PI_8, "FRAC_PI_8", 5),
45-
(f64::LN_10, "LN_10", 5),
46-
(f64::LN_2, "LN_2", 5),
47-
(f64::LOG10_E, "LOG10_E", 5),
48-
(f64::LOG2_E, "LOG2_E", 5),
49-
(f64::PI, "PI", 3),
50-
(f64::SQRT_2, "SQRT_2", 5),
38+
static ref KNOWN_CONSTS: [(f64, Symbol, usize); 16] = [
39+
(f64::E, *sym::E, 4),
40+
(f64::FRAC_1_PI, *sym::FRAC_1_PI, 4),
41+
(f64::FRAC_1_SQRT_2, *sym::FRAC_1_SQRT_2, 5),
42+
(f64::FRAC_2_PI, *sym::FRAC_2_PI, 5),
43+
(f64::FRAC_2_SQRT_PI, *sym::FRAC_2_SQRT_PI, 5),
44+
(f64::FRAC_PI_2, *sym::FRAC_PI_2, 5),
45+
(f64::FRAC_PI_3, *sym::FRAC_PI_3, 5),
46+
(f64::FRAC_PI_4, *sym::FRAC_PI_4, 5),
47+
(f64::FRAC_PI_6, *sym::FRAC_PI_6, 5),
48+
(f64::FRAC_PI_8, *sym::FRAC_PI_8, 5),
49+
(f64::LN_10, *sym::LN_10, 5),
50+
(f64::LN_2, *sym::LN_2, 5),
51+
(f64::LOG10_E, *sym::LOG10_E, 5),
52+
(f64::LOG2_E, *sym::LOG2_E, 5),
53+
(f64::PI, *sym::PI, 3),
54+
(f64::SQRT_2, *sym::SQRT_2, 5),
5155
];
56+
}
5257

5358
declare_lint_pass!(ApproxConstant => [APPROX_CONSTANT]);
5459

5560
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for ApproxConstant {
5661
fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, e: &'tcx Expr) {
5762
if let ExprKind::Lit(lit) = &e.node {
58-
check_lit(cx, lit, e);
63+
check_lit(cx, &lit.node, e);
5964
}
6065
}
6166
}
6267

63-
fn check_lit(cx: &LateContext<'_, '_>, lit: &Lit, e: &Expr) {
64-
match lit.node {
68+
fn check_lit(cx: &LateContext<'_, '_>, lit: &LitKind, e: &Expr) {
69+
match *lit {
6570
LitKind::Float(s, FloatTy::F32) => check_known_consts(cx, e, s, "f32"),
6671
LitKind::Float(s, FloatTy::F64) => check_known_consts(cx, e, s, "f64"),
6772
LitKind::FloatUnsuffixed(s) => check_known_consts(cx, e, s, "f{32, 64}"),
@@ -72,7 +77,7 @@ fn check_lit(cx: &LateContext<'_, '_>, lit: &Lit, e: &Expr) {
7277
fn check_known_consts(cx: &LateContext<'_, '_>, e: &Expr, s: symbol::Symbol, module: &str) {
7378
let s = s.as_str();
7479
if s.parse::<f64>().is_ok() {
75-
for &(constant, name, min_digits) in KNOWN_CONSTS {
80+
for &(constant, name, min_digits) in KNOWN_CONSTS.iter() {
7681
if is_approx_const(constant, &s, min_digits) {
7782
span_lint(
7883
cx,

‎clippy_lints/src/assertions_on_constants.rs

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@ use rustc::{declare_lint_pass, declare_tool_lint};
55
use syntax_pos::Span;
66

77
use crate::consts::{constant, Constant};
8-
use crate::utils::{in_macro, is_direct_expn_of, span_help_and_lint};
8+
use crate::utils::sym;
9+
use crate::utils::{in_macro_or_desugar, is_direct_expn_of, span_help_and_lint};
910

1011
declare_clippy_lint! {
1112
/// **What it does:** Checks for `assert!(true)` and `assert!(false)` calls.
@@ -34,16 +35,16 @@ declare_lint_pass!(AssertionsOnConstants => [ASSERTIONS_ON_CONSTANTS]);
3435
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for AssertionsOnConstants {
3536
fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, e: &'tcx Expr) {
3637
let mut is_debug_assert = false;
37-
let debug_assert_not_in_macro = |span: Span| {
38+
let debug_assert_not_in_macro_or_desugar = |span: Span| {
3839
is_debug_assert = true;
3940
// Check that `debug_assert!` itself is not inside a macro
40-
!in_macro(span)
41+
!in_macro_or_desugar(span)
4142
};
4243
if_chain! {
43-
if let Some(assert_span) = is_direct_expn_of(e.span, "assert");
44-
if !in_macro(assert_span)
45-
|| is_direct_expn_of(assert_span, "debug_assert")
46-
.map_or(false, debug_assert_not_in_macro);
44+
if let Some(assert_span) = is_direct_expn_of(e.span, *sym::assert);
45+
if !in_macro_or_desugar(assert_span)
46+
|| is_direct_expn_of(assert_span, *sym::debug_assert)
47+
.map_or(false, debug_assert_not_in_macro_or_desugar);
4748
if let ExprKind::Unary(_, ref lit) = e.node;
4849
if let Some(bool_const) = constant(cx, cx.tables, lit);
4950
then {

‎clippy_lints/src/assign_ops.rs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ use crate::utils::{
99
get_trait_def_id, implements_trait, snippet_opt, span_lint_and_then, trait_ref_of_method, SpanlessEq,
1010
};
1111
use crate::utils::{higher, sugg};
12+
use syntax::symbol::Symbol;
1213

1314
declare_clippy_lint! {
1415
/// **What it does:** Checks for `a = a op b` or `a = b commutative_op a`
@@ -88,8 +89,11 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for AssignOps {
8889
$($trait_name:ident),+) => {
8990
match $op {
9091
$(hir::BinOpKind::$trait_name => {
91-
let [krate, module] = crate::utils::paths::OPS_MODULE;
92-
let path = [krate, module, concat!(stringify!($trait_name), "Assign")];
92+
let [krate, module] = *crate::utils::paths::OPS_MODULE;
93+
let ident = {
94+
*crate::utils::sym::assign::$trait_name
95+
};
96+
let path: [Symbol; 3] = [krate, module, ident];
9397
let trait_id = if let Some(trait_id) = get_trait_def_id($cx, &path) {
9498
trait_id
9599
} else {

‎clippy_lints/src/attrs.rs

Lines changed: 21 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
//! checks for attributes
22
33
use crate::reexport::*;
4+
use crate::utils::sym;
45
use crate::utils::{
5-
in_macro, is_present_in_source, last_line_of_span, paths, snippet_opt, span_lint, span_lint_and_sugg,
6-
span_lint_and_then, without_block_comments,
6+
in_macro_or_desugar, is_present_in_source, last_line_of_span, match_def_path, paths, snippet_opt, span_lint,
7+
span_lint_and_sugg, span_lint_and_then, without_block_comments,
78
};
89
use if_chain::if_chain;
910
use rustc::hir::*;
@@ -17,6 +18,7 @@ use rustc_errors::Applicability;
1718
use semver::Version;
1819
use syntax::ast::{AttrStyle, Attribute, Lit, LitKind, MetaItemKind, NestedMetaItem};
1920
use syntax::source_map::Span;
21+
use syntax::symbol::Symbol;
2022

2123
declare_clippy_lint! {
2224
/// **What it does:** Checks for items annotated with `#[inline(always)]`,
@@ -205,14 +207,14 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Attributes {
205207
},
206208
_ => {},
207209
}
208-
if items.is_empty() || !attr.check_name("deprecated") {
210+
if items.is_empty() || !attr.check_name(*sym::deprecated) {
209211
return;
210212
}
211213
for item in items {
212214
if_chain! {
213215
if let NestedMetaItem::MetaItem(mi) = &item;
214216
if let MetaItemKind::NameValue(lit) = &mi.node;
215-
if mi.check_name("since");
217+
if mi.check_name(*sym::since);
216218
then {
217219
check_semver(cx, item.span(), lit);
218220
}
@@ -228,7 +230,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Attributes {
228230
}
229231
match item.node {
230232
ItemKind::ExternCrate(..) | ItemKind::Use(..) => {
231-
let skip_unused_imports = item.attrs.iter().any(|attr| attr.check_name("macro_use"));
233+
let skip_unused_imports = item.attrs.iter().any(|attr| attr.check_name(*sym::macro_use));
232234

233235
for attr in &item.attrs {
234236
if in_external_macro(cx.sess(), attr.span) {
@@ -243,15 +245,17 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Attributes {
243245
for lint in lint_list {
244246
match item.node {
245247
ItemKind::Use(..) => {
246-
if is_word(lint, "unused_imports") || is_word(lint, "deprecated") {
248+
if is_word(lint, *sym::unused_imports)
249+
|| is_word(lint, *sym::deprecated)
250+
{
247251
return;
248252
}
249253
},
250254
ItemKind::ExternCrate(..) => {
251-
if is_word(lint, "unused_imports") && skip_unused_imports {
255+
if is_word(lint, *sym::unused_imports) && skip_unused_imports {
252256
return;
253257
}
254-
if is_word(lint, "unused_extern_crates") {
258+
if is_word(lint, *sym::unused_extern_crates) {
255259
return;
256260
}
257261
},
@@ -395,7 +399,7 @@ fn is_relevant_expr(cx: &LateContext<'_, '_>, tables: &ty::TypeckTables<'_>, exp
395399
ExprKind::Call(path_expr, _) => {
396400
if let ExprKind::Path(qpath) = &path_expr.node {
397401
if let Some(fun_id) = tables.qpath_res(qpath, path_expr.hir_id).opt_def_id() {
398-
!cx.match_def_path(fun_id, &paths::BEGIN_PANIC)
402+
!match_def_path(cx, fun_id, &*paths::BEGIN_PANIC)
399403
} else {
400404
true
401405
}
@@ -408,7 +412,7 @@ fn is_relevant_expr(cx: &LateContext<'_, '_>, tables: &ty::TypeckTables<'_>, exp
408412
}
409413

410414
fn check_attrs(cx: &LateContext<'_, '_>, span: Span, name: Name, attrs: &[Attribute]) {
411-
if in_macro(span) {
415+
if in_macro_or_desugar(span) {
412416
return;
413417
}
414418

@@ -441,10 +445,10 @@ fn check_attrs(cx: &LateContext<'_, '_>, span: Span, name: Name, attrs: &[Attrib
441445
}
442446

443447
if let Some(values) = attr.meta_item_list() {
444-
if values.len() != 1 || !attr.check_name("inline") {
448+
if values.len() != 1 || !attr.check_name(*sym::inline) {
445449
continue;
446450
}
447-
if is_word(&values[0], "always") {
451+
if is_word(&values[0], *sym::always) {
448452
span_lint(
449453
cx,
450454
INLINE_ALWAYS,
@@ -473,7 +477,7 @@ fn check_semver(cx: &LateContext<'_, '_>, span: Span, lit: &Lit) {
473477
);
474478
}
475479

476-
fn is_word(nmi: &NestedMetaItem, expected: &str) -> bool {
480+
fn is_word(nmi: &NestedMetaItem, expected: Symbol) -> bool {
477481
if let NestedMetaItem::MetaItem(mi) = &nmi {
478482
mi.is_word() && mi.check_name(expected)
479483
} else {
@@ -487,16 +491,16 @@ impl EarlyLintPass for DeprecatedCfgAttribute {
487491
fn check_attribute(&mut self, cx: &EarlyContext<'_>, attr: &Attribute) {
488492
if_chain! {
489493
// check cfg_attr
490-
if attr.check_name("cfg_attr");
494+
if attr.check_name(*sym::cfg_attr);
491495
if let Some(items) = attr.meta_item_list();
492496
if items.len() == 2;
493497
// check for `rustfmt`
494498
if let Some(feature_item) = items[0].meta_item();
495-
if feature_item.check_name("rustfmt");
499+
if feature_item.check_name(*sym::rustfmt);
496500
// check for `rustfmt_skip` and `rustfmt::skip`
497501
if let Some(skip_item) = &items[1].meta_item();
498-
if skip_item.check_name("rustfmt_skip") ||
499-
skip_item.path.segments.last().expect("empty path in attribute").ident.name == "skip";
502+
if skip_item.check_name(*sym::rustfmt_skip) ||
503+
skip_item.path.segments.last().expect("empty path in attribute").ident.name == *sym::skip;
500504
// Only lint outer attributes, because custom inner attributes are unstable
501505
// Tracking issue: https://github.com/rust-lang/rust/issues/54726
502506
if let AttrStyle::Outer = attr.style;

‎clippy_lints/src/block_in_if_condition.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ impl<'a, 'tcx: 'a> Visitor<'tcx> for ExVisitor<'a, 'tcx> {
5454
if let ExprKind::Closure(_, _, eid, _, _) = expr.node {
5555
let body = self.cx.tcx.hir().body(eid);
5656
let ex = &body.value;
57-
if matches!(ex.node, ExprKind::Block(_, _)) && !in_macro(body.value.span) {
57+
if matches!(ex.node, ExprKind::Block(_, _)) && !in_macro_or_desugar(body.value.span) {
5858
self.found_block = Some(ex);
5959
return;
6060
}
@@ -79,7 +79,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for BlockInIfCondition {
7979
if let Some(ex) = &block.expr {
8080
// don't dig into the expression here, just suggest that they remove
8181
// the block
82-
if in_macro(expr.span) || differing_macro_contexts(expr.span, ex.span) {
82+
if in_macro_or_desugar(expr.span) || differing_macro_contexts(expr.span, ex.span) {
8383
return;
8484
}
8585
span_help_and_lint(
@@ -96,7 +96,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for BlockInIfCondition {
9696
}
9797
} else {
9898
let span = block.expr.as_ref().map_or_else(|| block.stmts[0].span, |e| e.span);
99-
if in_macro(span) || differing_macro_contexts(expr.span, span) {
99+
if in_macro_or_desugar(span) || differing_macro_contexts(expr.span, span) {
100100
return;
101101
}
102102
// move block higher

‎clippy_lints/src/booleans.rs

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
1+
use crate::utils::sym;
12
use crate::utils::{
2-
get_trait_def_id, implements_trait, in_macro, match_type, paths, snippet_opt, span_lint_and_then, SpanlessEq,
3+
get_trait_def_id, implements_trait, in_macro, in_macro_or_desugar, match_type, paths, snippet_opt,
4+
span_lint_and_then, SpanlessEq,
35
};
6+
use lazy_static::lazy_static;
47
use rustc::hir::intravisit::*;
58
use rustc::hir::*;
69
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
@@ -9,6 +12,7 @@ use rustc_data_structures::thin_vec::ThinVec;
912
use rustc_errors::Applicability;
1013
use syntax::ast::LitKind;
1114
use syntax::source_map::{dummy_spanned, Span, DUMMY_SP};
15+
use syntax::symbol::Symbol;
1216

1317
declare_clippy_lint! {
1418
/// **What it does:** Checks for boolean expressions that can be written more
@@ -48,8 +52,13 @@ declare_clippy_lint! {
4852
"boolean expressions that contain terminals which can be eliminated"
4953
}
5054

55+
lazy_static! {
5156
// For each pairs, both orders are considered.
52-
const METHODS_WITH_NEGATION: [(&str, &str); 2] = [("is_some", "is_none"), ("is_err", "is_ok")];
57+
static ref METHODS_WITH_NEGATION: [(Symbol, Symbol); 2] = [
58+
(*sym::is_some, *sym::is_none),
59+
(*sym::is_err, *sym::is_ok),
60+
];
61+
}
5362

5463
declare_lint_pass!(NonminimalBool => [NONMINIMAL_BOOL, LOGIC_BUG]);
5564

@@ -93,7 +102,7 @@ impl<'a, 'tcx, 'v> Hir2Qmm<'a, 'tcx, 'v> {
93102

94103
fn run(&mut self, e: &'v Expr) -> Result<Bool, String> {
95104
// prevent folding of `cfg!` macros and the like
96-
if !in_macro(e.span) {
105+
if !in_macro_or_desugar(e.span) {
97106
match &e.node {
98107
ExprKind::Unary(UnNot, inner) => return Ok(Bool::Not(box self.run(inner)?)),
99108
ExprKind::Binary(binop, lhs, rhs) => match &binop.node {
@@ -186,16 +195,16 @@ impl<'a, 'tcx, 'v> SuggestContext<'a, 'tcx, 'v> {
186195
},
187196
ExprKind::MethodCall(path, _, args) if args.len() == 1 => {
188197
let type_of_receiver = self.cx.tables.expr_ty(&args[0]);
189-
if !match_type(self.cx, type_of_receiver, &paths::OPTION)
190-
&& !match_type(self.cx, type_of_receiver, &paths::RESULT)
198+
if !match_type(self.cx, type_of_receiver, &*paths::OPTION)
199+
&& !match_type(self.cx, type_of_receiver, &*paths::RESULT)
191200
{
192201
return None;
193202
}
194203
METHODS_WITH_NEGATION
195204
.iter()
196205
.cloned()
197206
.flat_map(|(a, b)| vec![(a, b), (b, a)])
198-
.find(|&(a, _)| a == path.ident.as_str())
207+
.find(|&(a, _)| a == path.ident.name)
199208
.and_then(|(_, neg_method)| Some(format!("{}.{}()", self.snip(&args[0])?, neg_method)))
200209
},
201210
_ => None,
@@ -465,5 +474,5 @@ impl<'a, 'tcx> Visitor<'tcx> for NonminimalBoolVisitor<'a, 'tcx> {
465474

466475
fn implements_ord<'a, 'tcx>(cx: &'a LateContext<'a, 'tcx>, expr: &Expr) -> bool {
467476
let ty = cx.tables.expr_ty(expr);
468-
get_trait_def_id(cx, &paths::ORD).map_or(false, |id| implements_trait(cx, ty, id, &[]))
477+
get_trait_def_id(cx, &*paths::ORD).map_or(false, |id| implements_trait(cx, ty, id, &[]))
469478
}

0 commit comments

Comments
 (0)