Fix #31

Author: asistradition

CHANGELOG.md

@@ -1,3 +1,7 @@
+### Version 0.9.8
+
+* Fix #31: Remove ndim check from sparse vector ctypes wrapper to accommodate np.matrix arrays that can't be flattened
+
 ### Version 0.9.7
 
 * Fix #28: incorrect output when `out` is provided but the matrix multiplication is trivially all zeros

setup.py

@@ -2,7 +2,7 @@
 from setuptools import setup, find_packages
 
 DISTNAME = 'sparse_dot_mkl'
-VERSION = '0.9.7'
+VERSION = '0.9.8'
 DESCRIPTION = "Intel MKL wrapper for sparse matrix multiplication"
 MAINTAINER = 'Chris Jackson'
 MAINTAINER_EMAIL = 'cj59@nyu.edu'

sparse_dot_mkl/__init__.py

@@ -1,4 +1,4 @@
-__version__ = '0.9.7'
+__version__ = '0.9.8'
 
 
 from sparse_dot_mkl.sparse_dot import (

sparse_dot_mkl/_mkl_interface/_cfunctions.py

@@ -631,7 +631,7 @@ def _mv_argtypes(prec_type, _np_type):
             prec_type,
             sparse_matrix_t,
             matrix_descr,
-            ndpointer(dtype=_np_type, ndim=1),
+            ndpointer(dtype=_np_type),
             prec_type,
             ndpointer(dtype=_np_type),
         ]

sparse_dot_mkl/_mkl_interface/_common.py

@@ -914,8 +914,14 @@ def _out_matrix(
 
     # If there's no output array allocate a new array and return it
     if out_arr is None and initialize_zeros:
+        debug_print(
+            f"Allocating array {shape} ({order}) ({dtype})"
+        )
         return _np.zeros(shape, dtype=dtype, order=order)
     elif out_arr is None:
+        debug_print(
+            f"Allocating array {shape} ({order}) ({dtype})"
+        )
         return _np.ndarray(shape, dtype=dtype, order=order)
 
     # Check and make sure the order is correct
@@ -963,6 +969,9 @@ def _out_matrix(
         )
 
     else:
+        debug_print(
+            f"Using output array {shape} ({order}) ({dtype})"
+        )
         return out_arr
 
 

sparse_dot_mkl/tests/test_scipy_classes.py

@@ -1,6 +1,7 @@
 import unittest
 import numpy.testing as npt
 import scipy as sp
+import numpy as np
 import scipy.sparse as sps
 from types import MethodType
 
@@ -48,6 +49,24 @@ def test_matmul(self):
             MATMUL
         )
 
+    def test_sum_0(self):
+        
+        a = self.arr(MATRIX_1)
+        
+        npt.assert_almost_equal(
+            a.sum(axis=0),
+            np.sum(a, axis=0)
+        )
+
+    def test_sum_1(self):
+        
+        a = self.arr(MATRIX_1)
+
+        npt.assert_almost_equal(
+            a.sum(axis=1),
+            np.sum(a, axis=1)
+        )
+
     def test_matmul_dense(self):
 
         a = self.arr(MATRIX_1)