Skip to content

Commit 66e381b

Browse files
committed
ci-automation: Use a valid reference
`show_changes_params` is not available in this lexical scope, we should have been using `show_changes_params_ref`. This has worked so far only because all the callers of the functions were passing `show_changes_params` to be referenced by `show_changes_params_ref`. Just a lucky happenstance. Spotted by Chewi.
1 parent 4170901 commit 66e381b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

ci-automation/image_changes.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -426,7 +426,7 @@ function prepare_env_vars_and_params_for_release() {
426426

427427
# Nothing to prepend to show_changes_env.
428428
show_changes_env_ref=()
429-
show_changes_params=(
429+
show_changes_params_ref=(
430430
"NEW_CHANNEL=${new_channel}"
431431
"NEW_CHANNEL_PREV_VERSION=${new_channel_prev_version}"
432432
# Channel transition stuff
@@ -481,7 +481,7 @@ function prepare_env_vars_and_params_for_nightly() {
481481

482482
# Nothing to prepend to show_changes_env.
483483
show_changes_env_ref=()
484-
show_changes_params=(
484+
show_changes_params_ref=(
485485
"NEW_CHANNEL=${ppfb_channel}"
486486
"NEW_CHANNEL_PREV_VERSION=${ppfb_vernum}"
487487
# Channel transition stuff, we set the old channel to be the

0 commit comments

Comments
 (0)